From: "plaisthos (Code Review)"
Date: Mon, 11 Dec 2023 15:56:28 +0000
In-Reply-To:
References:
Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net,
frank@...2641...
Message-ID: <0a1abe6920047be3997cc1cc1aeb74193df401eb-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="INwj65IZLuo="; charset=UTF-8
Subject: [Openvpn-devel] [L] Change in openvpn[master]: test_user_pass: new
UT for get_user_pass
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: flichtenheld
Cc: openvpn-devel
--INwj65IZLuo=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c=
/openvpn/+/468?usp=3Demail )
Change subject: test_user_pass: new UT for get_user_pass
......................................................................
Patch Set 3:
(1 comment)
File CMakeLists.txt:
http://gerrit.openvpn.net/c/openvpn/+/468/comment/010f5528_3a64e9cc :
PS3, Line 625: ENVIRONMENT "srcdir=3D${CMAKE_CURRENT_SOURCE=
_DIR}/tests/unit_tests/openvpn")
> Also my IDE (Clion) does not pick this up, so I have manually configure t=
o add that environment vari [=E2=80=A6]
Alternative solution with the define: https://gerrit.openvpn.net/c/openvpn/=
+/446
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/468?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I193aef06912f01426dd4ac298aadfab97dd75a35
Gerrit-Change-Number: 468
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Mon, 11 Dec 2023 15:56:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos
Gerrit-MessageType: comment
--INwj65IZLuo=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld.
View C=
hange
1 comment:
<=
li style=3D"margin: 0; padding: 0;">File CMakeLists.txt:
Alternative solution=
with the define: https://gerrit.openvpn.net/c/openvpn/+/446
<=
/li>To view, visit change 468. To unsubscribe, or for help writing mail =
filters, visit settings.=
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I193aef06912f01426dd4ac298aa=
dfab97dd75a35
Gerrit-Change-Number: 468
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <frank@...2723...=
.>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Comment-Date: Mon, 11 Dec 2023 15:56:28=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <arne-openvp=
n@...1227...>
Gerrit-MessageType: comment
--INwj65IZLuo=--