Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF815C433EF for ; Wed, 5 Jan 2022 14:33:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB63710F730; Wed, 5 Jan 2022 14:33:55 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8D8D310F730 for ; Wed, 5 Jan 2022 14:33:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641393234; x=1672929234; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=Af4eeBD1VXr8NH1oteHCCKWYzAasHPTkE3XDYLcK2Gw=; b=mfrO84DiKhSnuG41zpsh5qfNWl27TXhri0jD1u5AaGMnRwhvZGUUKsvd DlFpZJmBEyqSTo66Kd/nOl2uD6jb+c/e3/MZoYs3/7X9MmlXF1aZWgPI9 hKFXXo4A77EYutfi1l0yaojnkXo9fXEXN/SGYXyFOEPSzNqE6FZTy+TQd DiWYMXbWnlxgNEGlvxU3CsXEJmUpJHe7xcZnBkH86ib0iEKxzM5Lo91lb sUX2nLHDnBYn9SowuqDyIbdFrshR+os6rMbSO/23I1ROt9g6NdVKt7QWy SxPQjrrYc0Syv0vy5L1lCRmMVJCaGh1eR8aG1IjgDYE/SHE2arx88hz+I g==; X-IronPort-AV: E=McAfee;i="6200,9189,10217"; a="303207026" X-IronPort-AV: E=Sophos;i="5.88,264,1635231600"; d="scan'208";a="303207026" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2022 06:33:25 -0800 X-IronPort-AV: E=Sophos;i="5.88,264,1635231600"; d="scan'208";a="472514618" Received: from jwebb-mobl1.ger.corp.intel.com (HELO [10.213.202.78]) ([10.213.202.78]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2022 06:33:24 -0800 Message-ID: <0a340da0-ccdc-c90f-b181-1f0ad3d5a440@linux.intel.com> Date: Wed, 5 Jan 2022 14:33:22 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Content-Language: en-US To: Jani Nikula , intel-gfx@lists.freedesktop.org References: <20220105100520.976092-1-jani.nikula@intel.com> <20220105100520.976092-2-jani.nikula@intel.com> <170a7507-ff7e-204f-eba3-89571ab87842@linux.intel.com> <875yqytqv4.fsf@intel.com> <87ee5mjp7h.fsf@intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc In-Reply-To: <87ee5mjp7h.fsf@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/uncore: rename i915_reg_read_ioctl intel_uncore_reg_read_ioctl X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 05/01/2022 13:18, Jani Nikula wrote: > On Wed, 05 Jan 2022, Tvrtko Ursulin wrote: >> On 05/01/2022 10:32, Jani Nikula wrote: >>> On Wed, 05 Jan 2022, Tvrtko Ursulin wrote: >>>> On 05/01/2022 10:05, Jani Nikula wrote: >>>>> Follow the usual naming convention. >>>> >>>> But intel_uncore_ prefix usually means functions takes intel_uncore as >>>> the first argument. >>>> >>>> Maybe solution here is that i915_reg_read_ioctl does not belong in >>>> intel_uncore.c, it being the UAPI layer thing? I guess arguments could >>>> be made for either way. >>> >>> My position is that the function and file prefixes go hand in >>> hand. You'll always know where to place a function, and you'll always >>> know where the function is to be found. >>> >>> If you can *also* make the context argument follow the pattern, it's >>> obviously better, and indicates the division to files is working out >>> nicely. However, in a lot of cases you'll need to pass struct >>> drm_i915_private or similar as the first parameter to e.g. init >>> functions. It can't be the rigid rule. >>> >>> I'm fine with moving the entire function somewhere else, as long as the >>> declaration is not in i915_drv.h. There's no longer a i915_drv.c, and >>> i915_drv.h should not have function declarations at all. >> >> Yes I agree it cannot be a rigid rule. I just that it feels >> intel_uncore.[hc] is too low level to me to hold an ioctl >> implementation, and header actually feels wrong to have the declaration. >> Not least it is about _one_ of the uncores, while the ioctl is not >> operating on that level, albeit undefined at the moment how exactly it >> would work for multi-tile. >> >> Would it be too early, or unwarranted at this point, to maybe consider >> adding i915_ioctls.[hc]? > > Then the conversation would be about putting together a ton of unrelated > functions where the only thing in common is that they're an ioctl > implementation. Arguably many of them would have less in common than the > reg read ioctl has with uncore! I imagined it as a place for ioctls which don't fit anywhere else, like it this case it is not a family of ioctls but and odd one out. So yes, first "problem" would be there is only one to put there and no line of sight for others. > And when is it okay to put an ioctl in the i915_ioctls.c file and when > is it warranted to put it somewhere else? It's just a different set of > problems. When it does not fit anywhere else? >> I like the i915_ prefix of ioctls for consistency.. i915_getparam_ioctl, >> i915_query_ioctl, i915_perf_..., i915_gem_.... > > The display ioctls have intel_ prefix anyway. It's the _ioctl suffix > that we use. > > Again, my main driver here is cleaning up i915_drv.h. I can shove the > reg read ioctl somewhere other than intel_uncore.[ch] too. But as it > stands, the only alternative that seems better than intel_uncore.[ch] at > the moment is adding a dedicated file for a 60-line function. I understand your motivation and I wouldn't nack your efforts, but I also cannot yet make myself ack it. Is 60 lines so bad? Lets see.. $ find . -name "*.c" -print0 | xargs -0 wc -l | sort -nr ... 59 ./selftests/mock_request.c 59 ./gt/uc/intel_uc_debugfs.c 59 ./gem/i915_gemfs.c 52 ./selftests/igt_mmap.c 51 ./selftests/igt_reset.c 49 ./selftests/mock_uncore.c 47 ./selftests/igt_atomic.c 36 ./gt/uc/intel_huc_debugfs.c 36 ./gt/intel_gt_engines_debugfs.c 35 ./selftests/igt_flush_test.c 34 ./selftests/librapl.c 34 ./gvt/trace_points.c 29 ./gt/selftests/mock_timeline.c 27 ./gt/selftest_engine.c 26 ./gt/uc/intel_huc_fw.c 15 ./i915_config.c 14 ./i915_trace_points.c 9 ./display/intel_display_trace.c So kind of meh, wouldn't be first. I'd add a dedicated file just for the benefit of being able to legitimately keep the i915_reg_read_ioctl name. Come multi-tile it may get company. Even though at the moment I am not aware anyone is trying to add multi-tile aware reg read, but I expect there will be need as long as need for the existing one exists. Regards, Tvrtko