From: Dmitry Osipenko Subject: Re: [PATCH V5 2/7] clocksource: tegra: add Tegra210 timer support Date: Sat, 2 Feb 2019 16:38:42 +0300 Message-ID: <0a5721cc-6cbf-9f1f-6282-36b7175ce9a2@gmail.com> References: <20190201033621.16814-1-josephl@nvidia.com> <20190201033621.16814-3-josephl@nvidia.com> <9370a0e4-2c76-6e9e-9219-121f92cdb14a@gmail.com> <46a1a62f-29b1-caac-ba68-e1394a76b3af@gmail.com> <85988378-0c88-6b71-00df-0700a7b4cdf7@nvidia.com> <4c89fd38-eacd-4643-52d3-da4760ecb4c5@nvidia.com> <57549882-4d0a-64ac-da04-7e790ac2d80e@gmail.com> <9437d5b5-5af0-9393-169c-2ebaf384c75c@nvidia.com> <705a0eff-cb1e-0e7d-add7-fb1a993291dc@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Joseph Lo , Jon Hunter , Thierry Reding , Daniel Lezcano , Thomas Gleixner Cc: linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Thierry Reding List-Id: linux-tegra@vger.kernel.org 02.02.2019 2:53, Joseph Lo пишет: > On 2/2/19 2:08 AM, Dmitry Osipenko wrote: >> 01.02.2019 18:37, Joseph Lo пишет: >>> On 2/1/19 11:13 PM, Dmitry Osipenko wrote: >>>> 01.02.2019 17:13, Joseph Lo пишет: >>>>> On 2/1/19 9:54 PM, Jon Hunter wrote: >>>>>> >>>>>> On 01/02/2019 13:11, Dmitry Osipenko wrote: >>>>>>> 01.02.2019 16:06, Dmitry Osipenko пишет: >>>>>>>> 01.02.2019 6:36, Joseph Lo пишет: >>>>>>>>> Add support for the Tegra210 timer that runs at oscillator clock >>>>>>>>> (TMR10-TMR13). We need these timers to work as clock event device and to >>>>>>>>> replace the ARMv8 architected timer due to it can't survive across the >>>>>>>>> power cycle of the CPU core or CPUPORESET signal. So it can't be a wake-up >>>>>>>>> source when CPU suspends in power down state. >>>>>>>>> >>>>>>>>> Also convert the original driver to use timer-of API. >>>>>>>>> >>>>>>>>> Cc: Daniel Lezcano >>>>>>>>> Cc: Thomas Gleixner >>>>>>>>> Cc: linux-kernel@vger.kernel.org >>>>>>>>> Signed-off-by: Joseph Lo >>>>>>>>> Acked-by: Thierry Reding >>>>>>>>> --- >>> snip. >>>>>>>>> +} >>>>>>>>> +TIMER_OF_DECLARE(tegra210_timer, "nvidia,tegra210-timer", tegra210_timer_init); >>>>>>>>> +#else /* CONFIG_ARM */ >>>>>>>>> +static int __init tegra20_init_timer(struct device_node *np) >>>>>>>>> +{ >>>>>>>> What about T132? Isn't it ARM64 which uses tegra20-timer IP? At least T132 DT suggests so and seems this change will break it. >>>>>>>> >>>>>>>> [snip] >>>>>>>> >>>>>>> >>>>>>> Ah, noticed the "depends on ARM" in Kconfig.. Seems okay then. >>>>>>> >>>>>> >>>>>> >>>>>> This is a good point, because even though we had 'depends on ARM', this >>>>>> still means that the Tegra132 DT is incorrect. >>>>>> >>>>>> Joseph, can you take a quick look at Tegra132? >>>>> >>>>> Hi Jon and Dmitry, >>>>> >>>>> No worry about T132, T132 uses arch timer (v7). The tegra20 timer driver has never been used. We should fix the dtsi file later. >>>> >>>> Hi Joseph, >>>> >>>> So is T132 HW actually incompatible with the tegra20-timer? If it's compatible, then I think the driver's code should be made more universal to support T132. >>>> >>> >>>  From HW point of view, the TIMER1 ~ TIMER4 is compatible with "nvidia,tegra20-timer". But Tegra132 actually has 10 timers which are exactly the same as Tegra30. So it should backward compatible with "nvidia,tegra30-timer", which is tegra_wdt driver now. And Tegra132 should never use this driver. >>> >>> The Tegra timer driver should only be used on Tegra20/30/210, three platforms only. Others use arch timer driver for system timer driver. >>> >>> So we don't really need to take care the usage on other Tegra platforms. >> >> Doesn't Linux kernel put in use all of available timers? If yes, then we probably would want to expose all available timers. It looks to me that right now tegra20-timer exposes only a single-shared timer to the system [please correct me if I'm wrong]. Wouldn't make sense at least to give a timer per CPU core? >> > > No, only one timer driver works at a time. ( see /proc/timer_list to check which timer is working.) Okay, thanks for the clarification. >> It looks to me that right now tegra20-timer exposes only a single-shared timer to the system [please correct me if I'm wrong]. Wouldn't make sense at least to give a timer per CPU core? > > Yes, it's correct. the timer-tegra20 only provides a single-shared timer. And yes, ,it should provide a timer per CPU core. But that is another task, this patch only introduce the timer support for Tegra210. Others that originally from timer-tegra20 driver still remain the same. I may take a look at it. Could be better for older Tegra's to use tegra20-timer for the per-CPU timer since TWD timer has some time-jitter due to DVFS.