Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BB82C4332F for ; Wed, 12 Oct 2022 08:58:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F2AE084E47; Wed, 12 Oct 2022 10:58:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="g2G2wATE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 094D784E49; Wed, 12 Oct 2022 10:58:43 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2064.outbound.protection.outlook.com [40.107.237.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CB95B84E29 for ; Wed, 12 Oct 2022 10:58:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N/CU7/8Qbye5gCAz7RpbU8IjbQGhm8Y/ZgbN6uKjK+65O9YAvvNtlX8XBlg0Kt3zUx+oC6CgI+NVBXO6HrMYbH2zgizSWkDNkk7dmRMoQraTsKC4R3MaGmnWirNK9Mj+G2uybuNchaMNNQOBJRDndgfHThIAEG16iSkLjVdTcpmGETPOiEvxTjmApjGGrCmHGjOVGfCd9JdLm70NC/mRVVX6TyDr3KoH5Q/wzXaxxaJVx04yHeHLAT3B7fivqtAeVo+1scS44exEwhYYRUAREghh3r4eM3OsBqijyNwSrJiY4ZuQUyElqKbIMi43lAS72artaaS0ILX1eIKYMMKt7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DK3bj93spDSB6cH8Ikk3DGeWlTX0+2HYagJBSd/O47Q=; b=ELLgLqjPvcLpllNadsWZIVms46OIu0FLxuj+EckOadXiremTLMvxjQRNXaKe/SrsSBWOoLhHsCm05+BNXBJDfNXDFJ98mOMlA5If+elgNOx/NPVfMJV22L1UgmTeOuLiYqDrKUgUhCgeS9Zv2AEL4LB2q+/oQjCKaGxwD7iM1ZcfoTTtQ1w8fI9Ll1OtI/NqKetMvqGnCH+kqlsF+Ubsz0Zj8PK8HA+IzMDDlyRg0vdsZaDq7svJS/mp4+WGXJBnMIi1e+Wtrt03ivrOnoqr+eb7x4zKl9MWPGC7J4UhvB26wRYUgFK1ofnLRn9jeYHleeVMQirrGECAGJvx3cLcYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DK3bj93spDSB6cH8Ikk3DGeWlTX0+2HYagJBSd/O47Q=; b=g2G2wATE5E9/UMfYFHpnCIYqO+layfsbZUPzOlhd7g/pjPVt324gTJ0tJNzE9D0hCEVlxr5NzXv7Gla22AG4RanqqTZJlIBB1eWGdzNEbO/fYHeyIENB88f7XtE96YIxYr/myeMxNhDD6OQWD122pWDDroJYrB10crC8Zu6oP6g= Received: from DM6PR11CA0065.namprd11.prod.outlook.com (2603:10b6:5:14c::42) by PH8PR12MB6676.namprd12.prod.outlook.com (2603:10b6:510:1c3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct 2022 08:58:36 +0000 Received: from DM6NAM11FT097.eop-nam11.prod.protection.outlook.com (2603:10b6:5:14c:cafe::6b) by DM6PR11CA0065.outlook.office365.com (2603:10b6:5:14c::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24 via Frontend Transport; Wed, 12 Oct 2022 08:58:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT097.mail.protection.outlook.com (10.13.172.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5723.20 via Frontend Transport; Wed, 12 Oct 2022 08:58:35 +0000 Received: from [10.254.241.52] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 12 Oct 2022 03:58:34 -0500 Message-ID: <0a5f9287-6470-3fe1-899c-dfedbe9f1dc4@amd.com> Date: Wed, 12 Oct 2022 10:58:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH 3/3] timer: xilinx-timer: use timer_conv_64() to fix timer wrap around Content-Language: en-US To: Ovidiu Panait , References: <20221012053656.1492457-1-ovpanait@gmail.com> <20221012053656.1492457-3-ovpanait@gmail.com> From: Michal Simek In-Reply-To: <20221012053656.1492457-3-ovpanait@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT097:EE_|PH8PR12MB6676:EE_ X-MS-Office365-Filtering-Correlation-Id: c59fbbad-c9ce-49a7-1118-08daac2ff27f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qlld1vCGwxlhKrkFSM8+y5OXlLOETFM8sMAx+3IQgU9cJj65+YKad0PpxuMMl7UFyIPFcj8bIAkuz8bc60FX0y3S9mBN8aNvimSYKpUFr3FBhVKEIfFk5x1POz4bUnnIgDSXYq3T6lhGthNTPgufBnNUc/DYRqP48qf/B8l8CVe5LhKafqzq8+oBKSlZ0BtGwMdmgw8NXwMHJIGx1rL07LkTHClcDOJQgWdYCyUnKxrIU2ltCfIMMEUdvzsHdmUpBHMzz/jyRq2KvitF1Eymf5l9lmZH72HyUwGsOYdaA7e1wOF6I3CgP+AfpEEcRIYXPll9haQgw+az205WEzo7zhgQzNC8wrV/P6Z3oShxSPbyld1dlI85H4YX4MzI5a2m31PwSs8cZCb1A07pnqPJlW75TXruWZiPIoa+CvScnVlqHsucO58O2tpK8IWqWhyCfOhk9LT7ysFK5yhyJ8elaYXG9U2haZYOW4RD9EwPDMqkYmJzKFOLCwt91+odpTzC+B92B7y1RD/O2MmaDJejZObLPxfysEATvkvgI98ZI03x+aInrxV/0RvPimOYzZL8VzQPF45p+thXvOmzI7CJpqJyQKl/58xCuJ+w2Wc1M4b+h8LJZ9gClGq83Ygi0X3FOojGNw50HQ9RzOlS4mtgC2KW8H2g0YoOlEBQd5Rp4XOsTlanCWtKsgtc31rGpqtGQIzQIKMivad/uJt9T1XFIUhovTDZ480B/zL6QnV3idFvD8ZxShIYJAeLp/EjTieXKV67469OqyazC2c4TUgjpZ8oaLkiggd/zZ3vzNGHarrWQYkeMgXXAzkoPSUzPUFGaHwdPD2ENfIdkzhmjU4sLQ== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(396003)(136003)(39860400002)(346002)(376002)(451199015)(36840700001)(40470700004)(46966006)(44832011)(40480700001)(6666004)(8676002)(70206006)(70586007)(40460700003)(82740400003)(36860700001)(356005)(82310400005)(36756003)(5660300002)(81166007)(186003)(16526019)(336012)(2906002)(2616005)(53546011)(426003)(83380400001)(47076005)(41300700001)(8936002)(26005)(31686004)(478600001)(16576012)(316002)(110136005)(86362001)(31696002)(36900700001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 08:58:35.7575 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c59fbbad-c9ce-49a7-1118-08daac2ff27f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT097.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6676 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 10/12/22 07:36, Ovidiu Panait wrote: > Current xilinx_timer_get_count() implementation does not take into account > the periodic 32-bit wrap arounds, as it directly returns the 32-bit counter > register value. The roll-overs cause problems in the upper timer layers, as > generic timer code expects an incrementing 64-bit value from get_count() to > work correctly. > > Add the missing 64-bit up-conversion to fix random hangs/delays in > __udelay(). > > Fixes: a36d86720f ("microblaze: Convert axi timer to DM driver") > Signed-off-by: Ovidiu Panait > --- > > drivers/timer/xilinx-timer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/timer/xilinx-timer.c b/drivers/timer/xilinx-timer.c > index 75b4473b63..172fd9f929 100644 > --- a/drivers/timer/xilinx-timer.c > +++ b/drivers/timer/xilinx-timer.c > @@ -40,7 +40,7 @@ static u64 xilinx_timer_get_count(struct udevice *dev) > > regmap_read(priv->regs, TIMER_COUNTER_OFFSET, &value); > > - return value; > + return timer_conv_64(value); > } > > static int xilinx_timer_probe(struct udevice *dev) Good catch. Reviewed-by: Michal Simek I will let Simon to comment other two patches. Thanks, Michal