From: "flichtenheld (Code Review)" Date: Fri, 6 Mar 2026 13:59:13 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <0a94626a14e1e919dbd01500f1a336a28dde3349-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="1yIQZqElFBg="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Try to emphasise the transition from old ovpn-dco to new ovpn module List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --1yIQZqElFBg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerr= it.openvpn.net/c/openvpn/+/1550?usp=3Demail ) Change subject: Try to emphasise the transition from old ovpn-dco to new ov= pn module ...................................................................... Patch Set 2: Code-Review-1 (2 comments) File src/openvpn/dco.c: http://gerrit.openvpn.net/c/openvpn/+/1550/comment/3d39cde6_b84c1d54?usp=3D= email : PS2, Line 381: msg(msglevel, "Interface %s exists and its not u= sing " "its not using" -> "it's not using the" or "it doesn't use the" File src/openvpn/dco_linux.c: http://gerrit.openvpn.net/c/openvpn/+/1550/comment/b3f4cb99_801a0e11?usp=3D= email : PS2, Line 1244: "ovpn-backports to enable data channe= l offload."); Replace redundant "data channel offload" with "enable it"? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1550?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iff9f6811fdf553f59f2afee0072d7bf90133d328 Gerrit-Change-Number: 1550 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Fri, 06 Mar 2026 13:59:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes --1yIQZqElFBg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

Patch set 2:Code-Review -1=

V= iew Change

2 comments:

  • File src/openvpn/dco.c:

  • Patch Set #2= , Line 381: = msg(msglevel, "Interface %s exists and its not using "

    File src/openvpn/dco_linux.c:

    • Patch Set #2, Line 1244: "ovpn-b= ackports to enable data channel offload.");

      Replace redunda= nt "data channel offload" with "enable it"?

    To view, visit change 1550. To unsubscribe, or for help writing = mail filters, visit settings.

    =
    Gerrit-MessageType: comment
    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: Iff9f6811fdf553f59f2afee0072= d7bf90133d328
    Gerrit-Change-Number: 1550
    Gerrit-PatchSet: 2
    Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Comment-Date: Fri, 06 Mar 2026 13:59:13= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    = --1yIQZqElFBg=--