From: "flichtenheld (Code Review)" Date: Fri, 16 Jan 2026 14:05:59 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, gert@...1296... Message-ID: <0ab0b89b8a02a7ebff7f4dff69110f955d2dbf44-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="qZG4TE8QPMI="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: port-share: Check return value of fork() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , openvpn-devel --qZG4TE8QPMI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change by flichtenheld. ( http://g= errit.openvpn.net/c/openvpn/+/1470?usp=3Demail ) Change subject: port-share: Check return value of fork() ...................................................................... Patch Set 2: (1 comment) File src/openvpn/ps.c: http://gerrit.openvpn.net/c/openvpn/+/1470/comment/f8106373_61c2191a?usp=3D= email : PS1, Line 814: { > why this extra bracket level? To ensure scoping for "status"? Not sure = I find this a good change.. [=E2=80=A6] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1470?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I5eac1b31ae40eb957e2c12ca6c37b491fef32847 Gerrit-Change-Number: 1470 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Comment-Date: Fri, 16 Jan 2026 14:05:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 --qZG4TE8QPMI= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: cron2, plaisthos.

View = Change

1 comment:

    =
  • File src/openvpn/ps.c:

    • Patch Set #1, Line= 814: {

      <= p>
      why this extra bracket level? To ensure scoping for "statu= s"? Not sure I find this a good change.. [=E2=80=A6]

      =

      Done

To view, visit change 1470. To unsubscribe, or = for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I5eac1b31ae40eb957e2c12ca6c3= 7b491fef32847
Gerrit-Change-Number: 1470
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Comment-Date: Fri, 16 Jan 2026 14:05:59= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...= >
= --qZG4TE8QPMI=--