Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10BE3C433EF for ; Wed, 15 Dec 2021 16:48:02 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 222A58316B; Wed, 15 Dec 2021 17:48:01 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="UgxMdQKT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1977E831E9; Wed, 15 Dec 2021 17:47:59 +0100 (CET) Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2AC2D830FB for ; Wed, 15 Dec 2021 17:47:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qt1-x836.google.com with SMTP id m25so22373433qtq.13 for ; Wed, 15 Dec 2021 08:47:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vniVuD48TPEfWcMr7ixZKhs1zWUyBK6fxfHZOPMmVh8=; b=UgxMdQKTNcAMtdjfZBFxVp8uJUyimjZGrLChKwWqDI80CpM2NaxNN9TzzBrZpSNcit 2r5tGge1gNQ61pPDShdcKUDiaZlLTBxmHZfkLlDhdocAtwXinIUx4C/+3Sg0GLcc8E1j b5N2+Seeke3+OS2ac7u9j4hEGi9U4yK2pqn4N8GCoibsDN2fM/71+a6av38dHA7pNEiq Jhsu4q+ZmpLbK6Dyet4UrYDOe0QtP/tIrCB4qOlhlWEEVRDw0R8DTsGu+cSnzGl9bPwc CLstXrea15X9SZXL84Sh6nrj6h+to/Uo8HE4MO1cg1+PDDWbg6hWd+GqfiCojW5zqpEe gJaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vniVuD48TPEfWcMr7ixZKhs1zWUyBK6fxfHZOPMmVh8=; b=0k4AXxIQ4JFkuOKtmyDIVT9r1onZZmMAjZ0Feu/Fep8ZUw1ZhVB754fLrlFCRF7RIf OVXiBLWCluXQBoNWR7BccZPb0haqjRcF1EG5iNXI+5oU4Kv6diLiFtjDRkDULaoO5hgU 3n6PP9bNORgkX0UoDfbSKwT2EODRajfreE4Hw+WmqBK9gBJm0F2atgR5c5OJgIk5pKo7 wS1nWYvb5epoBs5PX/RIJr5tRcjN1mQfminnZJoN/3RDhTBGHCjFOVOgs6CpZskxUihf KWcmJ6YsUaRbI7Yhp9UzwCK/njToU7etZ5Xj9yO2b5Y8IgF1gzDAk6XErSltCa0xpOjw LQpA== X-Gm-Message-State: AOAM532YdlYIoqw0ExmjJDRH3PIFMS9LfirgmBaSSHKOd+j0A4NnDrgg 1yj8pzgwTv4UtcP7Xdvx5msKnX1PzvQ= X-Google-Smtp-Source: ABdhPJwvzhJ4+dgciJ1XCCgZyWSgqaz2cMTIdD53j1d7dp3ry82lIiqQhcfmMUxLbTIJTosVLETlrA== X-Received: by 2002:ac8:58d2:: with SMTP id u18mr12706887qta.262.1639586871855; Wed, 15 Dec 2021 08:47:51 -0800 (PST) Received: from [192.168.1.201] (pool-108-18-207-184.washdc.fios.verizon.net. [108.18.207.184]) by smtp.googlemail.com with ESMTPSA id q30sm1321478qkj.3.2021.12.15.08.47.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Dec 2021 08:47:51 -0800 (PST) Subject: Re: [PATCH 1/2] clk: cdce9xx: Convert .of_xlate to .request To: Tero Kristo , Tom Rini Cc: u-boot@lists.denx.de, Lukasz Majewski References: <20211201194403.2172991-1-seanga2@gmail.com> <20211201200810.GK1220664@bill-the-cat> <2034c66c-c39b-481a-3e7f-435208cab3ff@gmail.com> <650db70d-5ae9-aaa8-6a51-ad3d0cb4f5ad@kernel.org> From: Sean Anderson Message-ID: <0abdad8f-3cfe-8b84-ad36-659a7d6ba8db@gmail.com> Date: Wed, 15 Dec 2021 11:47:50 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <650db70d-5ae9-aaa8-6a51-ad3d0cb4f5ad@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 12/3/21 3:18 AM, Tero Kristo wrote: > On 01/12/2021 22:10, Sean Anderson wrote: >> On 12/1/21 3:08 PM, Tom Rini wrote: >>> On Wed, Dec 01, 2021 at 02:44:02PM -0500, Sean Anderson wrote: >>> >>>> This xlate function just performs some checking. We can do this in >>>> request() instead and use the default xlate. >>>> >>>> Signed-off-by: Sean Anderson >=20 > Hi Sean, >=20 > Did you compile this? I see... >=20 >>>> --- >>>> >>>> =A0 drivers/clk/clk-cdce9xx.c | 12 +++--------- >>>> =A0 1 file changed, 3 insertions(+), 9 deletions(-) >>>> >>>> diff --git a/drivers/clk/clk-cdce9xx.c b/drivers/clk/clk-cdce9xx.c >>>> index 6634b7b799..c15e9f210e 100644 >>>> --- a/drivers/clk/clk-cdce9xx.c >>>> +++ b/drivers/clk/clk-cdce9xx.c >>>> @@ -86,19 +86,13 @@ static int cdce9xx_reg_write(struct udevice *dev= , u8 addr, u8 val) >>>> =A0=A0=A0=A0=A0 return ret; >>>> =A0 } >>>> -static int cdce9xx_clk_of_xlate(struct clk *clk, >>>> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 struct ofnode_phandle= _args *args) >>>> +static int cdce9xx_clk_of_request(struct clk *clk) >=20 > cdce9xx_clk_of_request here... >=20 >>>> =A0 { >>>> =A0=A0=A0=A0=A0 struct cdce9xx_clk_data *data =3D dev_get_priv(clk->= dev); >>>> -=A0=A0=A0 if (args->args_count !=3D 1) >>>> +=A0=A0=A0 if (clk->id > data->chip->num_outputs) >>>> =A0=A0=A0=A0=A0=A0=A0=A0=A0 return -EINVAL; >>>> -=A0=A0=A0 if (args->args[0] > data->chip->num_outputs) >>>> -=A0=A0=A0=A0=A0=A0=A0 return -EINVAL; >>>> - >>>> -=A0=A0=A0 clk->id =3D args->args[0]; >>>> - >>>> =A0=A0=A0=A0=A0 return 0; >>>> =A0 } >>>> @@ -241,7 +235,7 @@ static const struct udevice_id cdce9xx_clk_of_ma= tch[] =3D { >>>> =A0 }; >>>> =A0 static const struct clk_ops cdce9xx_clk_ops =3D { >>>> -=A0=A0=A0 .of_xlate =3D cdce9xx_clk_of_xlate, >>>> +=A0=A0=A0 .request =3D cdce9xx_clk_request, >=20 > but cdce9xx_clk_request here. >=20 > Other than that, looks fine to me. Oops. Thanks for catching that. Resubmitted after compile-testing :) --Sean