From: "cron2 (Code Review)"
Date: Thu, 9 Jan 2025 08:38:17 +0000
In-Reply-To:
References:
Reply-To: gert@...1296..., arne-openvpn@...1227...,
gianmarco@...2726..., openvpn-devel@lists.sourceforge.net,
frank@...2641..., a@...2181...
Message-ID: <0b5cf67b7a0353743de5154f973a7b4080d7439b-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="Cji5r37Tuo4="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: allow user to
specify 'local' multiple times in config files
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: its_Giaan
Cc: flichtenheld , plaisthos , openvpn-devel
--Cji5r37Tuo4=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, its_Giaan, ordex, plais=
thos.
cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/436?usp=3Demail )
Change subject: allow user to specify 'local' multiple times in config files
......................................................................
Patch Set 10: -Code-Review
(1 comment)
File src/openvpn/options.h:
http://gerrit.openvpn.net/c/openvpn/+/436/comment/aae7f902_0402e836 :
PS10, Line 105: struct local_list *local_list;
> You're not supposed to have a `local_list[]` member but a `struct local_e=
ntry *`... [=E2=80=A6]
okay, so we discussed this at lenght in IRC. There are other `xxx_list` th=
ings with `array[]` elements (well, `** array`, and dynamic allocations, bu=
t that's an incremental improvelemts). So I withdraw my objection "we don'=
t do this elsewhere", and with the copying around it's easier to always hav=
e the `len` automatic.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/436?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d1c96662c5a8c750d883e3b20adde09529e2764
Gerrit-Change-Number: 436
Gerrit-PatchSet: 10
Gerrit-Owner: ordex
Gerrit-Reviewer: cron2
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: its_Giaan
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: its_Giaan
Gerrit-Attention: flichtenheld
Gerrit-Attention: ordex
Gerrit-Comment-Date: Thu, 09 Jan 2025 08:38:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: cron2
Comment-In-Reply-To: ordex
Gerrit-MessageType: comment
--Cji5r37Tuo4=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, its_Giaan, ordex, p=
laisthos.
Patch set 10:-Code-Review
=
View C=
hange
1 comment:
okay, so we discus=
sed this at lenght in IRC. There are other `xxx_list` things with `array[]=
` elements (well, `** array`, and dynamic allocations, but that's an in=
cremental improvelemts). So I withdraw my objection "we don't do =
this elsewhere", and with the copying around it's easier to always=
have the `len` automatic.
To view, visit change 436. =
To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d1c96662c5a8c750d883e3b20a=
dde09529e2764
Gerrit-Change-Number: 436
Gerrit-PatchSet: 10
Gerrit-Owner: ordex <a@...2181...>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: its_Giaan <gianmarco@...1664...=
26...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: its_Giaan <gianmarco@...1665...=
726...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Attention: ordex <a@...2181...> <=
/div>
Gerrit-Comment-Date: Thu, 09 Jan 2025 08:38:17=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: cron2 <gert@...1296...=
>
Comment-In-Reply-To: ordex <a@...2181...>=
;
Gerrit-MessageType: comment
--Cji5r37Tuo4=--