From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 8/9] drm/amdgpu/sriov:fix memory leak in psp_load_fw Date: Thu, 26 Oct 2017 09:21:26 +0200 Message-ID: <0b60bc14-020b-212c-72f1-4c53b9df82ac@gmail.com> References: <1508923343-24404-1-git-send-email-Monk.Liu@amd.com> <1508923343-24404-9-git-send-email-Monk.Liu@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1508923343-24404-9-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Monk Liu , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QW0gMjUuMTAuMjAxNyB1bSAxMToyMiBzY2hyaWViIE1vbmsgTGl1Ogo+IGZvciBTUi1JT1Ygd2hl biBkb2luZyBncHUgcmVzZXQgdGhpcyByb3V0aW5lIHNob3VsZG4ndCBkbwo+IHJlc291cmNlIGFs bG9jYXRpbmcgb3RoZXJ3aXNlIG1lbW9yeSBsZWFrCgpDYW4ndCBqdWRnZSBpZiB0aGlzIHBhdGNo IGlzIGNvcnJlY3Qgb3Igbm90LCBidXQgZml4aW5nIHRoZSB3aGl0ZXNwYWNlcyAKc2hvdWxkIGJl IGEgc2VwYXJhdGUgcGF0Y2guCgpDaHJpc3RpYW4uCgo+Cj4gQ2hhbmdlLUlkOiBJMjVkYTNhNWI0 NzUxOTZjNzVjN2U2MzlhZGM0MDc1MTc1NDYyNTk2OAo+IFNpZ25lZC1vZmYtYnk6IE1vbmsgTGl1 IDxNb25rLkxpdUBhbWQuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv YW1kZ3B1X3BzcC5jIHwgMjAgKysrKysrKysrKysrLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2Vk LCAxMiBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9wc3AuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV9wc3AuYwo+IGluZGV4IDc2ZjUzMWIuLjIxNTdkNDUgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3BzcC5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3BzcC5jCj4gQEAgLTMzNCwyMyArMzM0LDI2IEBA IHN0YXRpYyBpbnQgcHNwX2xvYWRfZncoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4gICAJ aW50IHJldDsKPiAgIAlzdHJ1Y3QgcHNwX2NvbnRleHQgKnBzcCA9ICZhZGV2LT5wc3A7Cj4gICAK PiArCWlmIChhbWRncHVfc3Jpb3ZfdmYoYWRldikgJiYgYWRldi0+aW5fZ3B1X3Jlc2V0ICE9IDAp Cj4gKwkJZ290byBza2lwX21lbWFsbG9jOwo+ICsKPiAgIAlwc3AtPmNtZCA9IGt6YWxsb2Moc2l6 ZW9mKHN0cnVjdCBwc3BfZ2Z4X2NtZF9yZXNwKSwgR0ZQX0tFUk5FTCk7Cj4gICAJaWYgKCFwc3At PmNtZCkKPiAgIAkJcmV0dXJuIC1FTk9NRU07Cj4gICAKPiAgIAlyZXQgPSBhbWRncHVfYm9fY3Jl YXRlX2tlcm5lbChhZGV2LCBQU1BfMV9NRUcsIFBTUF8xX01FRywKPiAtCQkJCSAgICAgIEFNREdQ VV9HRU1fRE9NQUlOX0dUVCwKPiAtCQkJCSAgICAgICZwc3AtPmZ3X3ByaV9ibywKPiAtCQkJCSAg ICAgICZwc3AtPmZ3X3ByaV9tY19hZGRyLAo+IC0JCQkJICAgICAgJnBzcC0+ZndfcHJpX2J1Zik7 Cj4gKwkJCQkJQU1ER1BVX0dFTV9ET01BSU5fR1RULAo+ICsJCQkJCSZwc3AtPmZ3X3ByaV9ibywK PiArCQkJCQkmcHNwLT5md19wcmlfbWNfYWRkciwKPiArCQkJCQkmcHNwLT5md19wcmlfYnVmKTsK PiAgIAlpZiAocmV0KQo+ICAgCQlnb3RvIGZhaWxlZDsKPiAgIAo+ICAgCXJldCA9IGFtZGdwdV9i b19jcmVhdGVfa2VybmVsKGFkZXYsIFBTUF9GRU5DRV9CVUZGRVJfU0laRSwgUEFHRV9TSVpFLAo+ IC0JCQkJICAgICAgQU1ER1BVX0dFTV9ET01BSU5fVlJBTSwKPiAtCQkJCSAgICAgICZwc3AtPmZl bmNlX2J1Zl9ibywKPiAtCQkJCSAgICAgICZwc3AtPmZlbmNlX2J1Zl9tY19hZGRyLAo+IC0JCQkJ ICAgICAgJnBzcC0+ZmVuY2VfYnVmKTsKPiArCQkJCQlBTURHUFVfR0VNX0RPTUFJTl9WUkFNLAo+ ICsJCQkJCSZwc3AtPmZlbmNlX2J1Zl9ibywKPiArCQkJCQkmcHNwLT5mZW5jZV9idWZfbWNfYWRk ciwKPiArCQkJCQkmcHNwLT5mZW5jZV9idWYpOwo+ICAgCWlmIChyZXQpCj4gICAJCWdvdG8gZmFp bGVkX21lbTI7Cj4gICAKPiBAQCAtMzc1LDYgKzM3OCw3IEBAIHN0YXRpYyBpbnQgcHNwX2xvYWRf Zncoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4gICAJaWYgKHJldCkKPiAgIAkJZ290byBm YWlsZWRfbWVtOwo+ICAgCj4gK3NraXBfbWVtYWxsb2M6Cj4gICAJcmV0ID0gcHNwX2h3X3N0YXJ0 KHBzcCk7Cj4gICAJaWYgKHJldCkKPiAgIAkJZ290byBmYWlsZWRfbWVtOwoKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0 CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=