From: "flichtenheld (Code Review)" Date: Thu, 13 Jun 2024 13:47:05 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., rein.vanbaaren@...1435..., openvpn-devel@lists.sourceforge.net, max@...2606... Message-ID: <0b7b7332da1d8158688125edc7fe164a0a1562a4-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="xYkcssA3md4="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Fix MBEDTLS_DEPRECATED_REMOVED build errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: comododragon , MaxF Cc: plaisthos , openvpn-devel --xYkcssA3md4= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: MaxF, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/681?usp=3Demail ) Change subject: Fix MBEDTLS_DEPRECATED_REMOVED build errors ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: Generally looks sensible. But I would vote for splitting up the TLS version= check and the other changes. Feels like that would make each change cleare= r. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/681?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: If96c2ebd2af16b18ed34820e8c0531547e2076d9 Gerrit-Change-Number: 681 Gerrit-PatchSet: 1 Gerrit-Owner: MaxF Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: comododragon Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: MaxF Gerrit-Comment-Date: Thu, 13 Jun 2024 13:47:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --xYkcssA3md4= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: MaxF, plaisthos.

Patch set 1:Code-Review -1=

Vi= ew Change

1 comment:

  • Patchset:

    • Patch Set #1:

      Generally looks sensible. But I would vote for= splitting up the TLS version check and the other changes. Feels like that = would make each change clearer.

To view, visit change 681<= /a>. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If96c2ebd2af16b18ed34820e8c0= 531547e2076d9
Gerrit-Change-Number: 681
Gerrit-PatchSet: 1
Gerrit-Owner: MaxF <max@...2606...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: comododragon <rein.vanbaaren@...493...= 1435...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: MaxF <max@...2606...> =
Gerrit-Comment-Date: Thu, 13 Jun 2024 13:47:05= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--xYkcssA3md4=--