From: "ordex (Code Review)" Date: Mon, 25 Nov 2024 14:37:46 +0000 References: Reply-To: a@...2181..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <0ba3c0296fe0e52ef01cd4a63d4ea8db344d59b3-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="w3Q4MMjxmKM="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: man: extend --persist-tun section List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos , flichtenheld Cc: openvpn-devel --w3Q4MMjxmKM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/819?usp=3Demail to review the following change. Change subject: man: extend --persist-tun section ...................................................................... man: extend --persist-tun section The current persist-tun section has no mention of retaining IP/routes and its potential usage in traffic leaking protection. Spell this out to allow the user to better understand when this option can play an important role. Change-Id: I6816f61b308ca9f6d1f9f687a6dc8e0aa2d044e0 Signed-off-by: Antonio Quartulli --- M doc/man-sections/vpn-network-options.rst 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/19/819/1 diff --git a/doc/man-sections/vpn-network-options.rst b/doc/man-sections/vp= n-network-options.rst index fc76939..cfa6af9 100644 --- a/doc/man-sections/vpn-network-options.rst +++ b/doc/man-sections/vpn-network-options.rst @@ -312,6 +312,15 @@ :code:`SIGUSR1` is a restart signal similar to :code:`SIGHUP`, but which offers finer-grained control over reset options. + On Linux, this option can be useful when OpenVPN is not executed as + root and the CAP_NET_ADMIN has not been granted, because the process + would otherwise not be allowed to bring the interface down and back up. + + Alongside the above, using ``--persist-tun`` allows the tunnel interface + to retain all IP/route settings, thus allowing the user to implement + any advanced traffic leaking protection (please ntoe that for full + protection, extra route/firewall rules must be in place). + --redirect-gateway flags Automatically execute routing commands to cause all outgoing IP traffic to be redirected over the VPN. This is a client-side option. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/819?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6816f61b308ca9f6d1f9f687a6dc8e0aa2d044e0 Gerrit-Change-Number: 819 Gerrit-PatchSet: 1 Gerrit-Owner: ordex Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-MessageType: newchange --w3Q4MMjxmKM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

ordex would like plaisthos and flichtenheld to review t= his change.

Vi= ew Change

man: extend --persist-tun section

The current persist-= tun section has no mention of
retaining IP/routes and its potential usag= e in traffic
leaking protection.

Spell this out to allow the user= to better understand
when this option can play an important role.
Change-Id: I6816f61b308ca9f6d1f9f687a6dc8e0aa2d044e0
Signed-off-by: An= tonio Quartulli <antonio@...2726...>
---
M doc/man-sections/vpn= -network-options.rst
1 file changed, 9 insertions(+), 0 deletions(-)
=
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/19/819/=
1
diff --git a/doc/man-sections/vpn-network-options.rst b/doc/man-s=
ections/vpn-network-options.rst
index fc76939..cfa6af9 1006= 44
--- a/doc/man-sections/vpn-network-options.rst+++ b/doc/man-sections/vpn-network-options.rst
@@ -3= 12,6 +312,15 @@
:code:`SIGUSR1` is a restart signal simi= lar to :code:`SIGHUP`, but which
offers finer-grained co= ntrol over reset options.

+ On Linux, this option can be useful when OpenVPN = is not executed as
+ = root and the CAP_NET_ADMIN has not been granted, because the process
+ would otherwise not be = allowed to bring the interface down and back up.
+
+ Alongside the above, using ``--persist-tun`` allows the tunnel = interface
+ to retai= n all IP/route settings, thus allowing the user to implement
+ any advanced traffic leaking pro= tection (please ntoe that for full

+ protection, extra route/firewall rules must be in place).<= /span>
+
--= redirect-gateway flags
Automatically execute routing com= mands to cause all outgoing IP traffic
to be redirected = over the VPN. This is a client-side option.

To view, visit change 819. To unsubscribe, or for help writing mail filters= , visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6816f61b308ca9f6d1f9f687a6d= c8e0aa2d044e0
Gerrit-Change-Number: 819
Gerrit-PatchSet: 1
Gerrit-Owner: ordex <a@...2181...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-MessageType: newchange
--w3Q4MMjxmKM=--