From: Chaitanya Kulkarni Date: Fri, 15 Apr 2022 05:47:45 +0000 Subject: [Cluster-devel] [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD In-Reply-To: <20220415045258.199825-25-hch@lst.de> References: <20220415045258.199825-1-hch@lst.de> <20220415045258.199825-25-hch@lst.de> Message-ID: <0bf7bda0-0c19-7186-8492-ad894456d98d@nvidia.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 4/14/22 21:52, Christoph Hellwig wrote: > Just use a non-zero max_discard_sectors as an indicator for discard > support, similar to what is done for write zeroes. > > The only places where needs special attention is the RAID5 driver, > which must clear discard support for security reasons by default, > even if the default stacking rules would allow for it. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Martin K. Petersen > Acked-by: Christoph B?hmwalder [drbd] > Acked-by: Jan H?ppner [s390] > Acked-by: Coly Li [bcache] > Acked-by: David Sterba [btrfs] > --- Looks good. Reviewed-by: Chaitanya Kulkarni -ck