From: Ramalingam C Subject: Re: [PATCH v2 8/8] drm/i915: Deduplicate the code to fill the aux message header Date: Fri, 23 Feb 2018 16:49:00 +0530 Message-ID: <0c22f1e4-7a15-71fe-5dbc-8a3c133658cb@intel.com> References: <20180222181036.15251-8-ville.syrjala@linux.intel.com> <20180222212802.4826-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 189936F0BA for ; Fri, 23 Feb 2018 11:24:55 +0000 (UTC) In-Reply-To: <20180222212802.4826-1-ville.syrjala@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org V2l0aCBtaW5vciBzdWdnZXN0aW9uczoKClJldmlld2VkLWJ5OiBSYW1hbGluZ2FtIEMgPHJhbWFs aW5nYW0uY0BpbnRlbC5jb20+CgoKT24gRnJpZGF5IDIzIEZlYnJ1YXJ5IDIwMTggMDI6NTggQU0s IFZpbGxlIFN5cmphbGEgd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPgo+IFdlIGhhdmUgdHdvIGluc3RhbmNlcyBvZiB0aGUgY29k ZSB0byBmaWxsIG91dCB0aGUgaGVhZGVyIGZvciB0aGUgYXV4Cj4gbWVzc2FnZS4gUHVsbCBpdCBp bnRvIGEgc21hbGwgaGVscGVyLgo+Cj4gdjI6IFJlYmFzZSBkdWUgdG8gdHhidWZbXSBjaGFuZ2Vz Cj4KPiBDYzogU2VhbiBQYXVsIDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+Cj4gQ2M6IFJhbWFsaW5n YW0gQyA8cmFtYWxpbmdhbS5jQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJq w6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHAuYyB8IDMyICsrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0t LS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0p Cj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBpbmRleCAwZDY5OWQyMzBiNzcuLmUwNGFhYTE4 MmQ0YyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IEBAIC0xMjQwLDYgKzEyNDAsMTcg QEAgaW50ZWxfZHBfYXV4X3hmZXIoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPiAgIAo+ICAg I2RlZmluZSBCQVJFX0FERFJFU1NfU0laRQkzCj4gICAjZGVmaW5lIEhFQURFUl9TSVpFCQkoQkFS RV9BRERSRVNTX1NJWkUgKyAxKQo+ICsKPiArc3RhdGljIHZvaWQKPiAraW50ZWxfZHBfYXV4X2hl YWRlcih1OCB0eGJ1ZltIRUFERVJfU0laRV0sCj4gKwkJICAgIGNvbnN0IHN0cnVjdCBkcm1fZHBf YXV4X21zZyAqbXNnKQo+ICt7Cj4gKwl0eGJ1ZlswXSA9IChtc2ctPnJlcXVlc3QgPDwgNCkgfCAo KG1zZy0+YWRkcmVzcyA+PiAxNikgJiAweGYpOwo+ICsJdHhidWZbMV0gPSAobXNnLT5hZGRyZXNz ID4+IDgpICYgMHhmZjsKPiArCXR4YnVmWzJdID0gbXNnLT5hZGRyZXNzICYgMHhmZjsKPiArCXR4 YnVmWzNdID0gbXNnLT5zaXplIC0gMTsKPiArfQo+ICsKPiAgIHN0YXRpYyBzc2l6ZV90Cj4gICBp bnRlbF9kcF9hdXhfdHJhbnNmZXIoc3RydWN0IGRybV9kcF9hdXggKmF1eCwgc3RydWN0IGRybV9k cF9hdXhfbXNnICptc2cpCj4gICB7Cj4gQEAgLTEyNDgsMTEgKzEyNTksNyBAQCBpbnRlbF9kcF9h dXhfdHJhbnNmZXIoc3RydWN0IGRybV9kcF9hdXggKmF1eCwgc3RydWN0IGRybV9kcF9hdXhfbXNn ICptc2cpCj4gICAJc2l6ZV90IHR4c2l6ZSwgcnhzaXplOwo+ICAgCWludCByZXQ7Cj4gICAKPiAt CXR4YnVmWzBdID0gKG1zZy0+cmVxdWVzdCA8PCA0KSB8Cj4gLQkJKChtc2ctPmFkZHJlc3MgPj4g MTYpICYgMHhmKTsKPiAtCXR4YnVmWzFdID0gKG1zZy0+YWRkcmVzcyA+PiA4KSAmIDB4ZmY7Cj4g LQl0eGJ1ZlsyXSA9IG1zZy0+YWRkcmVzcyAmIDB4ZmY7Cj4gLQl0eGJ1ZlszXSA9IG1zZy0+c2l6 ZSAtIDE7Cj4gKwlpbnRlbF9kcF9hdXhfaGVhZGVyKHR4YnVmLCBtc2cpOwo+ICAgCj4gICAJc3dp dGNoIChtc2ctPnJlcXVlc3QgJiB+RFBfQVVYX0kyQ19NT1QpIHsKPiAgIAljYXNlIERQX0FVWF9O QVRJVkVfV1JJVEU6Cj4gQEAgLTUwNjgsNyArNTA3NSwxMiBAQCBpbnQgaW50ZWxfZHBfaGRjcF93 cml0ZV9hbl9ha3N2KHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0LAo+ ICAgCQkJCXU4ICphbikKPiAgIHsKPiAgIAlzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwID0gZW5j X3RvX2ludGVsX2RwKCZpbnRlbF9kaWdfcG9ydC0+YmFzZS5iYXNlKTsKPiAtCXVpbnQ4X3QgdHhi dWZbNCs1XSA9IHt9LCByeGJ1ZlsyXSwgcmVwbHkgPSAwOwo+ICsJc3RhdGljIGNvbnN0IHN0cnVj dCBkcm1fZHBfYXV4X21zZyBtc2cgPSB7Cj4gKwkJLnJlcXVlc3QgPSBEUF9BVVhfTkFUSVZFX1dS SVRFLAo+ICsJCS5hZGRyZXNzID0gRFBfQVVYX0hEQ1BfQUtTViwKPiArCQkuc2l6ZSA9IERSTV9I RENQX0tTVl9MRU4sCj4gKwl9Owo+ICsJdWludDhfdCB0eGJ1ZltIRUFERVJfU0laRSArIERSTV9I RENQX0tTVl9MRU5dID0ge30sIHJ4YnVmWzJdLCByZXBseSA9IDA7ClJlcGxhY2luZyBudW1iZXJz IHdpdGggbWFjcm9zIGNvdWxkIGJlIG1vdmVkIHRvIHRoZSBwcmV2aW91cyBwYXRjaCBvZiAKdGhl IHNlcmllcy4KPiAgIAlzc2l6ZV90IGRwY2RfcmV0Owo+ICAgCWludCByZXQ7Cj4gICAKPiBAQCAt NTA4NiwxMyArNTA5OCw5IEBAIGludCBpbnRlbF9kcF9oZGNwX3dyaXRlX2FuX2Frc3Yoc3RydWN0 IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQsCj4gICAJICogd2Ugd2VyZSB3cml0 aW5nIHRoZSBkYXRhLCBhbmQgdGhlbiB0aWNrbGUgdGhlIGhhcmR3YXJlIHRvIG91dHB1dCB0aGUK PiAgIAkgKiBkYXRhIG9uY2UgdGhlIGhlYWRlciBpcyBzZW50IG91dC4KPiAgIAkgKi8KPiAtCXR4 YnVmWzBdID0gKERQX0FVWF9OQVRJVkVfV1JJVEUgPDwgNCkgfAo+IC0JCSAgICgoRFBfQVVYX0hE Q1BfQUtTViA+PiAxNikgJiAweGYpOwo+IC0JdHhidWZbMV0gPSAoRFBfQVVYX0hEQ1BfQUtTViA+ PiA4KSAmIDB4ZmY7Cj4gLQl0eGJ1ZlsyXSA9IERQX0FVWF9IRENQX0FLU1YgJiAweGZmOwo+IC0J dHhidWZbM10gPSBEUk1fSERDUF9LU1ZfTEVOIC0gMTsKPiArCWludGVsX2RwX2F1eF9oZWFkZXIo dHhidWYsICZtc2cpOwo+ICAgCj4gLQlyZXQgPSBpbnRlbF9kcF9hdXhfeGZlcihpbnRlbF9kcCwg dHhidWYsIHNpemVvZih0eGJ1ZiksCj4gKwlyZXQgPSBpbnRlbF9kcF9hdXhfeGZlcihpbnRlbF9k cCwgdHhidWYsIEhFQURFUl9TSVpFICsgbXNnLnNpemUsCldlIGNvdWxkIHVzZSB0aGUgSEVBREVS X1NJWkUgKyBEUk1fSERDUF9LU1ZfTEVOIGl0c2VsZiBmb3IgdHhidWYgc2l6ZSwgCmFzIHRoZXkg YXJlIGNvbnN0IGFueXdheS4KdGhpcyBhbHNvIGNvdWxkIGJlIG1vdmVkIHRvIHRoZSBwcmV2IHBh dGNoLCBzbyB0aGF0IHRoaXMgcGF0Y2gganVzdCBhZGRzIAphIGhlbHBlciBmb3IgZmlsbGluZyB0 aGUgYXV4IGhlYWRlci4KCi0tUmFtCj4gICAJCQkJcnhidWYsIHNpemVvZihyeGJ1ZiksCj4gICAJ CQkJRFBfQVVYX0NIX0NUTF9BVVhfQUtTVl9TRUxFQ1QpOwo+ICAgCWlmIChyZXQgPCAwKSB7Cgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK