Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B958C4361B for ; Fri, 18 Dec 2020 12:41:41 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 719ED23A51 for ; Fri, 18 Dec 2020 12:41:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 719ED23A51 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.56492.98924 (Exim 4.92) (envelope-from ) id 1kqF4P-0001wD-0N; Fri, 18 Dec 2020 12:41:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 56492.98924; Fri, 18 Dec 2020 12:41:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kqF4O-0001w6-RM; Fri, 18 Dec 2020 12:41:16 +0000 Received: by outflank-mailman (input) for mailman id 56492; Fri, 18 Dec 2020 12:41:15 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kqF4N-0001vv-Pr for xen-devel@lists.xenproject.org; Fri, 18 Dec 2020 12:41:15 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4c6490b6-0851-443f-89aa-33c4005152c2; Fri, 18 Dec 2020 12:41:13 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B80C6AD89; Fri, 18 Dec 2020 12:41:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c6490b6-0851-443f-89aa-33c4005152c2 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1608295272; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y2ihX0PvA7fC2DjVZO8xpyjmANxUEIa7YFWs0+uPrHs=; b=Dv/yVlTZd0NMmKqDJRI3fT+6UEYgqG2AOKWbS1d8yDi/uY9SDoZJuXmMfEKb4G/NNZ3p0z NW/Q7GkN34pKGKI5AaEQgTuTRfvfsIImH53D4+QwCs7tSoKZfOi8XtxFhTI3PmhBfDYRRX /l3HZUq23fuZyY1gbrOJEN2kZAsgL7w= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20201209160956.32456-1-jgross@suse.com> <20201209160956.32456-6-jgross@suse.com> <2894a231-9150-7c09-cc5c-7ef52087acf5@suse.com> <5e0ac85e-ecba-86ad-b350-ff30e3a40a68@suse.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Subject: Re: [PATCH v3 5/8] xen/hypfs: add support for id-based dynamic directories Message-ID: <0c56129d-dcfa-2a52-dc66-221f103e6735@suse.com> Date: Fri, 18 Dec 2020 13:41:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lfvgs851yJHyzgD1RG7xbPwvsOZq0irWY" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lfvgs851yJHyzgD1RG7xbPwvsOZq0irWY Content-Type: multipart/mixed; boundary="3Dn312sRL2sqYbwE71xXNlcz0uRviJzSm"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Message-ID: <0c56129d-dcfa-2a52-dc66-221f103e6735@suse.com> Subject: Re: [PATCH v3 5/8] xen/hypfs: add support for id-based dynamic directories References: <20201209160956.32456-1-jgross@suse.com> <20201209160956.32456-6-jgross@suse.com> <2894a231-9150-7c09-cc5c-7ef52087acf5@suse.com> <5e0ac85e-ecba-86ad-b350-ff30e3a40a68@suse.com> In-Reply-To: --3Dn312sRL2sqYbwE71xXNlcz0uRviJzSm Content-Type: multipart/mixed; boundary="------------5114EE5B5B62E77601244A48" Content-Language: en-US This is a multi-part message in MIME format. --------------5114EE5B5B62E77601244A48 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 18.12.20 10:09, Jan Beulich wrote: > On 18.12.2020 09:57, J=C3=BCrgen Gro=C3=9F wrote: >> On 17.12.20 13:14, Jan Beulich wrote: >>> On 17.12.2020 12:32, J=C3=BCrgen Gro=C3=9F wrote: >>>> On 17.12.20 12:28, Jan Beulich wrote: >>>>> On 09.12.2020 17:09, Juergen Gross wrote: >>>>>> +static const struct hypfs_entry *hypfs_dyndir_enter( >>>>>> + const struct hypfs_entry *entry) >>>>>> +{ >>>>>> + const struct hypfs_dyndir_id *data; >>>>>> + >>>>>> + data =3D hypfs_get_dyndata(); >>>>>> + >>>>>> + /* Use template with original enter function. */ >>>>>> + return data->template->e.funcs->enter(&data->template->e); >>>>>> +} >>>>> >>>>> At the example of this (applies to other uses as well): I realize >>>>> hypfs_get_dyndata() asserts that the pointer is non-NULL, but >>>>> according to the bottom of ./CODING_STYLE this may not be enough >>>>> when considering the implications of a NULL deref in the context >>>>> of a PV guest. Even this living behind a sysctl doesn't really >>>>> help, both because via XSM not fully privileged domains can be >>>>> granted access, and because speculation may still occur all the >>>>> way into here. (I'll send a patch to address the latter aspect in >>>>> a few minutes.) While likely we have numerous existing examples >>>>> with similar problems, I guess in new code we'd better be as >>>>> defensive as possible. >>>> >>>> What do you suggest? BUG_ON()? >>> >>> Well, BUG_ON() would be a step in the right direction, converting >>> privilege escalation to DoS. The question is if we can't do better >>> here, gracefully failing in such a case (the usual pair of >>> ASSERT_UNREACHABLE() plus return/break/goto approach doesn't fit >>> here, at least not directly). >>> >>>> You are aware that this is nothing a user can influence, so it would= >>>> be a clear coding error in the hypervisor? >>> >>> A user (or guest) can't arrange for there to be a NULL pointer, >>> but if there is one that can be run into here, this would still >>> require an XSA afaict. >> >> I still don't see how this could happen without a major coding bug, >> which IMO wouldn't go unnoticed during a really brief test (this is >> the reason for ASSERT() in hypfs_get_dyndata() after all). >=20 > True. Yet the NULL derefs wouldn't go unnoticed either. >=20 >> Its not as if the control flow would allow many different ways to reac= h >> any of the hypfs_get_dyndata() calls. >=20 > I'm not convinced of this - this is a non-static function, and the > call patch 8 adds (just to take an example) is not very obvious to > have a guarantee that allocation did happen and was checked for > success. Yes, in principle cpupool_gran_write() isn't supposed to > be called in such a case, but it's the nature of bugs assumptions > get broken. Yes, but we do have tons of assumptions like that. I don't think we should add tests for non-NULL pointers everywhere just because we happen to dereference something. Where do we stop? >=20 >> I can add security checks at the appropriate places, but I think this >> would be just dead code. OTOH if you are feeling strong here lets go >> with it. >=20 > Going with it isn't the only possible route. The other is to drop > the ASSERT()s altogether. It simply seems to me that their addition > is a half-hearted attempt when considering what was added to > ./CODING_STYLE not all that long ago. No. The ASSERT() is clearly an attempt to catch a programming error early. It is especially not trying to catch a situation which is thought to be possible. The situation should really never happen, and I'm not aware how it could happen without a weird code modification. Dropping the ASSERT() would really add risk to not notice a bug being introduced by a code modification. Juergen --------------5114EE5B5B62E77601244A48 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------5114EE5B5B62E77601244A48-- --3Dn312sRL2sqYbwE71xXNlcz0uRviJzSm-- --lfvgs851yJHyzgD1RG7xbPwvsOZq0irWY Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAl/co2cFAwAAAAAACgkQsN6d1ii/Ey9o Kwf5Ad1f5NVxvrPUObUZtukgzNTBkdWN8pJ5ySpe1p6JUF5mDL4IRDBGYeJYQHpxhV0vUfTraKg0 gKQf8DKFxUtNWH5iRtdMe2YO+AnPbdM16Reqcse2hRIU9xtrjVdlymXJlIyZS/B3JdIsWh0EuE7V TAMNesLO6DyUz7V3Me9bbRiXSi2i5ZscdV2UEsmELUniB4gJ/9VkRq/mLLOOP71XMnmJ8Hx2hipR vhdzaorXDWVw7FAims4Cgl6evNZv5fmx6Ik1wlXTZYmKkKqWGioRBEiKf7ZvPuEfoPqtXrqFOGp1 ZXu/SvD0IbO6HYBKGD6tbRkHZwE2+lMhNIoB6RZf6w== =ez7H -----END PGP SIGNATURE----- --lfvgs851yJHyzgD1RG7xbPwvsOZq0irWY--