Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D780C83F01 for ; Wed, 30 Aug 2023 14:31:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 78E5C846DF; Wed, 30 Aug 2023 16:31:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="yM6Aqsyp"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0C29380702; Wed, 30 Aug 2023 16:31:34 +0200 (CEST) Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 25023863DC for ; Wed, 30 Aug 2023 16:31:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=afd@ti.com Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 37UEVNVd087242; Wed, 30 Aug 2023 09:31:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1693405883; bh=VXWUuQNdvTzK8HYe4btZESP0SiyIIjCNEclH+Ei5yoM=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=yM6AqsypgZu+HDQR7KQO8TKN820ddUPkrhvbmDQUd8ILEZzJnSpHjPeVCVjKw5gH1 wV/b5A+9lns3ftR/08pC9iPU0uF2QeNqIpSo+GuOh1uOMkFItDxkVStbghYAfhxzeO EznWGFLzr0spPsW/dIDO0yw79vXXGpe31T9ilz80= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 37UEVNB3055081 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 30 Aug 2023 09:31:23 -0500 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 30 Aug 2023 09:31:23 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 30 Aug 2023 09:31:23 -0500 Received: from [10.250.38.120] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 37UEVMcU103158; Wed, 30 Aug 2023 09:31:22 -0500 Message-ID: <0cbbf080-491f-a0fc-300c-d32cbd06ba70@ti.com> Date: Wed, 30 Aug 2023 09:31:22 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC PATCH 2/2] configs: Add am62x_beagleplay_* defconfigs To: Nishanth Menon CC: Neha Malcom Francis , Simon Glass , Tom Rini , Bryan Brattlof , Praneeth Bajjuri , Robert Nelson , Vignesh Raghavendra , Mattijs Korpershoek , Jan Kiszka , Heinrich Schuchardt , References: <20230829221457.101469-1-afd@ti.com> <20230829221457.101469-3-afd@ti.com> <20230830123151.rp7wkhi5m4leg6ny@ravishing> Content-Language: en-US From: Andrew Davis In-Reply-To: <20230830123151.rp7wkhi5m4leg6ny@ravishing> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 8/30/23 7:31 AM, Nishanth Menon wrote: > On 17:14-20230829, Andrew Davis wrote: >> Add am62x_beagleplay_r5_defconfig for R5 SPL and >> am62x_beagleplay_a53_defconfig for A53 SPL and U-Boot support. >> >> These defconfigs are composite defconfigs built from the config fragment >> board/ti/am62x/beagleplay_*.config applied onto the base >> am62x_evm_*_defconfig. >> >> Signed-off-by: Andrew Davis >> --- >> configs/am62x_beagleplay_a53_defconfig | 3 +++ >> configs/am62x_beagleplay_r5_defconfig | 3 +++ >> 2 files changed, 6 insertions(+) >> create mode 100644 configs/am62x_beagleplay_a53_defconfig >> create mode 100644 configs/am62x_beagleplay_r5_defconfig >> >> diff --git a/configs/am62x_beagleplay_a53_defconfig b/configs/am62x_beagleplay_a53_defconfig >> new file mode 100644 >> index 00000000000..ad708e15397 >> --- /dev/null >> +++ b/configs/am62x_beagleplay_a53_defconfig >> @@ -0,0 +1,3 @@ >> +// The BeaglePlay defconfig for A53 core >> +#include "configs/am62x_evm_a53_defconfig" >> +#include "board/ti/am62x/beagleplay_a53.config" >> diff --git a/configs/am62x_beagleplay_r5_defconfig b/configs/am62x_beagleplay_r5_defconfig >> new file mode 100644 >> index 00000000000..276b1f81a3e >> --- /dev/null >> +++ b/configs/am62x_beagleplay_r5_defconfig >> @@ -0,0 +1,3 @@ >> +// The BeaglePlay defconfig for R5 core >> +#include "configs/am62x_evm_r5_defconfig" >> +#include "board/ti/am62x/beagleplay_r5.config" >> -- >> 2.39.2 >> > > my only complaint is that if we add lets say > board/ti/am62x/dfu.config, Then: > > R5: > 1. am62x_evm_r5_defconfig = am62x_evm_r5_defconfig > 2. am62x_beagleplay_r5_defconfig = am62x_evm_r5_defconfig + beagleplay_r5.config > 3. am62x_evm_r5_dfu_defconfig = am62x_evm_r5_defconfig + dfu.config > 4. am62x_beagleplay_r5_dfu_defconfig = am62x_evm_r5_defconfig + beagleplay_r5.config + dfu.config > > This information can be in a single txt file Rather than have a > defconfig file for each combination. > Having every combination in a text file vs in a directory of files doesn't seem like much difference to me. `cat combinations.txt` vs `ls -l configs/`. But using a file would mean extra tooling and non-standard usage. Let's simply try to avoid these combinatorial problems by avoiding adding too many fragments that apply broadly. That adds testing burden. When features need added/removed, folks can use menuconfig or similar. We shouldn't need a defconfig fragment for DFU.. Andrew