From: Maarten Lankhorst Subject: Re: [PATCH v2 6/6] drm/i915: Use intel_ddi_get_config() for MST Date: Mon, 30 Oct 2017 10:00:04 +0100 Message-ID: <0cdac759-f180-fe77-497f-642ac929bc17@linux.intel.com> References: <20171027193128.14483-1-ville.syrjala@linux.intel.com> <20171027193128.14483-7-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0BA746E36E for ; Mon, 30 Oct 2017 09:00:06 +0000 (UTC) In-Reply-To: <20171027193128.14483-7-ville.syrjala@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMjctMTAtMTcgb20gMjE6MzEgc2NocmVlZiBWaWxsZSBTeXJqYWxhOgo+IEZyb206IFZpbGxl IFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4KPiBFbGltaW5hdGUg dGhlIHBhcnRpYWxseSBkdXBsaWNhdGVkIERESSByZWFkb3V0IGNvZGUgZnJvbSBNU1QsIGFuZAo+ IGluc3RlYWQganVzdCBjYWxsIGludGVsX2RkaV9nZXRfY29uZmlnKCkuIEFzIGEgbmljZSBib251 cyB3ZSBnZXQKPiBtb3JlIGNyb3NzIGNoZWNraW5nIGFzIGludGVsX2RkaV9nZXRfY29uZmlnKCkg d2lsbCBwb3B1bGF0ZQo+IG91dHB1dF90eXBlcyBiYXNlZCBvbiB0aGUgYWN0dWFsIG1vZGUgb2Yg dGhlIERESSBwb3J0Lgo+Cj4gQWRkaXRvbmFsbHkgaW50ZWxfZGRpX2dldF9jb25maWcoKSBtdXN0 IGJlIGNoYW5nZWQgdG8gZ2V0IHRoZSBjcnRjCj4gZnJvbSB0aGUgcGFzc2VkIGluIGNydGMgc3Rh dGUgcmF0aGVyIHRoYW4gZnJvbSB0aGUgZW5jb2Rlci0+Y3J0YyBsaW5rLgo+IGVuY29kZXItPmNy dGMgcmVhbGx5IHNob3VsZG4ndCBiZSB1c2VkIGFueXdheS4KPgo+IHYyOiBSZWJhc2VkIG9uIEJY VCBNU1QgbGF0ZW5jeV9vcHRpbSBmaXgKPiAgICAgTWFrZSBpbnRlbF9kZGlfY2xvY2tfZ2V0KCkg c3RhdGljCj4KPiBDYzogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4 LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmph bGFAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k ZGkuYyAgICB8ICA2ICsrLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX21zdC5j IHwgNTAgKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcnYuaCAgICB8ICAyIC0tCj4gIDMgZmlsZXMgY2hhbmdlZCwgNCBp bnNlcnRpb25zKCspLCA1NCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kZGkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5j Cj4gaW5kZXggMGY2MDNhMTU3ZGJhLi5jYzNkNTViNWNlYTAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kZGkuYwo+IEBAIC0xNDUzLDggKzE0NTMsOCBAQCBzdGF0aWMgdm9pZCBieHRfZGRpX2Ns b2NrX2dldChzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAgCWRkaV9kb3RjbG9ja19n ZXQocGlwZV9jb25maWcpOwo+ICB9Cj4gIAo+IC12b2lkIGludGVsX2RkaV9jbG9ja19nZXQoc3Ry dWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gLQkJCSBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0 ZSAqcGlwZV9jb25maWcpCj4gK3N0YXRpYyB2b2lkIGludGVsX2RkaV9jbG9ja19nZXQoc3RydWN0 IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gKwkJCQlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAq cGlwZV9jb25maWcpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9 IHRvX2k5MTUoZW5jb2Rlci0+YmFzZS5kZXYpOwo+ICAKPiBAQCAtMjUzMyw3ICsyNTMzLDcgQEAg dm9pZCBpbnRlbF9kZGlfZ2V0X2NvbmZpZyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwK PiAgCQkJICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcpCj4gIHsKPiAgCXN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZW5jb2Rlci0+YmFzZS5k ZXYpOwo+IC0Jc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMgPSB0b19pbnRlbF9jcnRjKGVu Y29kZXItPmJhc2UuY3J0Yyk7Cj4gKwlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YyA9IHRv X2ludGVsX2NydGMocGlwZV9jb25maWctPmJhc2UuY3J0Yyk7Cj4gIAllbnVtIHRyYW5zY29kZXIg Y3B1X3RyYW5zY29kZXIgPSBwaXBlX2NvbmZpZy0+Y3B1X3RyYW5zY29kZXI7Cj4gIAlzdHJ1Y3Qg aW50ZWxfZGlnaXRhbF9wb3J0ICppbnRlbF9kaWdfcG9ydDsKPiAgCXUzMiB0ZW1wLCBmbGFncyA9 IDA7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX21zdC5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbXN0LmMKPiBpbmRleCBkNTIzMzAyZTUwODEu LjZmMTFiYjM1ZjY2ZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cF9tc3QuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX21zdC5jCj4gQEAg LTI4Niw1NiArMjg2LDggQEAgc3RhdGljIHZvaWQgaW50ZWxfZHBfbXN0X2VuY19nZXRfY29uZmln KHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICB7Cj4gIAlzdHJ1Y3QgaW50ZWxfZHBf bXN0X2VuY29kZXIgKmludGVsX21zdCA9IGVuY190b19tc3QoJmVuY29kZXItPmJhc2UpOwo+ICAJ c3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQgPSBpbnRlbF9tc3QtPnBy aW1hcnk7Cj4gLQlzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YyA9IHRvX2ludGVsX2NydGMocGlwZV9j b25maWctPmJhc2UuY3J0Yyk7Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYg PSB0b19pOTE1KGVuY29kZXItPmJhc2UuZGV2KTsKPiAtCWVudW0gdHJhbnNjb2RlciBjcHVfdHJh bnNjb2RlciA9IHBpcGVfY29uZmlnLT5jcHVfdHJhbnNjb2RlcjsKPiAtCXUzMiB0ZW1wLCBmbGFn cyA9IDA7Cj4gIAo+IC0JcGlwZV9jb25maWctPm91dHB1dF90eXBlcyB8PSBCSVQoSU5URUxfT1VU UFVUX0RQX01TVCk7Cj4gLQo+IC0JcGlwZV9jb25maWctPmhhc19hdWRpbyA9Cj4gLQkJaW50ZWxf ZGRpX2lzX2F1ZGlvX2VuYWJsZWQoZGV2X3ByaXYsIGNydGMpOwo+IC0KPiAtCXRlbXAgPSBJOTE1 X1JFQUQoVFJBTlNfRERJX0ZVTkNfQ1RMKGNwdV90cmFuc2NvZGVyKSk7Cj4gLQlpZiAodGVtcCAm IFRSQU5TX0RESV9QSFNZTkMpCj4gLQkJZmxhZ3MgfD0gRFJNX01PREVfRkxBR19QSFNZTkM7Cj4g LQllbHNlCj4gLQkJZmxhZ3MgfD0gRFJNX01PREVfRkxBR19OSFNZTkM7Cj4gLQlpZiAodGVtcCAm IFRSQU5TX0RESV9QVlNZTkMpCj4gLQkJZmxhZ3MgfD0gRFJNX01PREVfRkxBR19QVlNZTkM7Cj4g LQllbHNlCj4gLQkJZmxhZ3MgfD0gRFJNX01PREVfRkxBR19OVlNZTkM7Cj4gLQo+IC0Jc3dpdGNo ICh0ZW1wICYgVFJBTlNfRERJX0JQQ19NQVNLKSB7Cj4gLQljYXNlIFRSQU5TX0RESV9CUENfNjoK PiAtCQlwaXBlX2NvbmZpZy0+cGlwZV9icHAgPSAxODsKPiAtCQlicmVhazsKPiAtCWNhc2UgVFJB TlNfRERJX0JQQ184Ogo+IC0JCXBpcGVfY29uZmlnLT5waXBlX2JwcCA9IDI0Owo+IC0JCWJyZWFr Owo+IC0JY2FzZSBUUkFOU19ERElfQlBDXzEwOgo+IC0JCXBpcGVfY29uZmlnLT5waXBlX2JwcCA9 IDMwOwo+IC0JCWJyZWFrOwo+IC0JY2FzZSBUUkFOU19ERElfQlBDXzEyOgo+IC0JCXBpcGVfY29u ZmlnLT5waXBlX2JwcCA9IDM2Owo+IC0JCWJyZWFrOwo+IC0JZGVmYXVsdDoKPiAtCQlicmVhazsK PiAtCX0KPiAtCXBpcGVfY29uZmlnLT5iYXNlLmFkanVzdGVkX21vZGUuZmxhZ3MgfD0gZmxhZ3M7 Cj4gLQo+IC0JcGlwZV9jb25maWctPmxhbmVfY291bnQgPQo+IC0JCSgodGVtcCAmIERESV9QT1JU X1dJRFRIX01BU0spID4+IERESV9QT1JUX1dJRFRIX1NISUZUKSArIDE7Cj4gLQo+IC0JaW50ZWxf ZHBfZ2V0X21fbihjcnRjLCBwaXBlX2NvbmZpZyk7Cj4gLQo+IC0JaW50ZWxfZGRpX2Nsb2NrX2dl dCgmaW50ZWxfZGlnX3BvcnQtPmJhc2UsIHBpcGVfY29uZmlnKTsKPiAtCj4gLQlpZiAoSVNfR0VO OV9MUChkZXZfcHJpdikpCj4gLQkJcGlwZV9jb25maWctPmxhbmVfbGF0X29wdGltX21hc2sgPQo+ IC0JCQlieHRfZGRpX3BoeV9nZXRfbGFuZV9sYXRfb3B0aW1fbWFzayhlbmNvZGVyKTsKPiAtCj4g LQlpbnRlbF9kZGlfY29tcHV0ZV9taW5fdm9sdGFnZV9sZXZlbChkZXZfcHJpdiwgcGlwZV9jb25m aWcpOwo+ICsJaW50ZWxfZGRpX2dldF9jb25maWcoJmludGVsX2RpZ19wb3J0LT5iYXNlLCBwaXBl X2NvbmZpZyk7Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbnQgaW50ZWxfZHBfbXN0X2dldF9kZGNfbW9k ZXMoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cnYuaAo+IGluZGV4IDM4MjhkOWJlZTdmNS4uNDQ5OGQ3NDNjZWJjIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZHJ2LmgKPiBAQCAtMTI5NSw4ICsxMjk1LDYgQEAgYm9vbCBpbnRlbF9kZGlfaXNf YXVkaW9fZW5hYmxlZChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIHZvaWQg aW50ZWxfZGRpX2dldF9jb25maWcoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAkJ CSAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnKTsKPiAgCj4gLXZvaWQgaW50 ZWxfZGRpX2Nsb2NrX2dldChzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAtCQkJIHN0 cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZyk7Cj4gIHZvaWQgaW50ZWxfZGRpX3Nl dF92Y19wYXlsb2FkX2FsbG9jKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0 YXRlLAo+ICAJCQkJICAgIGJvb2wgc3RhdGUpOwo+ICB2b2lkIGludGVsX2RkaV9jb21wdXRlX21p bl92b2x0YWdlX2xldmVsKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKCkkgc3Rp bGwgZG9uJ3QgbGlrZSBwYXRjaCA1LzYsIGJ1dCBsZXRzIGp1c3Qgc2VlIGlmIGl0IGJyZWFrcyB0 b28gb2Z0ZW4gaW4gdGhlIGZ1dHVyZSwgaWYgc28gd2UgY291bGQgYWx3YXlzIHJldmVydC4uIGZv ciB0aGUgd2hvbGUgc2VyaWVzOgoKUmV2aWV3ZWQtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFy dGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+CgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK