From: "stipa (Code Review)"
Date: Wed, 26 Mar 2025 08:55:03 +0000
In-Reply-To:
References:
Reply-To: lstipakov@...277..., arne-openvpn@...1227..., heiko@...515...,
openvpn-devel@lists.sourceforge.net, frank@...2641...
Message-ID: <0ceb772deedf0110682c8e9221997abdab71eabf-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="pBi1oSjrUaI="; charset=UTF-8
Subject: [Openvpn-devel] [XL] Change in openvpn[master]: win: implement
--dns option support with NRPT
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: d12fk
Cc: flichtenheld , plaisthos , openvpn-devel
--pBi1oSjrUaI=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: d12fk, plaisthos.
stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/837?usp=3Demail )
Change subject: win: implement --dns option support with NRPT
......................................................................
Patch Set 14:
(2 comments)
File src/openvpnserv/interactive.c:
http://gerrit.openvpn.net/c/openvpn/+/837/comment/b879805b_55fa9a7f :
PS14, Line 2259: MsgToEventLog(M_SYSERR, TEXT("IsInterfaceConnected=
: "
> Hm, I do not have adapters I can reproduce this on my system. [=E2=80=A6]
Sure. In my case it is probably Hyper-V virtual adapters.
https://gist.github.com/lstipakov/b30a662ab8001d4a07ddda7406808eb5
Again, I think it is fine just to omit error message in this error case.
http://gerrit.openvpn.net/c/openvpn/+/837/comment/a11626e1_0dcbd6ed :
PS14, Line 2510: for (int i =3D 0; i < _countof(data); ++i)
> Yeah, if no domains or nameservers are defined the adapters are not added=
as exclude data, so there [=E2=80=A6]
But there are: https://usercontent.irccloud-cdn.com/file/eJy2zlR6/image.png
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/837?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I576e74f3276362606e9cbd50bb5adbebaaf209cc
Gerrit-Change-Number: 837
Gerrit-PatchSet: 14
Gerrit-Owner: d12fk
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-Reviewer: stipa
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: d12fk
Gerrit-Comment-Date: Wed, 26 Mar 2025 08:55:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: d12fk
Comment-In-Reply-To: stipa
Gerrit-MessageType: comment
--pBi1oSjrUaI=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: d12fk, plaisthos.