From: "cron2 (Code Review)" Date: Sat, 25 Jan 2025 10:18:36 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <0d29859ec18b79b8487cf6cc27b6bb58f0a912fe-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="Wtd2aHhtOAo="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: tls_crypt_v2_write_client_key_file: Fix missing-field-initializers co... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --Wtd2aHhtOAo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/86= 7?usp=3Demail ) Change subject: tls_crypt_v2_write_client_key_file: Fix missing-field-initi= alizers compiler warning ...................................................................... tls_crypt_v2_write_client_key_file: Fix missing-field-initializers compiler= warning GCC wants us to be more explicit here. Change-Id: Iaaf80c688ddff79ac9472d7237003713637c140b Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Message-Id: <20250125100838.20796-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30= 588.html Signed-off-by: Gert Doering --- M src/openvpn/tls_crypt.c 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/tls_crypt.c b/src/openvpn/tls_crypt.c index 76f06bc..0e5dfee 100644 --- a/src/openvpn/tls_crypt.c +++ b/src/openvpn/tls_crypt.c @@ -692,7 +692,7 @@ struct buffer client_key_pem =3D { 0 }; struct buffer dst =3D alloc_buf_gc(TLS_CRYPT_V2_CLIENT_KEY_LEN + TLS_CRYPT_V2_MAX_WKC_LEN, &gc); - struct key2 client_key =3D { 2 }; + struct key2 client_key =3D { .n =3D 2 }; if (!rand_bytes((void *)client_key.keys, sizeof(client_key.keys))) { -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/867?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iaaf80c688ddff79ac9472d7237003713637c140b Gerrit-Change-Number: 867 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: merged --Wtd2aHhtOAo= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 submitted this change.

View Change

tls_crypt_v2_write_client_key_file: Fix missin=
g-field-initializers compiler warning

GCC wants us to be more explic= it here.

Change-Id: Iaaf80c688ddff79ac9472d7237003713637c140b
Sig= ned-off-by: Frank Lichtenheld <frank@...2641...>
Acked-by: Gert Do= ering <gert@...1296...>
Message-Id: <20250125100838.20796-1-ger= t@...1296...>
URL: https://www.mail-archive.com/openvpn-devel@...1096...= ourceforge.net/msg30588.html
Signed-off-by: Gert Doering <gert@...1826...= 6...>
---
M src/openvpn/tls_crypt.c
1 file changed, 1 insertion= (+), 1 deletion(-)

diff --git a/src/openvpn/tls_crypt.c b/src/openvpn/tls_crypt.cindex 76f06bc..0e5dfee 100644
--- a/src/openvpn/tls_= crypt.c
+++ b/src/openvpn/tls_crypt.c
@@ -6= 92,7 +692,7 @@
struct buffer client_key_pem =3D { 0 };=
struct buffer dst =3D alloc_buf_gc(TLS_CRYPT_V2_CLIEN= T_KEY_LEN
+ TLS_CRYPT= _V2_MAX_WKC_LEN, &gc);
- struct key2 client_key =3D { 2 };
+ struct key2 client_key =3D { .n =3D 2 };<= br>
if (!rand_bytes((void *)client_key.keys, si= zeof(client_key.keys)))
{

<= /pre>

To view, visit change 867. To unsubscribe, or for help writing mail filt= ers, visit settings.

=
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iaaf80c688ddff79ac9472d72370= 03713637c140b
Gerrit-Change-Number: 867
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: merged
--Wtd2aHhtOAo=--