From: Oscar Mateo Subject: Re: [PATCH 1/5] drm/i915/icl: Add reset control register changes Date: Thu, 5 Apr 2018 12:58:51 -0700 Message-ID: <0d4071cd-e60f-9928-a6dc-d6c9b7169ea7@intel.com> References: <20180405140052.10682-1-mika.kuoppala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8966B6E845 for ; Thu, 5 Apr 2018 19:58:52 +0000 (UTC) In-Reply-To: <20180405140052.10682-1-mika.kuoppala@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala , intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org CgpPbiA0LzUvMjAxOCA3OjAwIEFNLCBNaWthIEt1b3BwYWxhIHdyb3RlOgo+IEZyb206IE1pY2hl bCBUaGllcnJ5IDxtaWNoZWwudGhpZXJyeUBpbnRlbC5jb20+Cj4KPiBUaGUgYml0cyB1c2VkIHRv IHJlc2V0IHRoZSBkaWZmZXJlbnQgZW5naW5lcy9kb21haW5zIGhhdmUgY2hhbmdlZCBpbgo+IEdF TjExLCB0aGlzIHBhdGNoIG1hcHMgdGhlIHJlc2V0IGVuZ2luZSBtYXNrIGJpdHMgd2l0aCB0aGUg bmV3IGJpdHMKPiBpbiB0aGUgcmVzZXQgY29udHJvbCByZWdpc3Rlci4KPgo+IHYyOiBVc2Ugc2hp ZnQtbGVmdCBpbnN0ZWFkIG9mIEJJVCBtYWNybyB0byBtYXRjaCB0aGUgZmlsZSBzdHlsZSAoUGF1 bG8pLgo+IHYzOiBSZXVzZSBnZW44X3Jlc2V0X2VuZ2luZXMgKERhbmllbGUpLgo+IHY0OiBEbyBu b3QgY2FsbCBpbnRlbF91bmNvcmVfZm9yY2V3YWtlX3Jlc2V0IGFmdGVyIHJlc2V0LCB3ZSBtYXkg YmUKPiB1c2luZyB0aGUgZm9yY2V3YWtlIHRvIHJlYWQgcHJvdGVjdGVkIHJlZ2lzdGVycyBlbHNl d2hlcmUgYW5kIHRob3NlCj4gcmVzdWx0cyBtYXkgYmUgY2xvYmJlcmVkIGJ5IHRoZSBjb25jdXJy ZW50IGRyb3BwaW5nIG9mIGZvcmNld2FrZS4KPgo+IGJzcGVjOiAxOTIxMgo+IENjOiBPc2NhciBN YXRlbyA8b3NjYXIubWF0ZW9AaW50ZWwuY29tPgo+IENjOiBBbnRvbmlvIEFyZ2Vuemlhbm8gPGFu dG9uaW8uYXJnZW56aWFub0BpbnRlbC5jb20+Cj4gQ2M6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56 YW5vbmlAaW50ZWwuY29tPgo+IENjOiBEYW5pZWxlIENlcmFvbG8gU3B1cmlvIDxkYW5pZWxlLmNl cmFvbG9zcHVyaW9AaW50ZWwuY29tPgo+IEFja2VkLWJ5OiBEYW5pZWxlIENlcmFvbG8gU3B1cmlv IDxkYW5pZWxlLmNlcmFvbG9zcHVyaW9AaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IE1pY2hl bCBUaGllcnJ5IDxtaWNoZWwudGhpZXJyeUBpbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X3JlZy5oICAgICB8IDExICsrKysrKysrCj4gICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF91bmNvcmUuYyB8IDUzICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrLS0KPiAgIDIgZmlsZXMgY2hhbmdlZCwgNjIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlv bnMoLSkKCktub3dpbmcgd2hhdCBJIGtub3cgYWJvdXQgcGF0Y2hlcyB0aGF0IGFyZSBzdGlsbCBp biB0aGUgcGlwZWxpbmUgKHRoYXQgCmp1c3RpZnkgd2h5IHdlIGRvbid0IHJldXNlIGdlbjZfcmVz ZXRfZW5naW5lcyksIHRoaXMgaXM6CgpSZXZpZXdlZC1ieTogT3NjYXIgTWF0ZW8gPG9zY2FyLm1h dGVvQGludGVsLmNvbT4KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf cmVnLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gaW5kZXggMTc2ZGNhNjU1 NGY0Li5iMmEyZDhmYmJjNjggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9yZWcuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiBAQCAtMzAx LDYgKzMwMSwxNyBAQCBzdGF0aWMgaW5saW5lIGJvb2wgaTkxNV9tbWlvX3JlZ192YWxpZChpOTE1 X3JlZ190IHJlZykKPiAgICNkZWZpbmUgIEdFTjZfR1JET01fVkVDUwkJKDEgPDwgNCkKPiAgICNk ZWZpbmUgIEdFTjlfR1JET01fR1VDCQkJKDEgPDwgNSkKPiAgICNkZWZpbmUgIEdFTjhfR1JET01f TUVESUEyCQkoMSA8PCA3KQo+ICsvKiBHRU4xMSBjaGFuZ2VkIGFsbCBiaXQgZGVmcyBleGNlcHQg Zm9yIEZVTEwgJiBSRU5ERVIgKi8KPiArI2RlZmluZSAgR0VOMTFfR1JET01fRlVMTAkJR0VONl9H UkRPTV9GVUxMCj4gKyNkZWZpbmUgIEdFTjExX0dSRE9NX1JFTkRFUgkJR0VONl9HUkRPTV9SRU5E RVIKPiArI2RlZmluZSAgR0VOMTFfR1JET01fQkxUCQkoMSA8PCAyKQo+ICsjZGVmaW5lICBHRU4x MV9HUkRPTV9HVUMJCSgxIDw8IDMpCj4gKyNkZWZpbmUgIEdFTjExX0dSRE9NX01FRElBCQkoMSA8 PCA1KQo+ICsjZGVmaW5lICBHRU4xMV9HUkRPTV9NRURJQTIJCSgxIDw8IDYpCj4gKyNkZWZpbmUg IEdFTjExX0dSRE9NX01FRElBMwkJKDEgPDwgNykKPiArI2RlZmluZSAgR0VOMTFfR1JET01fTUVE SUE0CQkoMSA8PCA4KQo+ICsjZGVmaW5lICBHRU4xMV9HUkRPTV9WRUNTCQkoMSA8PCAxMykKPiAr I2RlZmluZSAgR0VOMTFfR1JET01fVkVDUzIJCSgxIDw8IDE0KQo+ICAgCj4gICAjZGVmaW5lIFJJ TkdfUFBfRElSX0JBU0UoZW5naW5lKQlfTU1JTygoZW5naW5lKS0+bW1pb19iYXNlKzB4MjI4KQo+ ICAgI2RlZmluZSBSSU5HX1BQX0RJUl9CQVNFX1JFQUQoZW5naW5lKQlfTU1JTygoZW5naW5lKS0+ bW1pb19iYXNlKzB4NTE4KQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF91bmNvcmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jCj4gaW5kZXgg ZTc1NDBiYjk3ODZjLi5kNmUyMGYwZjRjMjggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfdW5jb3JlLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91 bmNvcmUuYwo+IEBAIC0xOTA5LDYgKzE5MDksNTAgQEAgc3RhdGljIGludCBnZW42X3Jlc2V0X2Vu Z2luZXMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAgCXJldHVybiBnZW42 X2h3X2RvbWFpbl9yZXNldChkZXZfcHJpdiwgaHdfbWFzayk7Cj4gICB9Cj4gICAKPiArLyoqCj4g KyAqIGdlbjExX3Jlc2V0X2VuZ2luZXMgLSByZXNldCBpbmRpdmlkdWFsIGVuZ2luZXMKPiArICog QGRldl9wcml2OiBpOTE1IGRldmljZQo+ICsgKiBAZW5naW5lX21hc2s6IG1hc2sgb2YgaW50ZWxf cmluZ19mbGFnKCkgZW5naW5lcyBvciBBTExfRU5HSU5FUyBmb3IgZnVsbCByZXNldAo+ICsgKgo+ ICsgKiBUaGlzIGZ1bmN0aW9uIHdpbGwgcmVzZXQgdGhlIGluZGl2aWR1YWwgZW5naW5lcyB0aGF0 IGFyZSBzZXQgaW4gZW5naW5lX21hc2suCj4gKyAqIElmIHlvdSBwcm92aWRlIEFMTF9FTkdJTkVT IGFzIG1hc2ssIGZ1bGwgZ2xvYmFsIGRvbWFpbiByZXNldCB3aWxsIGJlIGlzc3VlZC4KPiArICoK PiArICogTm90ZTogSXQgaXMgcmVzcG9uc2liaWxpdHkgb2YgdGhlIGNhbGxlciB0byBoYW5kbGUg dGhlIGRpZmZlcmVuY2UgYmV0d2Vlbgo+ICsgKiBhc2tpbmcgZnVsbCBkb21haW4gcmVzZXQgdmVy c3VzIHJlc2V0IGZvciBhbGwgYXZhaWxhYmxlIGluZGl2aWR1YWwgZW5naW5lcy4KPiArICoKPiAr ICogUmV0dXJucyAwIG9uIHN1Y2Nlc3MsIG5vbnplcm8gb24gZXJyb3IuCj4gKyAqLwo+ICtzdGF0 aWMgaW50IGdlbjExX3Jlc2V0X2VuZ2luZXMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2LAo+ICsJCQkgICAgICAgdW5zaWduZWQgZW5naW5lX21hc2spCj4gK3sKPiArCXN0cnVjdCBp bnRlbF9lbmdpbmVfY3MgKmVuZ2luZTsKPiArCWNvbnN0IHUzMiBod19lbmdpbmVfbWFza1tJOTE1 X05VTV9FTkdJTkVTXSA9IHsKPiArCQlbUkNTXSA9IEdFTjExX0dSRE9NX1JFTkRFUiwKPiArCQlb QkNTXSA9IEdFTjExX0dSRE9NX0JMVCwKPiArCQlbVkNTXSA9IEdFTjExX0dSRE9NX01FRElBLAo+ ICsJCVtWQ1MyXSA9IEdFTjExX0dSRE9NX01FRElBMiwKPiArCQlbVkNTM10gPSBHRU4xMV9HUkRP TV9NRURJQTMsCj4gKwkJW1ZDUzRdID0gR0VOMTFfR1JET01fTUVESUE0LAo+ICsJCVtWRUNTXSA9 IEdFTjExX0dSRE9NX1ZFQ1MsCj4gKwkJW1ZFQ1MyXSA9IEdFTjExX0dSRE9NX1ZFQ1MyLAo+ICsJ fTsKPiArCXUzMiBod19tYXNrOwo+ICsKPiArCUJVSUxEX0JVR19PTihWRUNTMiArIDEgIT0gSTkx NV9OVU1fRU5HSU5FUyk7Cj4gKwo+ICsJaWYgKGVuZ2luZV9tYXNrID09IEFMTF9FTkdJTkVTKSB7 Cj4gKwkJaHdfbWFzayA9IEdFTjExX0dSRE9NX0ZVTEw7Cj4gKwl9IGVsc2Ugewo+ICsJCXVuc2ln bmVkIGludCB0bXA7Cj4gKwo+ICsJCWh3X21hc2sgPSAwOwo+ICsJCWZvcl9lYWNoX2VuZ2luZV9t YXNrZWQoZW5naW5lLCBkZXZfcHJpdiwgZW5naW5lX21hc2ssIHRtcCkKPiArCQkJaHdfbWFzayB8 PSBod19lbmdpbmVfbWFza1tlbmdpbmUtPmlkXTsKPiArCX0KPiArCj4gKwlyZXR1cm4gZ2VuNl9o d19kb21haW5fcmVzZXQoZGV2X3ByaXYsIGh3X21hc2spOwo+ICt9Cj4gKwo+ICAgLyoqCj4gICAg KiBfX2ludGVsX3dhaXRfZm9yX3JlZ2lzdGVyX2Z3IC0gd2FpdCB1bnRpbCByZWdpc3RlciBtYXRj aGVzIGV4cGVjdGVkIHN0YXRlCj4gICAgKiBAZGV2X3ByaXY6IHRoZSBpOTE1IGRldmljZQo+IEBA IC0yMDU3LDcgKzIxMDEsMTAgQEAgc3RhdGljIGludCBnZW44X3Jlc2V0X2VuZ2luZXMoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAgCQlpZiAoZ2VuOF9yZXNldF9lbmdpbmVf c3RhcnQoZW5naW5lKSkKPiAgIAkJCWdvdG8gbm90X3JlYWR5Owo+ICAgCj4gLQlyZXR1cm4gZ2Vu Nl9yZXNldF9lbmdpbmVzKGRldl9wcml2LCBlbmdpbmVfbWFzayk7Cj4gKwlpZiAoSU5URUxfR0VO KGRldl9wcml2KSA+PSAxMSkKPiArCQlyZXR1cm4gZ2VuMTFfcmVzZXRfZW5naW5lcyhkZXZfcHJp diwgZW5naW5lX21hc2spOwo+ICsJZWxzZQo+ICsJCXJldHVybiBnZW42X3Jlc2V0X2VuZ2luZXMo ZGV2X3ByaXYsIGVuZ2luZV9tYXNrKTsKPiAgIAo+ICAgbm90X3JlYWR5Ogo+ICAgCWZvcl9lYWNo X2VuZ2luZV9tYXNrZWQoZW5naW5lLCBkZXZfcHJpdiwgZW5naW5lX21hc2ssIHRtcCkKPiBAQCAt MjE2MCwxMiArMjIwNywxNCBAQCBib29sIGludGVsX2hhc19yZXNldF9lbmdpbmUoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAgCj4gICBpbnQgaW50ZWxfcmVzZXRfZ3VjKHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgIHsKPiArCXUzMiBndWNfZG9tYWlu ID0gSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMSA/IEdFTjExX0dSRE9NX0dVQyA6Cj4gKwkJCQkJ CSAgICAgR0VOOV9HUkRPTV9HVUM7Cj4gICAJaW50IHJldDsKPiAgIAo+ICAgCUdFTV9CVUdfT04o IUhBU19HVUMoZGV2X3ByaXYpKTsKPiAgIAo+ICAgCWludGVsX3VuY29yZV9mb3JjZXdha2VfZ2V0 KGRldl9wcml2LCBGT1JDRVdBS0VfQUxMKTsKPiAtCXJldCA9IGdlbjZfaHdfZG9tYWluX3Jlc2V0 KGRldl9wcml2LCBHRU45X0dSRE9NX0dVQyk7Cj4gKwlyZXQgPSBnZW42X2h3X2RvbWFpbl9yZXNl dChkZXZfcHJpdiwgZ3VjX2RvbWFpbik7Cj4gICAJaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9wdXQo ZGV2X3ByaXYsIEZPUkNFV0FLRV9BTEwpOwo+ICAgCj4gICAJcmV0dXJuIHJldDsKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=