From: Michel Thierry Subject: Re: [PATCH v5 17/18] drm/i915: Watchdog timeout: DRM kernel interface to set the timeout Date: Fri, 14 Apr 2017 09:47:43 -0700 Message-ID: <0d49a00e-9c6c-2c13-a86b-074eac91dee9@intel.com> References: <20170325013010.36244-1-michel.thierry@intel.com> <20170325013010.36244-18-michel.thierry@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 618A16E9F1 for ; Fri, 14 Apr 2017 16:47:44 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniele Ceraolo Spurio , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAxNC8wNC8xNyAwOTowNSwgRGFuaWVsZSBDZXJhb2xvIFNwdXJpbyB3cm90ZToKPgo+Cj4g T24gMjQvMDMvMTcgMTg6MzAsIE1pY2hlbCBUaGllcnJ5IHdyb3RlOgo+PiBGaW5hbCBlbmFibGVt ZW50IHBhdGNoIGZvciBHUFUgaGFuZyBkZXRlY3Rpb24gdXNpbmcgd2F0Y2hkb2cgdGltZW91dC4K Pj4gVXNpbmcgdGhlIGdlbV9jb250ZXh0X3NldHBhcmFtIGlvY3RsLCB1c2VycyBjYW4gc3BlY2lm eSB0aGUgZGVzaXJlZAo+PiB0aW1lb3V0IHZhbHVlIGluIG1pY3Jvc2Vjb25kcywgYW5kIHRoZSBk cml2ZXIgd2lsbCBkbyB0aGUgY29udmVyc2lvbiB0bwo+PiAndGltZXN0YW1wcycuCj4+Cj4+IFRo ZSByZWNvbW1lbmRlZCBkZWZhdWx0IHdhdGNoZG9nIHRocmVzaG9sZCBmb3IgdmlkZW8gZW5naW5l cyBpcyA2MDAwMCB1cywKPj4gc2luY2UgdGhpcyBoYXMgYmVlbiBfZW1waXJpY2FsbHkgZGV0ZXJt aW5lZF8gdG8gYmUgYSBnb29kIGNvbXByb21pc2UgZm9yCj4+IGxvdy1sYXRlbmN5IHJlcXVpcmVt ZW50cyBhbmQgbG93IHJhdGUgb2YgZmFsc2UgcG9zaXRpdmVzLiBUaGUgZGVmYXVsdAo+PiByZWdp c3RlciB2YWx1ZSBpcyB+MTA2MDAwdXMgYW5kIHRoZSB0aGVvcmV0aWNhbCBtYXggdmFsdWUgKGFs bCAxcykgaXMKPj4gMzUzIHNlY29uZHMuCj4+Cj4+IHYyOiBGaXhlZCBnZXQgYXBpIHRvIHJldHVy biB2YWx1ZXMgaW4gbWljcm9zZWNvbmRzLiBUaHJlc2hvbGQgdXBkYXRlZCB0bwo+PiBiZSBwZXIg Y29udGV4dCBlbmdpbmUuIENoZWNrIGZvciB1MzIgb3ZlcmZsb3cuIENhcHR1cmUgY3R4IHRocmVz aG9sZAo+PiB2YWx1ZSBpbiBlcnJvciBzdGF0ZS4KPj4KPj4gU2lnbmVkLW9mZi1ieTogVG9tYXMg RWxmIDx0b21hcy5lbGZAaW50ZWwuY29tPgo+PiBTaWduZWQtb2ZmLWJ5OiBBcnVuIFNpbHV2ZXJ5 IDxhcnVuLnNpbHV2ZXJ5QGxpbnV4LmludGVsLmNvbT4KPj4gU2lnbmVkLW9mZi1ieTogTWljaGVs IFRoaWVycnkgPG1pY2hlbC50aGllcnJ5QGludGVsLmNvbT4KPj4gLS0tCj4+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgICAgICAgfCAgMSArCj4+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2dlbV9jb250ZXh0LmMgfCA3OAo+PiArKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysKPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2NvbnRleHQuaCB8IDIw ICsrKysrKysrKwo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVfZXJyb3IuYyAgIHwg MTEgKysrLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jICAgICAgICB8ICAy ICstCj4+ICBpbmNsdWRlL3VhcGkvZHJtL2k5MTVfZHJtLmggICAgICAgICAgICAgfCAgMSArCj4+ ICA2IGZpbGVzIGNoYW5nZWQsIDEwOCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+Pgo+ PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+PiBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4gaW5kZXggYjQzYzM3YTkxMWJiLi4xNzQxNTg0 ZDg1OGYgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+PiBAQCAtMTAzOSw2ICsxMDM5 LDcgQEAgc3RydWN0IGk5MTVfZ3B1X3N0YXRlIHsKPj4gICAgICAgICAgICAgIGludCBiYW5fc2Nv cmU7Cj4+ICAgICAgICAgICAgICBpbnQgYWN0aXZlOwo+PiAgICAgICAgICAgICAgaW50IGd1aWx0 eTsKPj4gKyAgICAgICAgICAgIGludCB3YXRjaGRvZ190aHJlc2hvbGQ7Cj4+ICAgICAgICAgIH0g Y29udGV4dDsKPj4KPj4gICAgICAgICAgc3RydWN0IGRybV9pOTE1X2Vycm9yX29iamVjdCB7Cj4+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9jb250ZXh0LmMKPj4g Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9jb250ZXh0LmMKPj4gaW5kZXggZWRiZWQ4 NWExYzg4Li5mNWMxMjZjMGM2ODEgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtX2NvbnRleHQuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bV9jb250ZXh0LmMKPj4gQEAgLTQyMiw2ICs0MjIsNzggQEAgaTkxNV9nZW1fY29udGV4dF9jcmVh dGVfZ3Z0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4+ICAgICAgcmV0dXJuIGN0eDsKPj4gIH0K Pj4KPj4gKy8qIFJldHVybiB0aGUgdGltZXIgY291bnQgdGhyZXNob2xkIGluIG1pY3Jvc2Vjb25k cy4gKi8KPj4gK2ludCBpOTE1X2dlbV9jb250ZXh0X2dldF93YXRjaGRvZyhzdHJ1Y3QgaTkxNV9n ZW1fY29udGV4dCAqY3R4LAo+PiArICAgICAgICAgICAgICAgICAgc3RydWN0IGRybV9pOTE1X2dl bV9jb250ZXh0X3BhcmFtICphcmdzKQo+PiArewo+PiArICAgIHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiA9IGN0eC0+aTkxNTsKPj4gKyAgICBzdHJ1Y3QgaW50ZWxfZW5naW5lX2Nz ICplbmdpbmU7Cj4+ICsgICAgZW51bSBpbnRlbF9lbmdpbmVfaWQgaWQ7Cj4+ICsgICAgdTMyIHRo cmVzaG9sZF9pbl91c1tJOTE1X05VTV9FTkdJTkVTXTsKPj4gKwo+PiArICAgIGlmICghZGV2X3By aXYtPmVuZ2luZVtWQ1NdLT5lbWl0X3N0YXJ0X3dhdGNoZG9nKQo+PiArICAgICAgICByZXR1cm4g LUVOT0RFVjsKPj4gKwo+PiArICAgIGZvcl9lYWNoX2VuZ2luZShlbmdpbmUsIGRldl9wcml2LCBp ZCkgewo+PiArICAgICAgICBzdHJ1Y3QgaW50ZWxfY29udGV4dCAqY2UgPSAmY3R4LT5lbmdpbmVb aWRdOwo+PiArCj4+ICsgICAgICAgIHRocmVzaG9sZF9pbl91c1tpZF0gPSB3YXRjaGRvZ190b191 cyhjZS0+d2F0Y2hkb2dfdGhyZXNob2xkKTsKPj4gKyAgICB9Cj4+ICsKPj4gKyAgICBtdXRleF91 bmxvY2soJmRldl9wcml2LT5kcm0uc3RydWN0X211dGV4KTsKPj4gKyAgICBpZiAoX19jb3B5X3Rv X3VzZXIodTY0X3RvX3VzZXJfcHRyKGFyZ3MtPnZhbHVlKSwKPj4gKyAgICAgICAgICAgICAgICZ0 aHJlc2hvbGRfaW5fdXMsCj4+ICsgICAgICAgICAgICAgICBzaXplb2YodGhyZXNob2xkX2luX3Vz KSkpIHsKPj4gKyAgICAgICAgbXV0ZXhfbG9jaygmZGV2X3ByaXYtPmRybS5zdHJ1Y3RfbXV0ZXgp Owo+PiArICAgICAgICByZXR1cm4gLUVGQVVMVDsKPj4gKyAgICB9Cj4+ICsgICAgbXV0ZXhfbG9j aygmZGV2X3ByaXYtPmRybS5zdHJ1Y3RfbXV0ZXgpOwo+PiArICAgIGFyZ3MtPnNpemUgPSBzaXpl b2YodGhyZXNob2xkX2luX3VzKTsKPj4gKwo+PiArICAgIHJldHVybiAwOwo+PiArfQo+PiArCj4+ ICsvKgo+PiArICogQmFzZWQgb24gdGltZSBvdXQgdmFsdWUgaW4gbWljcm9zZWNvbmRzICh1cykg Y2FsY3VsYXRlCj4+ICsgKiB0aW1lciBjb3VudCB0aHJlc2hvbGRzIG5lZWRlZCBiYXNlZCBvbiBj b3JlIGZyZXF1ZW5jeS4KPj4gKyAqIFdhdGNoZG9nIGNhbiBiZSBkaXNhYmxlZCBieSBzZXR0aW5n IGl0IHRvIDAuCj4+ICsgKi8KPj4gK2ludCBpOTE1X2dlbV9jb250ZXh0X3NldF93YXRjaGRvZyhz dHJ1Y3QgaTkxNV9nZW1fY29udGV4dCAqY3R4LAo+PiArICAgICAgICAgICAgICAgICAgc3RydWN0 IGRybV9pOTE1X2dlbV9jb250ZXh0X3BhcmFtICphcmdzKQo+PiArewo+PiArICAgIHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGN0eC0+aTkxNTsKPj4gKyAgICBzdHJ1Y3QgaW50 ZWxfZW5naW5lX2NzICplbmdpbmU7Cj4+ICsgICAgZW51bSBpbnRlbF9lbmdpbmVfaWQgaWQ7Cj4+ ICsgICAgdTMyIHRocmVzaG9sZF9pbl91c1tJOTE1X05VTV9FTkdJTkVTXTsKPj4gKwo+PiArICAg IGlmICghZGV2X3ByaXYtPmVuZ2luZVtWQ1NdLT5lbWl0X3N0YXJ0X3dhdGNoZG9nKQo+PiArICAg ICAgICByZXR1cm4gLUVOT0RFVjsKPj4gKyAgICBlbHNlIGlmIChhcmdzLT5zaXplIDwgc2l6ZW9m KHRocmVzaG9sZF9pbl91cykpCj4+ICsgICAgICAgIHJldHVybiAtRUlOVkFMOwo+Cj4gd29uJ3Qg d2UgYnJlYWsgdXNlcnNwYWNlIHdpdGggdGhpcyBjaGVjayBpZiB3ZSBldmVyIGdldCBtb3JlIGVu Z2luZXMgb24KPiBhIG5ldyBwbGF0Zm9ybSBhbmQgdGh1cyBidW1wIEk5MTVfTlVNX0VOR0lORVM/ Cj4KPiBUaGFua3MsCj4gRGFuaWVsZQo+CgpUaGVyZSdzIGEgdjMgb2YgdGhpcyBwYXRjaCB3aXRo IENocmlzIGZlZWRiYWNrLApodHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0Y2gv MTQ4ODA1LwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK