Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21C2EC433FE for ; Tue, 8 Nov 2022 01:42:13 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 689148502C; Tue, 8 Nov 2022 02:42:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="UkIUAouA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7E53285046; Tue, 8 Nov 2022 02:42:09 +0100 (CET) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EE0F48501C for ; Tue, 8 Nov 2022 02:42:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qt1-x830.google.com with SMTP id c15so7956882qtw.8 for ; Mon, 07 Nov 2022 17:42:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5O5uGj2+Pwl/VivMfVSaM9FOq66Uz9WXJIiFl8R2j5Q=; b=UkIUAouAzLehZMHEO9U6gn+s3PqF+/8Vg3jcttGr3UKTZ+Pq3WpjpQv3BLq+lZe6f0 KSeJFbgbFnXB+QMPxCeJsiR+zi0cfl4j4SGseIjvVDPdyr6ADX6jEurkhkwFx2WwzKn2 72sQvtioonWUfluiDp7sEhDFU+NMCZoLGKGespDfO+sP2KeUVxR+5XY8DTS333AQ2ywW Z+qDDEEqYp6Pmgwri0haJLNYO5x+6zoVHxzyvUf2A04tZBZLTYytWm5U1SdXpba3cBca 9TIZTLakvvby7l2xeQUhxYMKl2cxI5A/yyi8EFG8Gfg7juIGsFZQvcr3o5BtQy9HMJGT 6foA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5O5uGj2+Pwl/VivMfVSaM9FOq66Uz9WXJIiFl8R2j5Q=; b=DGO1ITH7s6iyqhuZZIj7t1PGs3SSX5pc/vcO4tF0fOOHzhoiiro3HwWtYkdrvSd5yX iYQCew4Kon7sSDmLiartVVs/Qx+/4dTMuotYtB3v8dbbvVe9sPDYVhrsOszYoOP8k8FS 3j/fvAKRYX6SyXPqHhgN7kOfFNP2+u2nqXJnRqUvsZmfGOY9Wtzwlwcy/JTPDA2mFKSc VkDjpuN0/zNMg8vHkxGdvPlDS6MTJ4WplBDGH66HEEwq/WarCW7/aj3t2nqowaK/KOwF Mx5g/DvwiX3pmj8YOoE+IeFEIsVyCdcwhUH9Uj2CT7JgY43e+Jd0I066QuGEfBOAeLgo DTGw== X-Gm-Message-State: ANoB5pnKOkwfcmr3OObytwbvd69OGBZA6wVyNjZe2+goqcAG3sKqvYV7 Tp/9Y8tpC0wr9bodEU4/9UU= X-Google-Smtp-Source: AA0mqf4qjEsxC4E/d1FG39rRqVrJ00uwHs60Soh6F4aQdvipZZCtlbMVJvpcwsGfBP0TgdOk7GZIOw== X-Received: by 2002:ac8:7d03:0:b0:3a5:82bd:6c56 with SMTP id g3-20020ac87d03000000b003a582bd6c56mr8935836qtb.418.1667871723269; Mon, 07 Nov 2022 17:42:03 -0800 (PST) Received: from [192.168.1.201] (pool-173-73-95-180.washdc.fios.verizon.net. [173.73.95.180]) by smtp.gmail.com with ESMTPSA id bm26-20020a05620a199a00b006ed138e89f2sm7990743qkb.123.2022.11.07.17.42.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Nov 2022 17:42:02 -0800 (PST) Message-ID: <0dec129a-7b4d-37ac-6122-757e0b76c612@gmail.com> Date: Mon, 7 Nov 2022 20:42:01 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/5] usb: dwc3: Cache ref_clk pointer in struct dwc3 Content-Language: en-US To: Marek Vasut , u-boot@lists.denx.de Cc: Angus Ainslie , Bin Meng , Fabio Estevam , Kunihiko Hayashi , Michal Simek , Peng Fan , Sean Anderson , Stefano Babic References: <20221108014013.750292-1-marex@denx.de> From: Sean Anderson In-Reply-To: <20221108014013.750292-1-marex@denx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 11/7/22 20:40, Marek Vasut wrote: > Cache ref_clk clock pointer in struct dwc3 . This is a preparatory > patch for subsequent backports from Linux kernel which configure > GFLADJ register content based on the ref_clk rate and therefore need > access to the ref_clk pointer. > > It is possible to extract the clock pointer from existing clk_bulk > list of already claimed clock, no need to call clk_get*() again. > > Signed-off-by: Marek Vasut > --- > Cc: Angus Ainslie > Cc: Bin Meng > Cc: Fabio Estevam > Cc: Kunihiko Hayashi > Cc: Michal Simek > Cc: Peng Fan > Cc: Sean Anderson > Cc: Stefano Babic > --- > V2: Add paragraph on clk_get into commit message > --- > drivers/usb/dwc3/core.h | 3 +++ > drivers/usb/dwc3/dwc3-generic.c | 9 +++++++++ > 2 files changed, 12 insertions(+) > > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h > index d7cce3a861a..0d20fe285b0 100644 > --- a/drivers/usb/dwc3/core.h > +++ b/drivers/usb/dwc3/core.h > @@ -668,6 +668,7 @@ struct dwc3_scratchpad_array { > * @event_buffer_list: a list of event buffers > * @gadget: device side representation of the peripheral controller > * @gadget_driver: pointer to the gadget driver > + * @ref_clk: reference clock > * @regs: base address for our registers > * @regs_size: address space size > * @nr_scratch: number of scratch buffers > @@ -766,6 +767,8 @@ struct dwc3 { > struct usb_gadget gadget; > struct usb_gadget_driver *gadget_driver; > > + struct clk *ref_clk; > + > void __iomem *regs; > size_t regs_size; > > diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c > index 466b25a0c38..78966718d01 100644 > --- a/drivers/usb/dwc3/dwc3-generic.c > +++ b/drivers/usb/dwc3/dwc3-generic.c > @@ -59,12 +59,21 @@ static int dwc3_generic_probe(struct udevice *dev, > struct dwc3_generic_plat *plat = dev_get_plat(dev); > struct dwc3 *dwc3 = &priv->dwc3; > struct dwc3_glue_data *glue = dev_get_plat(dev->parent); > + int __maybe_unused index; > + ofnode __maybe_unused node; > > dwc3->dev = dev; > dwc3->maximum_speed = plat->maximum_speed; > dwc3->dr_mode = plat->dr_mode; > #if CONFIG_IS_ENABLED(OF_CONTROL) > dwc3_of_parse(dwc3); > + > + node = dev_ofnode(dev->parent); > + index = ofnode_stringlist_search(node, "clock-names", "ref"); > + if (index < 0) > + index = ofnode_stringlist_search(node, "clock-names", "ref_clk"); > + if (index >= 0) > + dwc3->ref_clk = &glue->clks.clks[index]; > #endif > > /* Reviewed-by: Sean Anderson