From: "mrbff (Code Review)" Date: Fri, 29 Nov 2024 17:14:56 +0000 In-Reply-To: References: Reply-To: marco@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., lstipakov@...277... Message-ID: <0e1c700b7eb91a112f9e2c062eff3c636662b1c3-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="+vbNvUjVw4o="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle PUSH ... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stipa , flichtenheld , plaisthos , openvpn-devel --+vbNvUjVw4o= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos, stipa. mrbff has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/808?usp=3Demail ) Change subject: PUSH_UPDATE: Allow OpenVPN in client mode to receive and ha= ndle PUSH UPDATE control messages to allow options updating at runtime. ...................................................................... Patch Set 6: (1 comment) File src/openvpn/push.c: http://gerrit.openvpn.net/c/openvpn/+/808/comment/d1a9ecd3_e048bce9 : PS6, Line 543: msg(M_WARN, "No option found"); > This warning is a bit confusing. [=E2=80=A6] I put it to avoid that in case of a correct message but without updates (so= mething like "PUSH_UPDATE,," or "PUSH_UPDATE,?something_not_updatable") the= re was a useless closing and reopening of the tun, but it is not a real err= or message, it is more of an info. I'm not even sure it is the correct way = to handle it, what do you suggest? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/808?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595c742aeec6064a Gerrit-Change-Number: 808 Gerrit-PatchSet: 6 Gerrit-Owner: mrbff Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: stipa Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: stipa Gerrit-Comment-Date: Fri, 29 Nov 2024 17:14:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: stipa Gerrit-MessageType: comment --+vbNvUjVw4o= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos, stipa. <= /p>

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    File src/openvpn/push.c:

    • Patch Set #6, Line 543: msg(M_WAR= N, "No option found");

      This warning is a bi= t confusing. [=E2=80=A6]

      I put it to avoid that in case of a correct messag= e but without updates (something like "PUSH_UPDATE,," or "PU= SH_UPDATE,?something_not_updatable") there was a useless closing and r= eopening of the tun, but it is not a real error message, it is more of an i= nfo. I'm not even sure it is the correct way to handle it, what do you = suggest?

To view, visit change 808. To unsubscribe, or= for help writing mail filters, visit settings.

<= /div>
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595= c742aeec6064a
Gerrit-Change-Number: 808
Gerrit-PatchSet: 6
Gerrit-Owner: mrbff <marco@...2726...> <= /div>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-Reviewer: stipa <lstipakov@...277...= >
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: stipa <lstipakov@...1663...= .>
Gerrit-Comment-Date: Fri, 29 Nov 2024 17:14:56= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: stipa <lstipakov@...1664...= 7...>
Gerrit-MessageType: comment
--+vbNvUjVw4o=--