Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C9FBC47080 for ; Tue, 1 Jun 2021 08:56:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C2536138C for ; Tue, 1 Jun 2021 08:56:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233485AbhFAI6B (ORCPT ); Tue, 1 Jun 2021 04:58:01 -0400 Received: from mga07.intel.com ([134.134.136.100]:45708 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231139AbhFAI6A (ORCPT ); Tue, 1 Jun 2021 04:58:00 -0400 IronPort-SDR: Yt2c5UZZu6SpzDG+Osg3UqSnIXaebLYL1Qty96QzHQzDeMBSfp8dWWb57T5YvHWJV8VGPzCFq3 WWnqSxqGA3Fg== X-IronPort-AV: E=McAfee;i="6200,9189,10001"; a="267382565" X-IronPort-AV: E=Sophos;i="5.83,239,1616482800"; d="scan'208";a="267382565" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2021 01:56:18 -0700 IronPort-SDR: fVggAIVF+j58mrFf5/uo8qPBI1TIIE+PP80+2JNOcdxpBhxHlDj/9W3Kpa8Gk7ssu5LQKPbd8e 0sQcG3LcN6tg== X-IronPort-AV: E=Sophos;i="5.83,239,1616482800"; d="scan'208";a="549666530" Received: from lingshan-mobl5.ccr.corp.intel.com (HELO [10.254.211.211]) ([10.254.211.211]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2021 01:56:16 -0700 Subject: Re: [PATCH V3 2/2] vDPA/ifcvf: implement doorbell mapping for ifcvf To: Jason Wang , mst@redhat.com Cc: virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, kvm@vger.kernel.org References: <20210601062850.4547-1-lingshan.zhu@intel.com> <20210601062850.4547-3-lingshan.zhu@intel.com> From: "Zhu, Lingshan" Message-ID: <0e40f29a-5d37-796a-5d01-8594b3afbfdb@intel.com> Date: Tue, 1 Jun 2021 16:56:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 6/1/2021 4:50 PM, Jason Wang wrote: > > 在 2021/6/1 下午2:28, Zhu Lingshan 写道: >> This commit implements doorbell mapping feature for ifcvf. >> This feature maps the notify page to userspace, to eliminate >> vmexit when kick a vq. >> >> Signed-off-by: Zhu Lingshan >> --- >>   drivers/vdpa/ifcvf/ifcvf_main.c | 21 +++++++++++++++++++++ >>   1 file changed, 21 insertions(+) >> >> diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c >> b/drivers/vdpa/ifcvf/ifcvf_main.c >> index ab0ab5cf0f6e..d41db042612c 100644 >> --- a/drivers/vdpa/ifcvf/ifcvf_main.c >> +++ b/drivers/vdpa/ifcvf/ifcvf_main.c >> @@ -413,6 +413,26 @@ static int ifcvf_vdpa_get_vq_irq(struct >> vdpa_device *vdpa_dev, >>       return vf->vring[qid].irq; >>   } >>   +static struct vdpa_notification_area >> ifcvf_get_vq_notification(struct vdpa_device *vdpa_dev, >> +                                   u16 idx) >> +{ >> +    struct ifcvf_adapter *adapter = vdpa_to_adapter(vdpa_dev); >> +    struct ifcvf_hw *vf = vdpa_to_vf(vdpa_dev); >> +    struct pci_dev *pdev = adapter->pdev; >> +    struct vdpa_notification_area area; >> + >> +    area.addr = vf->vring[idx].notify_pa; >> +    if (!vf->notify_off_multiplier) >> +        area.size = PAGE_SIZE; >> +    else >> +        area.size = vf->notify_off_multiplier; >> + >> +    if (area.addr % PAGE_SIZE) >> +        IFCVF_DBG(pdev, "vq %u doorbell address is not PAGE_SIZE >> aligned\n", idx); > > > I don't see the reason to keep this, or get_notification is not the > proper place to do this kind of warning. > > Thanks some customers have ever complained have troubles to enable such features with their IP, I think this can help them debug. Thanks > > >> + >> +    return area; >> +} >> + >>   /* >>    * IFCVF currently does't have on-chip IOMMU, so not >>    * implemented set_map()/dma_map()/dma_unmap() >> @@ -440,6 +460,7 @@ static const struct vdpa_config_ops ifc_vdpa_ops = { >>       .get_config    = ifcvf_vdpa_get_config, >>       .set_config    = ifcvf_vdpa_set_config, >>       .set_config_cb  = ifcvf_vdpa_set_config_cb, >> +    .get_vq_notification = ifcvf_get_vq_notification, >>   }; >>     static int ifcvf_probe(struct pci_dev *pdev, const struct >> pci_device_id *id) >