From: Tom St Denis Subject: Re: [PATCH] Add PCI device based GPU selection with --pci Date: Fri, 23 Jun 2017 07:20:35 -0400 Message-ID: <0e9966a5-e08f-13f9-4bf0-bc6cc650a749@amd.com> References: <20170622203638.68560-1-jfthibert@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170622203638.68560-1-jfthibert-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org U29tZSBzdHlsZS9mbG93IGlzc3VlcyBpbmxpbmUgYmVsb3cuCgoKT24gMjIvMDYvMTcgMDQ6MzYg UE0sIEplYW4tRnJhbmNvaXMgVGhpYmVydCB3cm90ZToKPiBUaGlzIGFsbG93cyBzZWxlY3Rpbmcg dGhlIEdQVSBieSBpdHMgUENJIGRldmljZSBib3RoIHdpdGggYW5kCj4gd2l0aG91dCBrZXJuZWwg bW9kZSBzdXBwb3J0LiBUaGUgaW5zdGFuY2UgaXMgcG9wdWxhdGVkIGF1dG9tYXRpY2FsbHkKPiBz byB0aGF0IHRoZSBwcm9wZXIgY29ycmVzcG9uZGluZyBkZWJ1Z2ZzIGZpbGVzIGFyZSB1c2VkIGlm IHByZXNlbnQuCj4gCj4gU2lnbmVkLW9mZi1ieTogSmVhbi1GcmFuY29pcyBUaGliZXJ0IDxqZnRo aWJlcnRAZ29vZ2xlLmNvbT4KPiAtLS0KPiAgIHNyYy9hcHAvbWFpbi5jICAgICB8ICA5ICsrKysr Kwo+ICAgc3JjL2xpYi9kaXNjb3Zlci5jIHwgODUgKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKy0tCj4gICBzcmMvdW1yLmggICAgICAgICAgfCAgNiAr KystCj4gICAzIGZpbGVzIGNoYW5nZWQsIDk2IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL3NyYy9hcHAvbWFpbi5jIGIvc3JjL2FwcC9tYWluLmMKPiBpbmRl eCAxZDllZjllLi5hYTYzMGY1IDEwMDY0NAo+IC0tLSBhL3NyYy9hcHAvbWFpbi5jCj4gKysrIGIv c3JjL2FwcC9tYWluLmMKPiBAQCAtMTc0LDYgKzE3NCwxNSBAQCBpbnQgbWFpbihpbnQgYXJnYywg Y2hhciAqKmFyZ3YpCj4gICAJCQkJcHJpbnRmKCItLWZvcmNlIHJlcXVpcmVzIGEgbnVtYmVyL25h bWVcbiIpOwo+ICAgCQkJCXJldHVybiBFWElUX0ZBSUxVUkU7Cj4gICAJCQl9Cj4gKwkJfSBlbHNl IGlmICghc3RyY21wKGFyZ3ZbaV0sICItLXBjaSIpKSB7Cj4gKwkJCWlmIChpICsgMSA8IGFyZ2Mg JiYgc3NjYW5mKGFyZ3ZbaSsxXSwgIiUwNHg6JTAyeDolMDJ4LiUwMXgiLAo+ICsJCQkJJm9wdGlv bnMucGNpX2RvbWFpbiwgJm9wdGlvbnMucGNpX2J1cywgJm9wdGlvbnMucGNpX3Nsb3QsCj4gKwkJ CQkmb3B0aW9ucy5wY2lfZnVuYyApID49IDQpIHsKPiArCQkJCSsraTsKPiArCQkJfSBlbHNlIHsK PiArCQkJCXByaW50ZigiLS1wY2kgcmVxdWlyZXMgZG9tYWluOmJ1czpzbG90LmZ1bmN0aW9uXG4i KTsKPiArCQkJCXJldHVybiBFWElUX0ZBSUxVUkU7Cj4gKwkJCX0KCkNvdWxkIHVzZSBtYW4vaGVs cCB0ZXh0IHVwZGF0ZXMuICBJIGNhbiBkbyB0aGF0IHRob3VnaCBpbiBhIGZvbGxvd3VwIHBhdGNo LgoKPiAgIAkJfSBlbHNlIGlmICghc3RyY21wKGFyZ3ZbaV0sICItLXByaW50IikgfHwgIXN0cmNt cChhcmd2W2ldLCAiLXAiKSkgewo+ICAgCQkJb3B0aW9ucy5wcmludCA9IDE7Cj4gICAJCQlvcHRp b25zLm5lZWRfc2NhbiA9IDE7Cj4gZGlmZiAtLWdpdCBhL3NyYy9saWIvZGlzY292ZXIuYyBiL3Ny Yy9saWIvZGlzY292ZXIuYwo+IGluZGV4IDk2NjJkMDUuLjhhYjMyMWYgMTAwNjQ0Cj4gLS0tIGEv c3JjL2xpYi9kaXNjb3Zlci5jCj4gKysrIGIvc3JjL2xpYi9kaXNjb3Zlci5jCj4gQEAgLTIyLDYg KzIyLDkgQEAKPiAgICAqIEF1dGhvcnM6IFRvbSBTdCBEZW5pcyA8dG9tLnN0ZGVuaXNAYW1kLmNv bT4KPiAgICAqCj4gICAgKi8KPiArI2luY2x1ZGUgPGRpcmVudC5oPgo+ICsjaW5jbHVkZSA8c3lz L3R5cGVzLmg+Cj4gKwo+ICAgI2luY2x1ZGUgInVtci5oIgo+ICAgCj4gICBzdGF0aWMgaW50IGlz X2RpZF9tYXRjaChzdHJ1Y3QgdW1yX2FzaWMgKmFzaWMsIHVuc2lnbmVkIGRpZCkKPiBAQCAtNDQs NiArNDcsNDMgQEAgc3RhdGljIGludCBpc19kaWRfbWF0Y2goc3RydWN0IHVtcl9hc2ljICphc2lj LCB1bnNpZ25lZCBkaWQpCj4gICAJcmV0dXJuIHI7Cj4gICB9Cj4gICAKPiArc3RhdGljIGludCBm aW5kX3BjaV9pbnN0YW5jZShjb25zdCBjaGFyKiBwY2lfc3RyaW5nKSB7Cj4gKwlESVIqIGRpcjsK PiArCWRpciA9IG9wZW5kaXIoIi9zeXMva2VybmVsL2RlYnVnL2RyaSIpOwo+ICsJaWYgKGRpciA9 PSBOVUxMKSB7Cj4gKwkJcGVycm9yKCJDb3VsZG4ndCBvcGVuIERSSSB1bmRlciBkZWJ1Z2ZzIik7 Cj4gKwkJcmV0dXJuIC0xOwo+ICsJfQo+ICsJc3RydWN0IGRpcmVudCAqZGlyX2VudHJ5Owo+ICsJ d2hpbGUgKChkaXJfZW50cnkgPSByZWFkZGlyKGRpcikpICE9IE5VTEwpIHsKPiArCQkvLyBpZ25v cmUgLiBhbmQgLi4KPiArCQlpZiAoc3RyY21wKGRpcl9lbnRyeS0+ZF9uYW1lLCAiLiIpID09IDAg fHwgc3RyY21wKGRpcl9lbnRyeS0+ZF9uYW1lLAo+ICsJCQkiLi4iKSA9PSAwKSB7Cj4gKwkJCWNv bnRpbnVlOwo+ICsJCX0KPiArCQljaGFyIG5hbWVbMjU2XTsKCkkgdHJ5IG5vdCB0byB1c2UgQzk5 L0MrKyBzdHlsZSBkZWNsYXJhdGlvbi1pbi1zY29wZSAoZXhjZXB0IGF0IHRoZSBzdGFydCAKb2Yg c2NvcGUpIHZhcmlhYmxlcy4gIEl0IG1ha2VzIHRoZSBjb2RlIGVhc2llciB0byBmb2xsb3csIGUu Zy4gImhvdyBiaWcgCmlzIG5hbWUsIG9oIGxvb2sgYXQgdGhlIHN0YXJ0IG9mIHRoZSBibG9jayku CgpBbHNvIEkgdXNlIGtlcm5lbCBzdHlsZSB7fSBydWxlcyB3aGVyZSBzaW5nbGUgc3RhdGVtZW50 IGJsb2NrcyBkb24ndCAKcmVjZWl2ZSB7fSB1bmxlc3MgdGhleSdyZSBwYWlyZWQgd2l0aCBhbm90 aGVyIHJlbGF0ZWQgKGUuZy4gaWYvZWxzZSkgCmJsb2NrIHdoaWNoIGhhcyBtdWx0aXBsZSBzdGF0 ZW1lbnRzLgoKPiArCQlzbnByaW50ZihuYW1lLCBzaXplb2YobmFtZSkgLSAxLCAiL3N5cy9rZXJu ZWwvZGVidWcvZHJpLyVzL25hbWUiLAo+ICsJCQlkaXJfZW50cnktPmRfbmFtZSk7Cj4gKwkJRklM RSAqZiA9IGZvcGVuKG5hbWUsICJyIik7Cj4gKwkJaWYgKCFmKSB7Cj4gKwkJCWNvbnRpbnVlOwo+ ICsJCX0KPiArCQljaGFyIGRldmljZVsyNTZdID0ge307Cj4gKwkJaW50IHBhcnNlZF9kZXZpY2Ug PSBmc2NhbmYoZiwgIiUqcyAlMjU1cyIsIGRldmljZSk7Cj4gKwkJZmNsb3NlKGYpOwo+ICsJCWlm IChwYXJzZWRfZGV2aWNlICE9IDEpCj4gKwkJCWNvbnRpbnVlOwo+ICsJCS8vIHN0cmlwIG9mZiBk ZXY9IGZvciBrZXJuZWxzID4gNC43Cj4gKwkJaWYgKHN0cnN0cihkZXZpY2UsICJkZXY9IikpCj4g KwkJCW1lbW1vdmUoZGV2aWNlLCBkZXZpY2UrNCwgc3RybGVuKGRldmljZSktMyk7Cj4gKwkJaWYg KHN0cmNtcChwY2lfc3RyaW5nLCBkZXZpY2UpID09IDApIHsKPiArCQkJY2xvc2VkaXIoZGlyKTsK PiArCQkJcmV0dXJuIGF0b2koZGlyX2VudHJ5LT5kX25hbWUpOwo+ICsJCX0KPiArCX0KPiArCWNs b3NlZGlyKGRpcik7Cj4gKwlyZXR1cm4gLTE7Cj4gK30KPiAgIAo+ICAgc3RydWN0IHVtcl9hc2lj ICp1bXJfZGlzY292ZXJfYXNpYyhzdHJ1Y3QgdW1yX29wdGlvbnMgKm9wdGlvbnMpCj4gICB7Cj4g QEAgLTUzLDYgKzkzLDI5IEBAIHN0cnVjdCB1bXJfYXNpYyAqdW1yX2Rpc2NvdmVyX2FzaWMoc3Ry dWN0IHVtcl9vcHRpb25zICpvcHRpb25zKQo+ICAgCXN0cnVjdCB1bXJfYXNpYyAqYXNpYzsKPiAg IAlsb25nIHRyeWRpZCA9IG9wdGlvbnMtPmZvcmNlZGlkOwo+ICAgCj4gKwkvLyBUcnkgdG8gbWFw IHRvIGluc3RhbmNlIGlmIHdlIGhhdmUgYSBzcGVjaWZpYyBwY2kgZGV2aWNlCj4gKwlpZiAob3B0 aW9ucy0+cGNpX2RvbWFpbiB8fCBvcHRpb25zLT5wY2lfYnVzIHx8Cj4gKwkJb3B0aW9ucy0+cGNp X3Nsb3QgfHwgb3B0aW9ucy0+cGNpX2Z1bmMpIHsKPiArCQljaGFyIHBjaV9zdHJpbmdbMTZdOwo+ ICsJCXNucHJpbnRmKHBjaV9zdHJpbmcsIHNpemVvZihwY2lfc3RyaW5nKSAtIDEsICIlMDR4OiUw Mng6JTAyeC4leCIsCj4gKwkJCW9wdGlvbnMtPnBjaV9kb21haW4sIG9wdGlvbnMtPnBjaV9idXMs IG9wdGlvbnMtPnBjaV9zbG90LAo+ICsJCQlvcHRpb25zLT5wY2lfZnVuYyk7Cj4gKwkJaWYgKCFv cHRpb25zLT5ub19rZXJuZWwpIHsKPiArCQkJb3B0aW9ucy0+aW5zdGFuY2UgPSBmaW5kX3BjaV9p bnN0YW5jZShwY2lfc3RyaW5nKTsKPiArCQl9Cj4gKwkJc25wcmludGYoZHJpdmVyLCBzaXplb2Yo ZHJpdmVyKS0xLCAiL3N5cy9idXMvcGNpL2RldmljZXMvJXMvZGV2aWNlIiwgcGNpX3N0cmluZyk7 Cj4gKwkJZiA9IGZvcGVuKGRyaXZlciwgInIiKTsKPiArCQlpZiAoIWYpIHsKPiArCQkJaWYgKCFv cHRpb25zLT5xdWlldCkgcGVycm9yKCJDYW5ub3Qgb3BlbiBQQ0kgZGV2aWNlIG5hbWUgdW5kZXIg c3lzZnMgKGlzIGEgZGlzcGxheSBhdHRhY2hlZD8pIik7Cj4gKwkJCXJldHVybiBOVUxMOwo+ICsJ CX0KPiArCQlpbnQgZm91bmRfZGlkID0gZnNjYW5mKGYsICIweCUwNGx4IiwgJnRyeWRpZCk7Cj4g KwkJZmNsb3NlKGYpOwo+ICsJCWlmIChmb3VuZF9kaWQgIT0gMSkgewo+ICsJCQlpZiAoIW9wdGlv bnMtPnF1aWV0KSBwcmludGYoIkNvdWxkIG5vdCByZWFkIGRldmljZSBpZCIpOwo+ICsJCQlyZXR1 cm4gTlVMTDsKPiArCQl9CgpNYXliZSBzZXQgdHJ5ZGlkIGhlcmUgaW5zdGVhZCBmb3IgY29uc2lz dGVuY3kuCgo+ICsJfQo+ICAgCS8vIHRyeSB0byBzY2FuIHZpYSBkZWJ1Z2ZzCj4gICAJYXNpYyA9 IGNhbGxvYygxLCBzaXplb2YgKmFzaWMpOwo+ICAgCWlmIChhc2ljKSB7CgoKTm90IHBhcnQgb2Yg eW91ciBwYXRjaCBidXQgd2Ugc2hvdWxkIGdhdGUgYWxsIG9mIHRoaXMgYmVoaW5kICJpZiAKKCFv cHRpb25zLT5ub19rZXJuZWwpIiBzaW5jZSB0aGUgZGVidWdmcyBlbnRyeSBjYW5ub3QgYmUgdXNl ZCBpbiB0aGF0IAptb2RlLiAgSSBjYW4gZG8gdGhhdCBpbiBhIGZvbGxvd3VwIHBhdGNoLgoKPiBA QCAtNjQsNyArMTI3LDYgQEAgc3RydWN0IHVtcl9hc2ljICp1bXJfZGlzY292ZXJfYXNpYyhzdHJ1 Y3QgdW1yX29wdGlvbnMgKm9wdGlvbnMpCj4gICAJCXVtcl9mcmVlX2FzaWMoYXNpYyk7Cj4gICAJ CWFzaWMgPSBOVUxMOwo+ICAgCX0KPiAtCj4gICAJaWYgKHRyeWRpZCA8IDApIHsKPiAgIAkJc25w cmludGYobmFtZSwgc2l6ZW9mKG5hbWUpLTEsICIvc3lzL2tlcm5lbC9kZWJ1Zy9kcmkvJWQvbmFt ZSIsIG9wdGlvbnMtPmluc3RhbmNlKTsKPiAgIAkJZiA9IGZvcGVuKG5hbWUsICJyIik7Cj4gQEAg LTg2LDggKzE0OCwxMiBAQCBzdHJ1Y3QgdW1yX2FzaWMgKnVtcl9kaXNjb3Zlcl9hc2ljKHN0cnVj dCB1bXJfb3B0aW9ucyAqb3B0aW9ucykKPiAgIAkJCX0KPiAgIAkJCXJldHVybiBOVUxMOwo+ICAg CQl9Cj4gLQkJZnNjYW5mKGYsICIlcyAlcyAlc1xuIiwgZHJpdmVyLCBuYW1lLCBkcml2ZXIpOwo+ ICsJCWludCBwYXJzZWRfcGNpX2lkID0gZnNjYW5mKGYsICIlKnMgJXMiLCBuYW1lKTsKPiAgIAkJ ZmNsb3NlKGYpOwo+ICsJCWlmIChwYXJzZWRfcGNpX2lkICE9IDEpIHsKPiArCQkJaWYgKCFvcHRp b25zLT5xdWlldCkgcHJpbnRmKCJDYW5ub3QgcmVhZCBwY2kgZGV2aWNlIGlkXG4iKTsKPiArCQkJ cmV0dXJuIE5VTEw7Cj4gKwkJfQo+ICAgCj4gICAJCS8vIHN0cmlwIG9mZiBkZXY9IGZvciBrZXJu ZWxzID4gNC43Cj4gICAJCWlmIChzdHJzdHIobmFtZSwgImRldj0iKSkKPiBAQCAtOTksOCArMTY1 LDEyIEBAIHN0cnVjdCB1bXJfYXNpYyAqdW1yX2Rpc2NvdmVyX2FzaWMoc3RydWN0IHVtcl9vcHRp b25zICpvcHRpb25zKQo+ICAgCQkJaWYgKCFvcHRpb25zLT5xdWlldCkgcGVycm9yKCJDYW5ub3Qg b3BlbiBQQ0kgZGV2aWNlIG5hbWUgdW5kZXIgc3lzZnMgKGlzIGEgZGlzcGxheSBhdHRhY2hlZD8p Iik7Cj4gICAJCQlyZXR1cm4gTlVMTDsKPiAgIAkJfQo+IC0JCWZzY2FuZihmLCAiMHglMDR4Iiwg JmRpZCk7Cj4gKwkJaW50IHBhcnNlZF9kaWQgPSBmc2NhbmYoZiwgIjB4JTA0eCIsICZkaWQpOwo+ ICAgCQlmY2xvc2UoZik7Cj4gKwkJaWYgKHBhcnNlZF9kaWQgIT0gMSkgewo+ICsJCQlpZiAoIW9w dGlvbnMtPnF1aWV0KSBwcmludGYoIkNvdWxkIG5vdCByZWFkIGRldmljZSBpZCIpOwo+ICsJCQly ZXR1cm4gTlVMTDsKPiArCQl9Cj4gICAJCWFzaWMgPSB1bXJfZGlzY292ZXJfYXNpY19ieV9kaWQo b3B0aW9ucywgZGlkKTsKPiAgIAl9IGVsc2Ugewo+ICAgCQlpZiAob3B0aW9ucy0+ZGV2X25hbWVb MF0pCj4gQEAgLTE1OCw2ICsyMjgsMTUgQEAgc3RydWN0IHVtcl9hc2ljICp1bXJfZGlzY292ZXJf YXNpYyhzdHJ1Y3QgdW1yX29wdGlvbnMgKm9wdGlvbnMpCj4gICAJCQl9Cj4gICAJCQlkbyB7Cj4g ICAJCQkJYXNpYy0+cGNpLnBkZXZpY2UgPSBwY2lfZGV2aWNlX25leHQocGNpX2l0ZXIpOwo+ICsJ CQkJaWYgKG9wdGlvbnMtPnBjaV9kb21haW4gfHwgb3B0aW9ucy0+cGNpX2J1cyB8fCBvcHRpb25z LT5wY2lfc2xvdCB8fCBvcHRpb25zLT5wY2lfZnVuYykgewo+ICsJCQkJCXdoaWxlIChhc2ljLT5w Y2kucGRldmljZSAmJiAoCj4gKwkJCQkJCW9wdGlvbnMtPnBjaV9kb21haW4gIT0gYXNpYy0+cGNp LnBkZXZpY2UtPmRvbWFpbiB8fAo+ICsJCQkJCQlvcHRpb25zLT5wY2lfYnVzICE9IGFzaWMtPnBj aS5wZGV2aWNlLT5idXMgfHwKPiArCQkJCQkJb3B0aW9ucy0+cGNpX3Nsb3QgIT0gYXNpYy0+cGNp LnBkZXZpY2UtPmRldiB8fAo+ICsJCQkJCQlvcHRpb25zLT5wY2lfZnVuYyAhPSBhc2ljLT5wY2ku cGRldmljZS0+ZnVuYykpIHsKPiArCQkJCQkJYXNpYy0+cGNpLnBkZXZpY2UgPSBwY2lfZGV2aWNl X25leHQocGNpX2l0ZXIpOwo+ICsJCQkJCX0KPiArCQkJCX0KPiAgIAkJCX0gd2hpbGUgKGFzaWMt PnBjaS5wZGV2aWNlICYmICEoYXNpYy0+cGNpLnBkZXZpY2UtPnZlbmRvcl9pZCA9PSAweDEwMDIg JiYgaXNfZGlkX21hdGNoKGFzaWMsIGFzaWMtPnBjaS5wZGV2aWNlLT5kZXZpY2VfaWQpKSk7Cj4g ICAKPiAgIAkJCWlmICghYXNpYy0+cGNpLnBkZXZpY2UpIHsKPiBkaWZmIC0tZ2l0IGEvc3JjL3Vt ci5oIGIvc3JjL3Vtci5oCj4gaW5kZXggY2NmYWM1ZC4uMzkxYzVlNyAxMDA2NDQKPiAtLS0gYS9z cmMvdW1yLmgKPiArKysgYi9zcmMvdW1yLmgKPiBAQCAtMTczLDcgKzE3MywxMSBAQCBzdHJ1Y3Qg dW1yX29wdGlvbnMgewo+ICAgCSAgICByZWFkX3NtYywKPiAgIAkgICAgcXVpZXQsCj4gICAJICAg IGZvbGxvd19pYiwKPiAtCSAgICBub19rZXJuZWw7Cj4gKwkgICAgbm9fa2VybmVsLAo+ICsJICAg IHBjaV9kb21haW4sCj4gKwkgICAgcGNpX2J1cywKPiArCSAgICBwY2lfc2xvdCwKPiArCSAgICBw Y2lfZnVuYzsKCkFzIEkgY29tbWVudGVkIGluIHByaXZhdGUgbWF5YmUgc3dpdGNoIHRoaXMgdG8K CnN0cnVjdCBwY2kgewoJaW50IGRvbWFpbiwKCSAgICBidXMsCgkgICAgc2xvdCwKCSAgICBmdW5j Owp9OwoKSW5zaWRlIHRoZSBvcHRpb25zIHN0cnVjdHVyZSBzaW5jZSBpdCB3aWxsIG1ha2UgdGhl IGNvZGUgZWFzaWVyIHRvIHJlYWQgCmFuZCBmb2xsb3cuCgpXaXRoIHRoZSBzdHlsZSBpc3N1ZXMg Zml4ZWQgdXA6IFJldmlld2VkLWJ5OiBUb20gU3QgRGVuaXMgCjx0b20uc3RkZW5pc0BhbWQuY29t Pi4KClRvbQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwph bWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK