Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21E56C6377D for ; Thu, 22 Jul 2021 16:05:01 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FE5861279 for ; Thu, 22 Jul 2021 16:05:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FE5861279 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2E7B482BC3; Thu, 22 Jul 2021 18:04:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="Ty2WvGQ1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8C7A582BC3; Thu, 22 Jul 2021 18:04:56 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2060a.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe59::60a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0794E8022F for ; Thu, 22 Jul 2021 18:04:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michals@xilinx.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lGd7JVbToei35iHIYyA+HyYlfmM5UVBR0dBRLwWXt5is8rgsO0WSWNvmUhbGZ12THlyxh8IYevaZMqMONkeYIiDlUD6uS3acIWU2oExf9Ch7NzOa9menKILTzGXUXssUoIA4x4bpcF3k5hciip1pDAbColfurPHFXXVUPF9iXuaKj7X8TWW2o1HTjFe9kOTg+F/tQO26eTHJ5u/0yVs3LtkaTlq7RmRpsS5zFjiV6cEe4yyw7tzobdCfB3J2uoxUlTyfV6k9J4SN5WmQuXQ+XU/YHbAwOP+h229g7/w+DJ3GWR0l8+k4c/mzqUlJQW/wxEtQn0BCp6bNfaE4dkG+rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=376kKnNu0SHXVMTpRnlaWJc/k+AdYSlHzD0o4T1itlY=; b=FIFKfJz4T0lcGS1YYz3DqyWBv5zS/NF2nQQQ5ixZCcxwc/50dNEN3mxFiVqsszRabDXF5Ad6v53LEjVzkXsL4rVHTDZzk2H3rQvt5/LlYeCEpN+g8dMGKmGFJqop3aYW11bkmD8+QiPEbrYWaMRdqI/jOm8OjXY/WpeX0d10ihufZPw+v/SpUeu8zgfhlZfZ0/2dHqIZsnH++MMv+sm+ufoWDLx2ow8W1SWKbS4xx7QjDTSKwjAvMpfDGKaUUAIFVgjfU0jcJ1OcIt+nlYOXWBBjRCTC2hiuT/aFdFCCAIbXHrG5Dc64xcVMaIVQ9zfNkMN8PuxfgS0Oq5EDBphJCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=ti.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=376kKnNu0SHXVMTpRnlaWJc/k+AdYSlHzD0o4T1itlY=; b=Ty2WvGQ1pwfdlUwo2VelngYNhDc64N9DS8Mc67ccJtRZjOchz8YM5AWG1n16R+YCQv4I9N03PMH2ekulq30Tiz9qwbONajcK5UHs1OfvdeylRqn2kRc863/PIzUslfTTZ+4EKEU7mzncv4p6mL7Yz+l++KqfB9wRW3R4l0xnO+Y= Received: from SN7PR04CA0018.namprd04.prod.outlook.com (2603:10b6:806:f2::23) by SN6PR02MB5566.namprd02.prod.outlook.com (2603:10b6:805:e4::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.29; Thu, 22 Jul 2021 16:04:48 +0000 Received: from SN1NAM02FT0046.eop-nam02.prod.protection.outlook.com (2603:10b6:806:f2:cafe::a7) by SN7PR04CA0018.outlook.office365.com (2603:10b6:806:f2::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.24 via Frontend Transport; Thu, 22 Jul 2021 16:04:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; ti.com; dkim=none (message not signed) header.d=none;ti.com; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT0046.mail.protection.outlook.com (10.97.5.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4352.24 via Frontend Transport; Thu, 22 Jul 2021 16:04:48 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 22 Jul 2021 09:04:42 -0700 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Thu, 22 Jul 2021 09:04:42 -0700 Envelope-to: p.yadav@ti.com, u-boot@lists.denx.de, pbrobinson@gmail.com Received: from [172.30.17.109] (port=59884) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1m6bBi-00079V-BX; Thu, 22 Jul 2021 09:04:42 -0700 Subject: Re: [PATCH] Revert "spi: spi-uclass: Add support to manually relocate spi memory ops" To: Peter Robinson , CC: T Karthik Reddy , Ashok Reddy Soma , Michal Simek , Pratyush Yadav References: <20210722152529.1407976-1-pbrobinson@gmail.com> From: Michal Simek Message-ID: <0e9e0b0d-e363-379b-d63b-e4a3c73213d1@xilinx.com> Date: Thu, 22 Jul 2021 18:04:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210722152529.1407976-1-pbrobinson@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1297c4d4-209b-49aa-d7c9-08d94d2a6e2f X-MS-TrafficTypeDiagnostic: SN6PR02MB5566: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LNWynqkgM9v+JeEfr1NIDoxEYsdD23+MVFpDg1ytKkgFhxRlYUCoq0Eo+P1TNZZJAFX4kxvIAnz2ign41oAGmlQQqD8T3iiQVU2/pfEc0K5s2lXAdTJpZSKxSGyrxBfPeoc0pMJHzZPQoyu8TsVqYT6UAJFFX4AA+QiLDfC1MHzURf/MezfaPugJgB0Hok5TEI0WMPAs6ybwK03N+oHc8hx76Gf8LEJYUregmtQnuvXOFwH9Hnmfz6pX6wLHJFLOTY5jPR/UD24WNaYyWBQOzO7AERV6aur3HXr+4q52UUJS+Hm0G5PaZaY4Sv1P6UtnS1NXHAV2VuQ9CxLXJ2g03OZce6C0jizhC2R740tzSuJ0Z1S45vfokX/6Ln2bYC8JwGR6ugBdXh+6nXNC+WG0hcS6MNq6ViH5nkZn5av5AJSVzPn8pfmUoNSX8eM8nDYCJeX2hRFbRxlWGh7lsz6DZZMbT1xkOFKFEHIweZEPOL0RF6ZUnBYtuVy4Yu6GL2xlF+dRHaFQc7qtcWgy+fmpitAMTUJIzazay7WMBsPn0I3w3hxgSBWP93M7tSkbHzqWHmEr8ZRDXywZW8b3zgAkZqSarYUM1NgF0Fd00H5OmHto6ImSJ6OQTS6ZNjkZot3f2Y8DtU9N+RSP+rqnM3zuP/Qxi28ST39+zzcdVJOcQ5aEPoqs0bs60N25eWjGJ7F6Q7dGglpflt44lkAuUGfrq5uhbf2s7OKMs1cbHE6ilAQmW0pRImkvExDpyb4gvKkY X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch02.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(396003)(376002)(346002)(136003)(39850400004)(36840700001)(46966006)(4326008)(110136005)(36906005)(336012)(82740400003)(82310400003)(36756003)(186003)(356005)(7636003)(47076005)(31696002)(53546011)(26005)(2906002)(8676002)(83380400001)(316002)(70586007)(70206006)(478600001)(36860700001)(44832011)(5660300002)(9786002)(426003)(54906003)(31686004)(2616005)(8936002)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2021 16:04:48.1440 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1297c4d4-209b-49aa-d7c9-08d94d2a6e2f X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0046.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR02MB5566 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 7/22/21 5:25 PM, Peter Robinson wrote: > This reverts commit 346df7d4fa62afc578d820b3a18815eec765074f. > > This patch broke booting Rockchip systems from U-Boot residing on SPI > flash, for at least the Pinebook Pro and Rockpro64, and also confirmed > with the not yet upstream Helios64. > > Signed-off-by: Peter Robinson > Cc: T Karthik Reddy > Cc: Ashok Reddy Soma > Cc: Michal Simek > Cc: Pratyush Yadav > --- > drivers/spi/spi-uclass.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/spi/spi-uclass.c b/drivers/spi/spi-uclass.c > index d867b27806..ec7f4652b3 100644 > --- a/drivers/spi/spi-uclass.c > +++ b/drivers/spi/spi-uclass.c > @@ -11,7 +11,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -200,16 +199,6 @@ static int spi_post_probe(struct udevice *bus) > ops->set_mode += gd->reloc_off; > if (ops->cs_info) > ops->cs_info += gd->reloc_off; > - if (ops->mem_ops) { > - struct spi_controller_mem_ops *mem_ops = > - (struct spi_controller_mem_ops *)ops->mem_ops; > - if (mem_ops->adjust_op_size) > - mem_ops->adjust_op_size += gd->reloc_off; > - if (mem_ops->supports_op) > - mem_ops->supports_op += gd->reloc_off; > - if (mem_ops->exec_op) > - mem_ops->exec_op += gd->reloc_off; > - } > reloc_done++; > } > #endif > This is protected by CONFIG_NEEDS_MANUAL_RELOC which is only enable for m68k and microblaze. I expect rockchip is arm and you should never have this code in your binary. That's why please double check it. Thanks, Michal