Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 458ADC7EE23 for ; Tue, 30 May 2023 00:59:09 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 84BB2846BB; Tue, 30 May 2023 02:59:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kqBY4q8J"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 393B48472F; Tue, 30 May 2023 02:59:01 +0200 (CEST) Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3FA7F846B2 for ; Tue, 30 May 2023 02:58:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=cfsworks@gmail.com Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1b01bd7093aso20481165ad.1 for ; Mon, 29 May 2023 17:58:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685408336; x=1688000336; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=73N7fJ2AtODXxxqIR2E/LOshJeikeeOgmUvgH5FupB0=; b=kqBY4q8JqEZXeloilYjJYkhRlOuQPIWaOXjT08Y1RKsvI5PFRZuZZ2naBq5EKwzwO3 iTHgHp41KTyhgZjhO8rcOxwNa2YcO2AMg8OK4HzZRQkP73hLc5omcY69q9eeVZBYQx9A AdMz+pmHzWNgZJGJz5sdOv0D0lQDDtXMBuI9lMCrwTyG2y+G8H4MD00CaMFsKKAK1auy mxqrbP3jCuB3CzgrMp4Se13Uf3oW65YaWPlhrgbF9gSHOI8A3L6KOPNWAlAm+12SKu3/ D8OKL0z2VL5S8/QJZnVnFOvVfjTP+bdRNQ+g9Hwk/itVGK7Sku6uZQ6yxjfEHJES/MD2 s+lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685408336; x=1688000336; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=73N7fJ2AtODXxxqIR2E/LOshJeikeeOgmUvgH5FupB0=; b=k/iIWxubI+uhFAHzubyM5jV0dot3SQaCGWtUp4vaI/PkX0hysGatY8w08orgYn0Va8 AcAilPpm2vLr4o2Yy/qOLKAqhTVW7tZsS2JEIi/3XFAU/AMcBOAORQKlmIsPs1XvT+7u tVNqJU4LCbQSg2Ugh6p0Cgu2SH0IW4XR/6KvRVtsfhZhwwNgzUT+9CUu+ujSp1AIYQSa X00hBT1gY6ggFi2NJuV3wbtM2Rgy53kETjWEMTsFYwOh++jvC5l5L8NHtkDfTf1L/X6i 8G4Ta6V5kFYpKXDvi9YNwTaCFUSFDy/2UMKq46uxGWc616rwbPOQimM6WT1y8tdf72us umjA== X-Gm-Message-State: AC+VfDz3JcSEaE5o72jch5hihH3hBh3OfJMmw3ksfmM2BdYnIpX6W8VT o+gSZO6mvUzZfBKfQvPYc07NKoCco27/OQ== X-Google-Smtp-Source: ACHHUZ4ibCpCRF81063ZA1GegmBPWbtiR1l5PbuB/vGW/cnIIrvX2cW6XsUTwS8FxXvvuNcg0NJWwQ== X-Received: by 2002:a17:902:d485:b0:1ac:8384:a7fb with SMTP id c5-20020a170902d48500b001ac8384a7fbmr765555plg.66.1685408336446; Mon, 29 May 2023 17:58:56 -0700 (PDT) Received: from [10.64.107.252] (static-198-54-134-172.cust.tzulo.com. [198.54.134.172]) by smtp.gmail.com with ESMTPSA id iz1-20020a170902ef8100b001b034d2e71csm3994674plb.34.2023.05.29.17.58.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 May 2023 17:58:55 -0700 (PDT) Message-ID: <0eba5e2e-b1f2-dd3d-c025-c96c84375b1f@gmail.com> Date: Mon, 29 May 2023 18:58:54 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [RFC PATCH 10/17] clk: sunxi: Add support for the D1 CCU Content-Language: en-US From: Sam Edwards To: Andre Przywara Cc: Maksim Kiselev , u-boot@lists.denx.de References: <20221206004549.29015-1-andre.przywara@arm.com> <20221206004549.29015-11-andre.przywara@arm.com> <9d95e7f4-4ec2-b025-df11-22e2101b1fc9@gmail.com> <20230526115015.33d1cea3@slackpad.lan> <2e81c57f-549a-c655-65cb-bd6bd6b72902@gmail.com> <4d85a769-7a03-dfba-6069-344aed26e889@gmail.com> <20230526230755.2157235e@slackpad.lan> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hey again Andre, On 5/26/23 20:15, Sam Edwards wrote: > My "no success" is Linux stalling indefinitely at: > [    0.123090] smp: Bringing up secondary CPUs ... OK, correction: my "no success" was Linux being unable to access the GIC, so boot was getting stuck. This was because it was running in nonsec mode and the GIC wasn't getting the interrupts moved over into group1. The root cause of THAT was that the T113's CBAR's PERIPHBASE is still 0x01C80000, where the GIC used to be on the older ARM sunxis. Allwinner never updated their ARM cores when they moved the GIC to 0x03020000! Guess we need a `#define CFG_ARM_GIC_BASE_ADDRESS 0x03020000`. Where do you recommend I put that? :) I also think sunxi/psci.c:psci_arch_init needs some cleanup: - It sets GICC_PMR to 0xFF, which should probably be removed because that was already done by `_nonsec_init` - It tries to clear the NS bit of SCR to enter secure mode, but the NS bit is just enabled later in `_secure_monitor`. So that should also be removed because it has no effect. So, I'll have a few PSCI patches for you soon -- once I rest up from all of that GIC debugging, that is! Cheers, Sam