Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E41AEC25B08 for ; Wed, 17 Aug 2022 19:11:06 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EAE6584A40; Wed, 17 Aug 2022 21:11:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=akkea.ca header.i=@akkea.ca header.b="MZGV9+kz"; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="Oc24BXtb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F2B3684A43; Wed, 17 Aug 2022 21:11:01 +0200 (CEST) Received: from node.akkea.ca (li1434-30.members.linode.com [45.33.107.30]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3DB8A84A2A for ; Wed, 17 Aug 2022 21:10:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=angus@akkea.ca Received: from localhost (localhost [127.0.0.1]) by node.akkea.ca (Postfix) with ESMTP id 7ED644E2006; Wed, 17 Aug 2022 19:10:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1660763457; bh=Ci4UEuXq4tnTf/u8NlqG9n703QrokMTlKEoh2k18p/Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=MZGV9+kzDk38u8cr65k9hywFoImLIgXC29yYjPDIkzJkxAPRpmQIMcXNx15nU936A 7kq16CFofMdSibHHgPadET0beLzu8fF1Bkbcmq1cdjLeSegtXoFDft/hKLvT7j/Ndk nzaLwrsbGKAjG7ffdKVWShiJw4Fvhx6K9CTUE+aE= Received: from node.akkea.ca ([127.0.0.1]) by localhost (mail.akkea.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5B4dYphSjKcx; Wed, 17 Aug 2022 19:10:56 +0000 (UTC) Received: from www.akkea.ca (localhost [127.0.0.1]) by node.akkea.ca (Postfix) with ESMTP id E1AFF4E2003; Wed, 17 Aug 2022 19:10:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1660763456; bh=Ci4UEuXq4tnTf/u8NlqG9n703QrokMTlKEoh2k18p/Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=Oc24BXtb3NszNgYgEmET3PAm8feyE2cnLILOILrFenb1jXpSd9vOZH6tUceSzPVUV thiI/j2Rbfq2+bqNLuUFDEvMldpD0yUwEKHCMj9b+pMu0/+15GAMo+8ggA/xoLikIR BIg1dVcXcj/OoOxXk1LpTcyoyx1erPoQRL00cS/Q= MIME-Version: 1.0 Date: Wed, 17 Aug 2022 12:10:56 -0700 From: Angus Ainslie To: Fabio Estevam Cc: sbabic@denx.de, u-boot@lists.denx.de, uboot-imx@nxp.com, peng.fan@nxp.com, marcel.ziswiler@toradex.com, t.remmet@phytec.de, tharvey@gateworks.com, jagan@amarulasolutions.com, iliev@ronetix.at, kernel@puri.sm, alpernebiyasak@gmail.com, Sebastian Krzyszkowiak Subject: Re: [PATCH v7] board: purism: add the Purism Librem5 phone In-Reply-To: References: <20220807160205.196174-1-angus@akkea.ca> Message-ID: <0ef254104fa65a633fd8bf53af5bf77c@akkea.ca> X-Sender: angus@akkea.ca User-Agent: Roundcube Webmail/1.3.17 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 2022-08-13 07:53, Fabio Estevam wrote: > Hi Angus, > > On Sun, Aug 7, 2022 at 1:02 PM Angus Ainslie wrote: >> >> Initial commit of Librem5 u-boot and SPL >> >> All of the pre-requisite patches for this board are now upstream. >> >> Changes since v6: >> >> Move migrated symbols >> Rebase onto latest u-boot-imx >> >> Changes since v5: >> >> Proper handling of the Display Port firmware for CI builds >> Update the DP section of the docs >> >> Changes since v4: >> >> Include imx8mq-u-boot.dtsi instead of adding a new copy >> >> Changes since v3: >> >> Dropped unused MMCROOT >> Rebased on u-boot-imx >> >> Changes since v2: >> >> Cleanup Kconfig symbols used in librem5.h >> Cleanup various checkpatch issues >> Drop some un-used functions >> >> Changes since v1: >> >> Merged patches into a monolithic board patch >> Using DM drivers for devices in u-boot >> Added USB storage support for uSD rootfs >> Dropped many SPL_BUILD guarded define's >> Fixed documentation index >> >> Signed-off-by: Angus Ainslie >> Co-developed-by: Sebastian Krzyszkowiak >> >> Signed-off-by: Sebastian Krzyszkowiak > > Patch looks good: > > Reviewed-by: Fabio Estevam > > I would suggest removing the changes history from the commit log and > put this information below the --- line. Thanks for the review Fabio. I'll try and resend it early next week with that fixed. Does anyone know if the CI is passing with this patch ?