From: "plaisthos (Code Review)" Date: Tue, 1 Apr 2025 08:29:09 +0000 References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <0f0e384b4a08b4c0752a0514b19cebe8abe2f126-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="0QnPjE3jup4="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: openvpn-devel --0QnPjE3jup4= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/927?usp=3Demail to review the following change. Change subject: Use SSL_get0_peer_signature_name instead of SSL_get_peer_si= gnature_nid ...................................................................... Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid SSL_get0_peer_signature_name return a string instead of hardcoded NIDs that do not work with provider provided signatures or the new PQ signatures introduced in OpenSSL 3.5. Remove also the comment that was added earlier that says that there no proper API replacement for SSL_get_peer_signature_nid yet as OpenSSL 3.5.0 has now introduced it. Change-Id: I2bc782ceebcc91a8dc8ada0bb72ac042be46cad6 Signed-off-by: Arne Schwabe --- M src/openvpn/openssl_compat.h M src/openvpn/ssl_openssl.c 2 files changed, 34 insertions(+), 11 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/27/927/1 diff --git a/src/openvpn/openssl_compat.h b/src/openvpn/openssl_compat.h index 3e3b406..e2bd9bf 100644 --- a/src/openvpn/openssl_compat.h +++ b/src/openvpn/openssl_compat.h @@ -173,4 +173,30 @@ #endif /* OPENSSL_VERSION_NUMBER < 0x30000000L */ +#if OPENSSL_VERSION_NUMBER < 0x30500000 && (!defined(LIBRESSL_VERSION_NUMB= ER) || LIBRESSL_VERSION_NUMBER > 0x3050400fL) +static inline int +SSL_get0_peer_signature_name(SSL *ssl, const char **sigalg) +{ + int peer_sig_nid; + if (SSL_get_peer_signature_nid(ssl, &peer_sig_nid) + && peer_sig_nid !=3D NID_undef) + { + *sigalg =3D OBJ_nid2sn(peer_sig_nid); + return 1; + } + return 0; +} +#elif defined(LIBRESSL_VERSION_NUMBER) && LIBRESSL_VERSION_NUMBER <=3D 0x3= 050400fL +/* The older LibreSSL version do not implement any variant of getting the = peer + * signature */ +static inline int +SSL_get0_peer_signature_name(const SSL *ssl, const char **sigalg) +{ + *sigalg =3D NULL; + return 0; +} +#endif /* if OPENSSL_VERSION_NUMBER < 0x30500000 && (!defined(LIBRESSL_VER= SION_NUMBER) || LIBRESSL_VERSION_NUMBER > 0x3050400fL) */ + + + #endif /* OPENSSL_COMPAT_H_ */ diff --git a/src/openvpn/ssl_openssl.c b/src/openvpn/ssl_openssl.c index aad79a4..23b0266 100644 --- a/src/openvpn/ssl_openssl.c +++ b/src/openvpn/ssl_openssl.c @@ -2454,20 +2454,17 @@ static void print_peer_signature(SSL *ssl, char *buf, size_t buflen) { - int peer_sig_nid =3D NID_undef, peer_sig_type_nid =3D NID_undef; - const char *peer_sig =3D "unknown"; + int peer_sig_type_nid =3D NID_undef; + const char *peer_sig_unknown =3D "unknown"; + const char *peer_sig =3D peer_sig_unknown; const char *peer_sig_type =3D "unknown type"; - /* Even though these methods use the deprecated NIDs instead of using - * string as new OpenSSL APIs do, there seem to be no API that replaces - * it yet */ -#if !defined(LIBRESSL_VERSION_NUMBER) || LIBRESSL_VERSION_NUMBER > 0x30504= 00fL - if (SSL_get_peer_signature_nid(ssl, &peer_sig_nid) - && peer_sig_nid !=3D NID_undef) + const char *signame =3D NULL; + SSL_get0_peer_signature_name(ssl, &signame); + if (signame) { - peer_sig =3D OBJ_nid2sn(peer_sig_nid); + peer_sig =3D signame; } -#endif #if !defined(LIBRESSL_VERSION_NUMBER) \ || (defined(LIBRESSL_VERSION_NUMBER) && LIBRESSL_VERSION_NUMBER >=3D 0= x3090000fL) @@ -2480,7 +2477,7 @@ } #endif - if (peer_sig_nid =3D=3D NID_undef && peer_sig_type_nid =3D=3D NID_unde= f) + if (peer_sig =3D=3D peer_sig_unknown && peer_sig_type_nid =3D=3D NID_u= ndef) { return; } -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/927?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2bc782ceebcc91a8dc8ada0bb72ac042be46cad6 Gerrit-Change-Number: 927 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-MessageType: newchange --0QnPjE3jup4= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld.

plaisthos would like flichtenheld to review this change.

Vi= ew Change

Use SSL_get0_peer_signature_name instead of SSL_get_peer_sign=
ature_nid

SSL_get0_peer_signature_name return a string instead of ha= rdcoded NIDs that
do not work with provider provided signatures or the n= ew PQ signatures
introduced in OpenSSL 3.5.

Remove also the comme= nt that was added earlier that says that there no
proper API replacement= for SSL_get_peer_signature_nid yet as OpenSSL
3.5.0 has now introduced = it.

Change-Id: I2bc782ceebcc91a8dc8ada0bb72ac042be46cad6
Signed-o= ff-by: Arne Schwabe <arne@...1227...>
---
M src/openvpn/openssl= _compat.h
M src/openvpn/ssl_openssl.c
2 files changed, 34 insertions(= +), 11 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openv=
pn refs/changes/27/927/1
diff --git a/src/openvpn/openssl_compat.h =
b/src/openvpn/openssl_compat.h
index 3e3b406..e2bd9bf 10064= 4
--- a/src/openvpn/openssl_compat.h
+++ b/= src/openvpn/openssl_compat.h
@@ -173,4 +173,30 @@
#endif /* OPENSSL_VERSION_NUMBER < 0x30000000L= */

+#if OPENSSL_VERSION_NUMBER < 0x30500000 && (!defined(LIBRESSL_= VERSION_NUMBER) || LIBRESSL_VERSION_NUMBER > 0x3050400fL)
+static inline int
+SSL_get0_peer_signature_name(SSL *ss= l, const char **sigalg)
+{
+ int peer_s= ig_nid;
+ if (SSL_= get_peer_signature_nid(ssl, &peer_sig_nid)
+ && peer_sig_nid !=3D NID_undef)<= /span>
+ {
+ *sigalg =3D OBJ_nid2sn(pee= r_sig_nid);

+ = return 1;
+ }

+ return 0;
= +}
+#elif defined(LIBRESSL_VERSION_NUMBER) &&= ; LIBRESSL_VERSION_NUMBER <=3D 0x3050400fL
+/* The older LibreSSL version do not implement an= y variant of getting the peer
+ * signature */
+static inline int
+SSL_get0_peer_signature_name(const SSL *ssl, const char **sigalg)
+{
+ *sigalg =3D NULL;
+ return 0;
+}
+#endif /* if OPENSSL_VERSION_NUMBER < 0x30500000 && = (!defined(LIBRESSL_VERSION_NUMBER) || LIBRESSL_VERSION_NUMBER > 0x305040= 0fL) */
+
<= span style=3D"color: hsl(120, 100%, 40%);">+

+
#endif /* OPENSSL_COMPAT_H_ */
diff --git a/src/openvpn/ssl_openssl.c b/src/openvpn/ssl_ope= nssl.c
index aad79a4..23b0266 100644
--- a/= src/openvpn/ssl_openssl.c
+++ b/src/openvpn/ssl_openssl.c
@@ -2454,20 +2454,17 @@
static void<= br> print_peer_signature(SSL *ssl, char *buf, size_t buflen) {
- int pee= r_sig_nid =3D NID_undef, peer_sig_type_nid =3D NID_undef;
- const char *peer_sig =3D "unkn= own";
+ int p= eer_sig_type_nid =3D NID_undef;
+ const char *peer_sig_unknown =3D "unknown";
+ const char *peer_sig = =3D peer_sig_unknown;
const char *peer_sig_type =3D &q= uot;unknown type";

- /* Even though these methods use the deprecated NID= s instead of using
- = * string as new OpenSSL APIs do, there seem to be no API that replaces
- * it yet */<= br>-#if !defined(LIBRESSL_VERSION= _NUMBER) || LIBRESSL_VERSION_NUMBER > 0x3050400fL
- if (SSL_get_peer_signature_nid(ssl, &am= p;peer_sig_nid)
- = && peer_sig_nid !=3D NID_undef)
+ const char *signame =3D NULL;
+ SSL_get0_peer_signature_name(ssl, &= amp;signame);
+ if= (signame)
{
- peer_sig =3D OBJ_nid2sn(peer_sig_nid);
+ peer_sig =3D signame;=
}
-#endi= f

#if !defined(LIBRESSL_VERSION_NUMBER) = \
|| (defined(LIBRESSL_VERSION_NUMBER) && LIBR= ESSL_VERSION_NUMBER >=3D 0x3090000fL)
@@ -2480,7 +2477,7= @@
}
#endif
=
- if (peer_sig_nid =3D=3D = NID_undef && peer_sig_type_nid =3D=3D NID_undef)
+ if (peer_sig =3D=3D peer_sig_unkno= wn && peer_sig_type_nid =3D=3D NID_undef)
{
return;
}

To view, visit change 927. To unsubscribe, or for help writing ma= il filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2bc782ceebcc91a8dc8ada0bb72= ac042be46cad6
Gerrit-Change-Number: 927
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-MessageType: newchange
--0QnPjE3jup4=--