From: Sander Eikelenboom Subject: Re: [GIT PULL] (xen) stable/for-jens-3.14 : NFO: trying to register non-static key. the code is fine but needs lockdep annotation. Date: Tue, 11 Feb 2014 21:21:57 +0100 Message-ID: <1009282985.20140211212157@eikelenboom.it> References: <20140210184412.GA18198@phenom.dumpdata.com> <20140210195402.GA3924@kernel.dk> <771950784.20140211165215@eikelenboom.it> <20140211155650.GA23026@phenom.dumpdata.com> <1542261541.20140211170750@eikelenboom.it> <52FA6072.40908@citrix.com> <52FA6352.1010403@citrix.com> <52FA68AE.6070608@citrix.com> <52FA6A44.6050003@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <52FA6A44.6050003@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel Cc: Jens Axboe , xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, mrushton@amazon.com, msw@amazon.com, boris.ostrovsky@oracle.com, =?iso-8859-1?Q?Roger_Pau_Monn=E9?= List-Id: xen-devel@lists.xenproject.org Tuesday, February 11, 2014, 7:21:56 PM, you wrote: > On 11/02/14 18:15, Roger Pau Monn=E9 wrote: >> On 11/02/14 18:52, David Vrabel wrote: >>> = >> That would mean that unmap_purged_grants would no longer be static and = >> I should also add a prototype for it in blkback/common.h, which is kind = >> of ugly IMHO. > But less ugly than initializing work with a NULL function, IMO. >> commit 980e72e45454b64ccb7f23b6794a769384e51038 >> Author: Roger Pau Monne >> Date: Tue Feb 11 19:04:06 2014 +0100 >> = >> xen-blkback: init persistent_purge_work work_struct >> = >> Initialize persistent_purge_work work_struct on xen_blkif_alloc (and >> remove the previous initialization done in purge_persistent_gnt). Th= is >> prevents flush_work from complaining even if purge_persistent_gnt has >> not been used. >> = >> Signed-off-by: Roger Pau Monn=E9 > Reviewed-by: David Vrabel And a Tested-by: Sander Eikelenboom Thanks ! > Thanks. > David