Message-ID: <102833f9-35a9-b512-8e3b-d0eeecec138c@...1227...> Date: Mon, 24 Oct 2022 14:10:11 +0200 MIME-Version: 1.0 Content-Language: en-GB References: <20221023195105.31714-1-selva.nair@...277...> From: Arne Schwabe In-Reply-To: <20221023195105.31714-1-selva.nair@...277...> Subject: Re: [Openvpn-devel] [PATCH] Ensure --auth-nocache is handled during renegotiation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: selva.nair@...277..., openvpn-devel@lists.sourceforge.net Am 23.10.22 um 21:51 schrieb selva.nair@...277...: > From: Selva Nair > > Currently, clearing auth_user_pass struct is delayed until > push-reply processing to support auth-token. This results in > username/password not purged after renegotiations that may > not accompany any pushed tokens -- say, when auth-token is not > in use. > > Fix by always clearing auth_user_pass soon after it is used, > instead of delaying the purge as in pre-token days. But, when > "pull" is true, retain the username in auth_token in anticipation > of a token that may or may not arrive later. > > Remove ssl_clean_user_pass() as there is no delayed purge any > longer -- auth-nocache handling is now done immediately after > writing username/password to the send-buffer. Acked-By: Arne Schwabe