Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9E93C433EF for ; Mon, 21 Mar 2022 14:05:58 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KMbxd3XrNz30Mg for ; Tue, 22 Mar 2022 01:05:57 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZjKWk5Z7; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=N6gjqzba; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=dhowells@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZjKWk5Z7; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=N6gjqzba; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KMbxY5rxJz2yxV for ; Tue, 22 Mar 2022 01:05:53 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647871550; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vMaQn1UtCu/LKFHSjM1uVJme2UZeiOPTmAAuYyikU+M=; b=ZjKWk5Z7QedUVITo3wigTlcyMralMRu0irKZCArEkk6j2tKr+OW/JGDmvN8dnaMR+oqAaK JcLcIWWJTtQ3vP8M6aTzvRPgf22dtL+3mtZrpkKQLpGhKkwkm6lHh/p5+ztyRMqIgqbFqh 559dGg3H8JHeATso5gEyzCqxx5be54Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647871551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vMaQn1UtCu/LKFHSjM1uVJme2UZeiOPTmAAuYyikU+M=; b=N6gjqzbat25VOVf9uXtekTu4qZgtC3vnpk6c2bxdrJ8UlqeogW0pVYMUOIbmtIuzfrZvPm pOAbLWrav4M5BB7hptSIDp0uGijBiARU1icdnoBF8yxpLnxqPpedzPTexV+GNkyWpO4zsC 0TXVzOzNml0xa824U5XGoiqnTnaDgVc= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-352-jh6NgncOPGSypXqW--5J5g-1; Mon, 21 Mar 2022 10:05:47 -0400 X-MC-Unique: jh6NgncOPGSypXqW--5J5g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B525C1C05AFF; Mon, 21 Mar 2022 14:05:46 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 942011410F35; Mon, 21 Mar 2022 14:05:44 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20220316131723.111553-7-jefflexu@linux.alibaba.com> References: <20220316131723.111553-7-jefflexu@linux.alibaba.com> <20220316131723.111553-1-jefflexu@linux.alibaba.com> To: Jeffle Xu Subject: Re: [PATCH v5 06/22] cachefiles: implement on-demand read MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1029511.1647871543.1@warthog.procyon.org.uk> Date: Mon, 21 Mar 2022 14:05:43 +0000 Message-ID: <1029512.1647871543@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-erofs@lists.ozlabs.org, willy@infradead.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, joseph.qi@linux.alibaba.com, linux-cachefs@redhat.com, gregkh@linuxfoundation.org, linux-fsdevel@vger.kernel.org, luodaowen.backend@bytedance.com, gerry@linux.alibaba.com, torvalds@linux-foundation.org Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" Jeffle Xu wrote: > + { "cread", cachefiles_ondemand_cread }, Rather than adding the cread command, would it be better to use an ioctl on the anon fd as the /dev/cachefiles write op is serialised? > + /* Stop enqueuig request when daemon closes anon_fd prematurely. */ "Enqueuing" David