From: "cron2 (Code Review)" Date: Thu, 9 Jan 2025 15:00:02 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., samuli@...515..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <10460c9c96d95c9b1c3f337200fd0f3dfb74cf51-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="tyXVWQfZgB4="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Add lwip support to t_server_null List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mattock Cc: flichtenheld , plaisthos , openvpn-devel --tyXVWQfZgB4= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: mattock, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/811?usp=3Demail ) Change subject: Add lwip support to t_server_null ...................................................................... Patch Set 8: (2 comments) File tests/t_server_null_client.sh: http://gerrit.openvpn.net/c/openvpn/+/811/comment/5bcb7010_986383b7 : PS8, Line 138: server_pid=3D$(cat "$i.pid" 2> /dev/null) this looks like an unrelated change...? http://gerrit.openvpn.net/c/openvpn/+/811/comment/0527ab4d_5f6a61dd : PS8, Line 173: $RUN_SUDO rm -f ./*.ips running `sudo rm -f` gives me the creeps, tbh, though I see no obvious way = this could explode (today). `sudo` is not needed here, anyway, as we have = write access to the directory so we can remove whatever files there are. `= -f` is needed (because non-writeable files might otherwise make rm start as= king). -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/811?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie63f302402f469c3aa48ac146ca6b8c029f0d250 Gerrit-Change-Number: 811 Gerrit-PatchSet: 8 Gerrit-Owner: mattock Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: mattock Gerrit-Comment-Date: Thu, 09 Jan 2025 15:00:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --tyXVWQfZgB4= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: mattock, plaisthos.

View C= hange

2 comments:

    =
  • File tests/t_server_null_client.sh:=

    • Patch Set #8, Line= 138: server_pi= d=3D$(cat "$i.pid" 2> /dev/null)

      this looks like an unrelated change= ...?

    • Patch Set #8, Line 173: $RUN_SUDO rm -f ./*.ips

      running `sudo rm -f` gives me the = creeps, tbh, though I see no obvious way this could explode (today). `sudo= ` is not needed here, anyway, as we have write access to the directory so w= e can remove whatever files there are. `-f` is needed (because non-writeab= le files might otherwise make rm start asking).

T= o view, visit change 811. To unsubscribe, or for help writing mail filters, visi= t settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie63f302402f469c3aa48ac146ca= 6b8c029f0d250
Gerrit-Change-Number: 811
Gerrit-PatchSet: 8
Gerrit-Owner: mattock <samuli@...515...>=
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: mattock <samuli@...515...= >
Gerrit-Comment-Date: Thu, 09 Jan 2025 15:00:02= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--tyXVWQfZgB4=--