Received: from eggs.gnu.org ([2001:4830:134:3::10]:37558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1HB7-0000I8-Q8 for qemu-devel@nongnu.org; Tue, 24 Nov 2015 12:14:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1HB4-00080Y-Kn for qemu-devel@nongnu.org; Tue, 24 Nov 2015 12:14:53 -0500 Received: from mx5-phx2.redhat.com ([209.132.183.37]:42388) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1HB4-00080R-EP for qemu-devel@nongnu.org; Tue, 24 Nov 2015 12:14:50 -0500 Date: Tue, 24 Nov 2015 12:14:45 -0500 (EST) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <1049290820.16562436.1448385285586.JavaMail.zimbra@redhat.com> In-Reply-To: <1448384789-14830-3-git-send-email-armbru@redhat.com> References: <1448384789-14830-1-git-send-email-armbru@redhat.com> <1448384789-14830-3-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.5 2/5] qemu-doc: Fix ivshmem usage example with shm=... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: marcandre lureau , claudio fontana , qemu-devel@nongnu.org ----- Original Message ----- > The example suggests you can omit "shm". This isn't true; you must > specify exactly one of "shm", "chardev", "memdev". Fix it. >=20 > Signed-off-by: Markus Armbruster Reviewed-by: Marc-Andr=C3=A9 Lureau > --- > qemu-doc.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/qemu-doc.texi b/qemu-doc.texi > index c9b7069..68ca075 100644 > --- a/qemu-doc.texi > +++ b/qemu-doc.texi > @@ -1256,7 +1256,7 @@ zero-copy communication to the application level of= the > guests. The basic > syntax is: > =20 > @example > -qemu-system-i386 -device ivshmem,size=3D@var{size}[,shm=3D@var{shm-name}= ] > +qemu-system-i386 -device ivshmem,size=3D@var{size},shm=3D@var{shm-name} > @end example > =20 > If desired, interrupts can be sent between guest VMs accessing the same > shared > -- > 2.4.3 >=20 >=20