Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1itrDl-0006Sb-2y for mharc-qemu-trivial@gnu.org; Tue, 21 Jan 2020 05:57:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38877) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itrDg-0006SH-DD for qemu-trivial@nongnu.org; Tue, 21 Jan 2020 05:57:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itrDd-0006z2-1B for qemu-trivial@nongnu.org; Tue, 21 Jan 2020 05:57:16 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:53886 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1itrDc-0006yc-U1 for qemu-trivial@nongnu.org; Tue, 21 Jan 2020 05:57:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579604232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=36eSsXbt1PCk0ZqLu/KWTYAoirFOz3wbJa5qGq/YBZ8=; b=fqkVpebTaF0Ux0fWsiq32Oz6X5Kuog3gOra7JHvVb5sysNKoEN8ft6DzPcCkBrW8vENLrh uzM1lg2R164wGaT2/Gws5ZonxcmkCRiFrq9sKYZe/Ngr6ueY8dKY2ivh0AxtBjb+EXMA2b vsehdflSB8vN2nfxQleVHtgFjgphDzg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-432-HyeibIlOMzi73y7khP9UOg-1; Tue, 21 Jan 2020 05:57:09 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 17B768C3C82; Tue, 21 Jan 2020 10:57:08 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ED0C45DA70; Tue, 21 Jan 2020 10:57:07 +0000 (UTC) Received: from zmail17.collab.prod.int.phx2.redhat.com (zmail17.collab.prod.int.phx2.redhat.com [10.5.83.19]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id ACFF018095FF; Tue, 21 Jan 2020 10:57:06 +0000 (UTC) Date: Tue, 21 Jan 2020 05:57:06 -0500 (EST) From: Miroslav Rezanina To: =?utf-8?Q?C=C3=A9dric?= Le Goater Cc: Thomas Huth , qemu-devel@nongnu.org, peter maydell , Andrew Jeffery , Joel Stanley , qemu-trivial@nongnu.org Message-ID: <105074722.2949784.1579604226517.JavaMail.zimbra@redhat.com> In-Reply-To: References: <07957dcab31f65de3dd30efa91e6b9152ac79879.1579598240.git.mrezanin@redhat.com> Subject: Re: [PATCH 2/2] aspeed/i2c: Prevent uninitialized warning MIME-Version: 1.0 X-Originating-IP: [10.40.204.25, 10.4.195.24] Thread-Topic: aspeed/i2c: Prevent uninitialized warning Thread-Index: UFtmhiX1gQxBEhJcRpb5d5AmLeqFCQ== X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: HyeibIlOMzi73y7khP9UOg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jan 2020 10:57:19 -0000 ----- Original Message ----- > From: "C=C3=A9dric Le Goater" > To: "Thomas Huth" , mrezanin@redhat.com, qemu-devel@non= gnu.org > Cc: "peter maydell" , "Andrew Jeffery" , "Joel Stanley" , > qemu-trivial@nongnu.org > Sent: Tuesday, January 21, 2020 11:44:14 AM > Subject: Re: [PATCH 2/2] aspeed/i2c: Prevent uninitialized warning >=20 > On 1/21/20 11:02 AM, Thomas Huth wrote: > > On 21/01/2020 10.28, mrezanin@redhat.com wrote: > >> From: Miroslav Rezanina > >> > >> Compiler reports uninitialized warning for cmd_flags variable. > >> > >> Adding NULL initialization to prevent this warning. > >> > >> Signed-off-by: Miroslav Rezanina > >> --- > >> hw/i2c/aspeed_i2c.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c > >> index 2da04a4..445182a 100644 > >> --- a/hw/i2c/aspeed_i2c.c > >> +++ b/hw/i2c/aspeed_i2c.c > >> @@ -400,7 +400,7 @@ static bool aspeed_i2c_check_sram(AspeedI2CBus *bu= s) > >> =20 > >> static void aspeed_i2c_bus_cmd_dump(AspeedI2CBus *bus) > >> { > >> - g_autofree char *cmd_flags; > >> + g_autofree char *cmd_flags =3D NULL; > >> uint32_t count; > >> =20 > >> if (bus->cmd & (I2CD_RX_BUFF_ENABLE | I2CD_RX_BUFF_ENABLE)) { > >=20 > > Reviewed-by: Thomas Huth > >=20 > > ... maybe someone with enough Perl-foo (i.e. not me ;-)) should add a > > check to our check_patch.pl script so that it complains when new code i= s > > introduced that uses g_autofree without initializing the variable... >=20 > weird. The cmd_flags variable is assigned just after and used > in a trace. >=20 As g_autofree is used, variable has to be initialized otherwise will compil= er complain even in the case we write to variable immediately after. Mirek > C. >=20 >=20 --=20 Miroslav Rezanina Software Engineer - Virtualization Team Maintainer