From: Shaya Potter Subject: Re: changing permission()/vfs_permission... to work on dentry Date: 28 May 2003 18:34:32 -0400 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <1054161272.9349.50.camel@zaphod> References: <1054154587.9356.15.camel@zaphod> <20030528214822.GF14138@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org Return-path: Received: from opus.cs.columbia.edu ([128.59.20.100]:49332 "EHLO opus.cs.columbia.edu") by vger.kernel.org with ESMTP id S261279AbTE1WVx (ORCPT ); Wed, 28 May 2003 18:21:53 -0400 To: viro@parcelfarce.linux.theplanet.co.uk In-Reply-To: <20030528214822.GF14138@parcelfarce.linux.theplanet.co.uk> List-Id: linux-fsdevel.vger.kernel.org On Wed, 2003-05-28 at 17:48, viro@parcelfarce.linux.theplanet.co.uk wrote: > On Wed, May 28, 2003 at 04:43:08PM -0400, Shaya Potter wrote: > > I've gone through the entire fs/* vfs layer picking out every use of > > permission to see if it can easily use the dentry instead, and it can > > (list below showing that the dentry is readily available in every vfs > > case) > > Why not grep over the entire tree? That would've immediately show > at least 6 cases when we do _not_ have a dentry; 2 of them rather > nasty (floppy_open() in floppy.c/floppy98.c). well, floppy's aren't so much what I'm interested in, but that's a good point. either the vfs would have to be changed or the permission/inode interface would have to stay around. floppy_open (I believe) is just called from the filp, which has access to the dentry, so it could be passed in, but I'm not sure if restructering all that would be worthwhile. > The real question is what the hell would you _do_ with dentry? > > 1) It's worthless without vfsmount - alone it does *NOT* determine the > pathname. the kernel can always know the real vfsmount. if you care about within a specific context, can use that too. > 2) assuming that you've somehow got both vfsmount and dentry (and thus > enough information to find the pathnam), what will you do with it? > Anything that requires ->i_sem on ancestors is not an option - quite > often they will be already locked. Moreover, there is no warranty that > pathname won't change right under you - starting with the parent of > your dentry. need to think more about the issues you just brought up, the path changing is what I'm mostly concerned about. > > IOW, what's the real goal? Well, I want to be able to create a SubDomain like system that allows one to run a process within a context that lets you specify an extra layer of permissions on top of the underlying fs. so my permission() would be something like if ( (context = find_context(current->pid)) != NULL ) { d_path(some denty, some vfsmount, scratch, size); to get full path and_mode = get_mode(context, full_path); real mode = inode mode & and_mode; } else just do normal code. I don't actually want this within the kernel, but be able to do it via fs (aka module) support. Basically the argument is that one has more information from the dentry than just from the inode, and therefore it would make sense to expose that information, as then things like modules could make use of it. anyways, if there's a better way to do this, I'm all ears. I'm also willing to do the restructuring myself, if you think there's some benefit in it.