From: Pat LaVarre Subject: Re: balloc free bit already set and byte minus one Date: 10 Dec 2003 10:17:28 -0700 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <1071076648.26823.7.camel@patibmrh9> References: <1070586082.10213.5.camel@patibmrh9> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from email-out1.iomega.com ([147.178.1.82]:21952 "EHLO email.iomega.com") by vger.kernel.org with ESMTP id S263667AbTLJRRq (ORCPT ); Wed, 10 Dec 2003 12:17:46 -0500 Received: from royntex01.iomegacorp.com (unknown [147.178.90.120]) by email.iomega.com (Postfix) with ESMTP id CF7491EC6 for ; Wed, 10 Dec 2003 10:17:45 -0700 (MST) To: linux-fsdevel@vger.kernel.org In-Reply-To: <1070586082.10213.5.camel@patibmrh9> List-Id: linux-fsdevel.vger.kernel.org > > UDF-fs DEBUG fs/udf/balloc.c:192:udf_bitmap_free_blocks: bit 16383 already set > > UDF-fs DEBUG fs/udf/balloc.c:193:udf_bitmap_free_blocks: byte=ffffffff > ... mean trouble ...trying to free a block twice... Reading fs/udf/balloc.c now, ... 1) CONFIG_SMP and CONFIG_PREEMPT may break less often since much work occurs inside { lock_super(sb); ... unlock_super(sb); }. 2) --- fs/udf/balloc.c: #define udf_clear_bit(nr,addr) ext2_clear_bit(nr,addr) #define udf_set_bit(nr,addr) ext2_set_bit(nr,addr) #define udf_test_bit(nr, addr) ext2_test_bit(nr, addr) --- Possibly these mean mess with the bitmask (1 << nr) at byte-aligned (addr) and return whether that bitmask was nonzero. By contrast, dropping the udf_ or ext2_ prefixes may contract for a long-aligned address e.g. via include/asm-ppc/bitops.h Pat LaVarre