Date: Mon, 25 Apr 2022 15:19:53 +0200 (CEST) From: Frank Lichtenheld Message-ID: <1073556762.338511.1650892793663@...2642...> In-Reply-To: References: <20220422134038.3801239-4-arne@...1227...> <20220425122709.4148015-1-arne@...1227...> <1819498256.337104.1650892135929@...2642...> MIME-Version: 1.0 Subject: Re: [Openvpn-devel] [PATCH v2] Move pre decrypt lite check to its own function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit To: Arne Schwabe , openvpn-devel@lists.sourceforge.net Acked-By: Frank Lichtenheld > Arne Schwabe hat am 25.04.2022 15:12 geschrieben: > Am 25.04.22 um 15:08 schrieb Frank Lichtenheld: [...] > > You could replace four lines with one: > > > > return tls_pre_decrypt_lite(m->top.c2.tls_auth_standalone, &m->top.c2.from, &m->top.c2.buf)); > > > > But that might not make sense due to changes in later patches? Haven't checked. > > > > The function grows to a 70 line function over the course of the patches. :) Fair enough. Acked. Regards, -- Frank Lichtenheld