From: "its_Giaan (Code Review)" Date: Thu, 17 Oct 2024 14:50:31 +0000 In-Reply-To: References: Reply-To: gianmarco@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., a@...2181... Message-ID: <10761432f72fe25425cb7c9583929d3332ca30c9-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="zzOSbbzbSdE="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: allow user to specify 'local' multiple times in config files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , plaisthos , openvpn-devel --zzOSbbzbSdE= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, ordex, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/436?usp=3Demail ) Change subject: allow user to specify 'local' multiple times in config files ...................................................................... Patch Set 6: (6 comments) File doc/man-sections/link-options.rst: http://gerrit.openvpn.net/c/openvpn/+/436/comment/e41c0651_4dde7880 : PS5, Line 114: 0.0.0.0 or :: can be used to specifically open a socket. > Sentence does end in the middle? Done http://gerrit.openvpn.net/c/openvpn/+/436/comment/5a0ba867_50a05ad8 : PS5, Line 117: or name > Should probably say "default TCP/UDP port number" or something like that = and mention that this can b [=E2=80=A6] Done File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/436/comment/bea38f19_4d89f447 : PS5, Line 2400: * Sanity check on daemon mode > Not sure what daemon is supposed to mean in this context? Done http://gerrit.openvpn.net/c/openvpn/+/436/comment/a4fc0da7_d28cb303 : PS5, Line 3198: if (ce->proto =3D=3D PROTO_UDP && ce->socks_proxy_serve= r && !ce->local_list && !ce->local_port_defined && !ce->bind_defined) > Should use need_bind to simplify the condition. Done http://gerrit.openvpn.net/c/openvpn/+/436/comment/08d0b545_36ce02f5 : PS5, Line 3327: options_postprocess_mutate_le(struct options *o, struct loc= al_entry *le) > should maybe take o->ce as input and not o, just to make clear that it do= esn't need the rest? Done File src/openvpn/socket.c: http://gerrit.openvpn.net/c/openvpn/+/436/comment/f094b608_24a1894e : PS5, Line 358: options > either this should use "l" or the definition of "l" should be removed com= pletely. Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/436?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4d1c96662c5a8c750d883e3b20adde09529e2764 Gerrit-Change-Number: 436 Gerrit-PatchSet: 6 Gerrit-Owner: ordex Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: its_Giaan Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: ordex Gerrit-Comment-Date: Thu, 17 Oct 2024 14:50:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment --zzOSbbzbSdE= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, ordex, plaisthos. <= /p>

View C= hange

6 comments:

To view, = visit cha= nge 436. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d1c96662c5a8c750d883e3b20a= dde09529e2764
Gerrit-Change-Number: 436
Gerrit-PatchSet: 6
Gerrit-Owner: ordex <a@...2181...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: its_Giaan <gianmarco@...1664...= 26...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: ordex <a@...2181...> <= /div>
Gerrit-Comment-Date: Thu, 17 Oct 2024 14:50:31= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
Gerrit-MessageType: comment
--zzOSbbzbSdE=--