Return-Path: Received: from forward102j.mail.yandex.net ([5.45.198.243]:40677 "EHLO forward102j.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752411AbeCMLFl (ORCPT ); Tue, 13 Mar 2018 07:05:41 -0400 From: Alexander Zubkov To: Luca Boccassi , Stephen Hemminger Cc: "netdev@vger.kernel.org" In-Reply-To: <3677951520930804@web6j.yandex.ru> References: <20180312210301.12757-1-stephen@networkplumber.org> <1520890670.31389.1.camel@debian.org> <3677951520930804@web6j.yandex.ru> Subject: Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes" MIME-Version: 1.0 Message-Id: <1084221520939138@web32g.yandex.ru> Date: Tue, 13 Mar 2018 12:05:38 +0100 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 Sender: netdev-owner@vger.kernel.org List-ID: Hello again, The fun thing is that before the commit "ip route ls all" showed all routes, but "ip -[4|6] route ls all" showed only default. So it was broken too, but in other way. I see parsing of prefix was changed since my patch. So I need several days to propose fix. I think if "ip route ls [all|any]" shows all routes and "ip route ls default" shows only default, everybody will be happy with that? 13.03.2018, 09:46, "Alexander Zubkov" : > Hello. > > May be the better way would be to change how "all"/"any" argument behaves? My original concern was about "default" only. I agree too, that "all" or "any" should work for all routes. But not for the default. > > 12.03.2018, 22:37, "Luca Boccassi" : >>  On Mon, 2018-03-12 at 14:03 -0700, Stephen Hemminger wrote: >>>   This reverts commit 9135c4d6037ff9f1818507bac0049fc44db8c3d2. >>> >>>   Debian maintainer found that basic command: >>>           # ip route flush all >>>   No longer worked as expected which breaks user scripts and >>>   expectations. It no longer flushed all IPv4 routes. >>> >>>   Reported-by: Luca Boccassi >>>   Signed-off-by: Stephen Hemminger >>>   --- >>>    ip/iproute.c | 65 ++++++++++++++++++------------------------------ >>>   ------------ >>>    lib/utils.c  | 13 ++++++++++++ >>>    2 files changed, 32 insertions(+), 46 deletions(-) >> >>  Tested-by: Luca Boccassi >> >>  Thanks, solves the problem. I'll backport it to Debian. >> >>  Alexander, reproducing the issue is quite simple - before that commit, >>  ip route ls all showed all routes, but with the change it started >>  showing only the default table. Same for ip route flush. >> >>  -- >>  Kind regards, >>  Luca Boccassi