Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD38BC48297 for ; Tue, 6 Feb 2024 19:03:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D876A10EDFE; Tue, 6 Feb 2024 19:03:29 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; secure) header.d=web.de header.i=markus.elfring@web.de header.b="Snf7yBIv"; dkim-atps=neutral Received: from mout.web.de (mout.web.de [212.227.15.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id CC8F110F2D3 for ; Tue, 6 Feb 2024 19:03:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1707246168; x=1707850968; i=markus.elfring@web.de; bh=FYZc1LEGrrqC1+w/ETxpgrgL8ru/UNKTc7lQka6Mvbg=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=Snf7yBIvBzdWtiPR583PSVgqSpFc+/OpYFMacVTjpyprUXgQ2Exz+eHxwFeQiAXE JVfFsoGq94BOjFIct7UHF7wYdeDZVrJC2BB3z6pHbnuaPtn/72Q3dR7cLDKvX+9o5 KDiBR1DNVMH3iJ298Lga78mBDr0TbL5mRLz2TxpcHT7pCz3HgWpOIdAs/SA0QfS58 EgacUkcYCjmvqX9JxWZ7p5gadhf48ThZb8cdQfKAionthqgr0lym69FMbwfMlFGXM 447hE+UwicdCUWlJ/19kbNQx1n7pRpGZEMDhFpj3d58G+MMckj5182KuuS0LddZ3k mOmw6gmPdDL1SFdj+w== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MzCA3-1qkhoC3NdT-00wGTb; Tue, 06 Feb 2024 20:02:47 +0100 Message-ID: <10c0148d-696d-4601-8852-ee5bfea19602@web.de> Date: Tue, 6 Feb 2024 20:02:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2] drm/hisilicon: Use devm_platform_ioremap_resource() in dsi_parse_dt() Content-Language: en-GB To: Douglas Anderson , dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, Daniel Vetter , David Airlie , John Stultz , Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Sumit Semwal , Thomas Zimmermann , Tian Tao , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Xinliang Liu , Xinwei Kong , Yongqin Liu Cc: LKML References: From: Markus Elfring In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:2kLa2ysUN9d2xVJRXxMU5jwpcPqpCNCqfK5aQK8Z8SZkAoJmwrI 51MM/OnKS58cjcH+w2KlM8svznfZhdOBNIzjMDwK+K8nqwSAScyS+mLVhS6oKLmKh+VXXlc 1F6sEjS7xdTg8/21QqOUqKV1QyEdUdwoFdL+s/lcAJTJzCmMxIqipPhlZnFOq799DZAX1NB 9P19bitGoqHTmYyAN2Wkg== UI-OutboundReport: notjunk:1;M01:P0:xkHi6bv8veo=;zt+BIeoCQAK8OkXMxk0kXGXRY+r Rl8t1SaL8N0etUcfbX9GFRZy8E2nr1PX3ujh9LTGIK0cv38ewfHlw8lfcIoqw3LGi0f90ZjPh c6DNCURdreKjJw19DEYeS9o82zVUeyTGA+Bw1gsQlRNTpY8cFzNPIbF0VT2vyUR40IHQH5FIH lV6E46PmNXz9oIiWrc5fVZR2Mh3OEQEE55aQ6z3r6jrlJV1yBICrtnnjDigXV+Vfidz1MjlaW 2WdU8IjpYR+HAQ+Cgs/U7u5BiHkClvJdSUBjWatzI6icJ8hmd/Oi3YKVPp9xDy7xBcVdWecj4 9bOk/qAownBHf/u9ZuK3CjW6u2AZhvz+0x8i5ADLQbCR2wVjGKYU5pdTdhgpElVgMAtFYP3Qe Sgya4Wfy72SyyUcJHk11TFvHO1GrVLDah39vEWGi1xOKNFZyrBqvbnB2f0no8/nqmldzVNS/Q 2I3Pf7EyuYB+D+UkhB01eEKpbkUU6uRfiauH/EHO1nsu4w1hMoa9e3LdeJiSpxlH3NS3rn81I Pqaxb2VRpTpVE6NW0741ZEnMSOig9lHsrPIVRsS3eqFqBFcp6yCSrXGvtC5ZmGvMgK5VFcMf8 Cl/Ymv1F3VYlOaWwICKtWtoMsojpj8vjspij47KuRpE3sfB9Wec+PCobopea1DFqFS8Vq7IGy eFOfE6b2Tfnc6hNlh2KhWGqoQUyHr9ops39+tW0OmGYRoLkkSL9ObWW3YSNkEBTM5BwRLVkg1 gfwn5lEbHgWeMvstj8jjDmcWS7ehyWxVml8Vhyft0UKXe4Tw8fUpT1i5lrWPPNrKBNREdcFYL BqLNDFina4Yyjn+FExNsJbbATCdsZ0XGoSSOd79j0clbo= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Markus Elfring Date: Tue, 6 Feb 2024 19:51:25 +0100 A wrapper function is available since the commit 7945f929f1a77a1c8887a97ca= 07f87626858ff42 ("drivers: provide devm_platform_ioremap_resource()"). * Thus reuse existing functionality instead of keeping duplicate source co= de. * Delete a local variable which became unnecessary with this refactoring. This issue was transformed by using the Coccinelle software. Reviewed-by: Douglas Anderson Signed-off-by: Markus Elfring =2D-- v2: The transformation pattern was adjusted based on advices by known contribu= tors. Examples: * Douglas Anderson * Geert Uytterhoeven * Robin Murphy drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/dr= m/hisilicon/kirin/dw_drm_dsi.c index 566de4658719..6db6f355394c 100644 =2D-- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c +++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c @@ -826,7 +826,6 @@ static const struct component_ops dsi_ops =3D { static int dsi_parse_dt(struct platform_device *pdev, struct dw_dsi *dsi) { struct dsi_hw_ctx *ctx =3D dsi->ctx; - struct resource *res; ctx->pclk =3D devm_clk_get(&pdev->dev, "pclk"); if (IS_ERR(ctx->pclk)) { @@ -834,8 +833,7 @@ static int dsi_parse_dt(struct platform_device *pdev, = struct dw_dsi *dsi) return PTR_ERR(ctx->pclk); } - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - ctx->base =3D devm_ioremap_resource(&pdev->dev, res); + ctx->base =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(ctx->base)) { DRM_ERROR("failed to remap dsi io region\n"); return PTR_ERR(ctx->base); =2D- 2.43.0