Content-Type: multipart/mixed; boundary="===============5640718402815450627==" MIME-Version: 1.0 From: Rong Chen To: kbuild-all@lists.01.org Subject: Re: [PATCH 3/3] platform: chrome: Added cros-ec-typec driver Date: Thu, 14 Nov 2019 08:55:47 +0800 Message-ID: <10ca6424-26bb-54b6-ea67-c782ebfb6813@intel.com> In-Reply-To: List-Id: --===============5640718402815450627== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 11/14/19 1:23 AM, Jon Flatley wrote: > On Wed, Nov 13, 2019 at 4:55 AM kbuild test robot wrote: >> Hi Jon, >> >> Thank you for the patch! Perhaps something to improve: >> >> [auto build test WARNING on ljones-mfd/for-mfd-next] >> [cannot apply to v5.4-rc7 next-20191113] >> [if your patch is applied to the wrong git tree, please drop us a note t= o help >> improve the system. BTW, we also suggest to use '--base' option to speci= fy the >> base tree in git format-patch, please see https://stackoverflow.com/a/37= 406982] >> >> url: https://github.com/0day-ci/linux/commits/Jon-Flatley/ChromeOS-EC= -USB-C-Connector-Class/20191113-193504 >> base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-= mfd-next >> >> If you fix the issue, kindly add following tag >> Reported-by: kbuild test robot >> >> >> coccinelle warnings: (new ones prefixed by >>) >> >>>> drivers/platform/chrome/cros_ec_typec.c:223:9-16: ERROR: PTR_ERR appli= ed after initialization to constant on line 222 >> vim +223 drivers/platform/chrome/cros_ec_typec.c >> >> 206 >> 207 static int cros_typec_add_partner(struct typec_data *typec, int= port_num, >> 208 bool pd_enabled) >> 209 { >> 210 struct port_data *port; >> 211 struct typec_partner_desc p_desc; >> 212 int ret; >> 213 >> 214 port =3D typec->ports[port_num]; >> 215 p_desc.usb_pd =3D pd_enabled; >> 216 p_desc.identity =3D &port->p_identity; >> 217 >> 218 port->partner =3D typec_register_partner(port->port, &p= _desc); >> 219 if (IS_ERR_OR_NULL(port->partner)) { >> 220 dev_err(typec->dev, "Port %d partner register f= ailed\n", >> 221 port_num); >> > 222 port->partner =3D NULL; >> > 223 return PTR_ERR(port->partner); >> 224 } >> 225 >> 226 ret =3D cros_typec_query_pd_info(typec, port_num); >> 227 if (ret < 0) { >> 228 dev_err(typec->dev, "Port %d PD query failed\n"= , port_num); >> 229 typec_unregister_partner(port->partner); >> 230 port->partner =3D NULL; >> 231 return ret; >> 232 } >> 233 >> 234 ret =3D typec_partner_set_identity(port->partner); >> 235 return ret; >> 236 } >> 237 >> >> --- >> 0-DAY kernel test infrastructure Open Source Technology = Center >> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Cor= poration > This patch is based off of the chrome-platform for-next branch. > > base: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/lin= ux.git > for-next > > Is this incorrect? I'm happy to rebase if necessary. > > Thanks, > -Jon Hi Jon, Thanks for the response, we'll fix the wrong base ASAP. Best Regards, Rong Chen --===============5640718402815450627==--