From: Hollis Blanchard Subject: Re: Re: [patch] final header fixes Date: Fri, 25 Mar 2005 10:22:50 -0600 Message-ID: <1111767770.6060.3.camel@localhost.localdomain> References: <200503231601.02096.hollisb@us.ibm.com> <200503241503.19423.hollisb@us.ibm.com> <3d8eece2050324132438c4ca3b@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit In-Reply-To: <3d8eece2050324132438c4ca3b@mail.gmail.com> Sender: xen-devel-admin@lists.sourceforge.net Errors-To: xen-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Christian.Limpach@cl.cam.ac.uk Cc: xen-devel@lists.sourceforge.net, Dan Magenheimer List-Id: xen-devel@lists.xenproject.org On Thu, 2005-03-24 at 21:24 +0000, Christian Limpach wrote: > On Thu, 24 Mar 2005 15:03:19 -0600, Hollis Blanchard wrote: > > On Thursday 24 March 2005 14:40, Dan Magenheimer wrote: > > > This second patch looks good to me, though I would prefer > > > to change to '#include ' from 'struct xen_regs;' > > > as xen_regs is #define'd to pt_regs on ia64 and the explicit > > > use of struct xen_regs in a header could cause header ordering > > > problems later. Will that work for ppc? > > > > Ah, sure... I was just trying to avoid extra dependency trees where possible. > > Apparently it is not possible here. :) > > > > So that should be #include (which includes arch-*.h which > > defines xen_regs). It looks like we may want to move ia64's #define to > > arch-ia64.h ... > > Could you please include asm/regs.h or public/xen.h wherever you want > to include keyhandler.h? Thanks. That works great, until somebody other than me includes or modifies keyhandler.h (or any of the other headers we've been talking about). I guess I don't see the difficulty in making sure you include what you use...? -- Hollis Blanchard IBM Linux Technology Center ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click