From: Hollis Blanchard Subject: [patch] non-SMP build fix Date: Thu, 31 Mar 2005 16:14:56 -0600 Message-ID: <1112307296.15374.18.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-r5TDlIqbIxVgv+ZpJVpj" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Xen-devel List-Id: xen-devel@lists.xenproject.org --=-r5TDlIqbIxVgv+ZpJVpj Content-Type: text/plain Content-Transfer-Encoding: 7bit With CONFIG_SMP undefined, this patch is needed to fix these errors: schedule.c: In function `schedulers_start': schedule.c:559: warning: statement with no effect schedule.c:562: warning: statement with no effect Non-SMP build still doesn't work on x86 because touch_nmi_watchdog is declared in asm/apic.h, and there is no policy of including the headers you use. I would suggest moving the declaration to an arch-neutral header. -- Hollis Blanchard IBM Linux Technology Center --=-r5TDlIqbIxVgv+ZpJVpj Content-Disposition: attachment; filename=xen-smp_call_function.diff Content-Type: text/x-patch; name=xen-smp_call_function.diff; charset=UTF-8 Content-Transfer-Encoding: 7bit ===== include/xen/smp.h 1.8 vs edited ===== --- 1.8/xen/include/xen/smp.h 2005-03-29 15:10:07 -06:00 +++ edited/include/xen/smp.h 2005-03-31 15:49:11 -06:00 @@ -86,7 +86,7 @@ #define kernel_lock() #define cpu_logical_map(cpu) 0 #define cpu_number_map(cpu) 0 -#define smp_call_function(func,info,retry,wait) 0 +#define smp_call_function(func,info,retry,wait) ((void)0) #define smp_subset_call_function(f,i,w,c) ({ if ( (c&1) ) (*f)(i); 0; }) #define cpu_online_map 1 --=-r5TDlIqbIxVgv+ZpJVpj Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --=-r5TDlIqbIxVgv+ZpJVpj--