Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5414C43334 for ; Mon, 6 Jun 2022 17:44:06 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 93B5183E9F; Mon, 6 Jun 2022 19:44:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=prevas.dk header.i=@prevas.dk header.b="Jr5wCXuL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8DA1E83E9F; Mon, 6 Jun 2022 19:44:01 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2071d.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1b::71d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C6FBA83E9F for ; Mon, 6 Jun 2022 19:43:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rasmus.villemoes@prevas.dk ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NC0VUc6r/gZp143YoPLXvdb8xUdhQFYJerWOOAopRgRcjmEuD+Wq3dKUgF2e+ZxtLbabk+1Wxh+kmpDXtudyvODbv+OdNiYhqoRH3oWZNZvB5XIQcR+znebBFtVYQZwUS1IIPNgQeeTWNhShSBFu916kEkComA9N8TyZ2PqgOMPa8QwWUF76wSZ7BA7i7zbdayDZrRrM8mRh7mwAfUukd7wsi0Bt9Zi121btJRaw4yijmcM1lexrsuUwznhZN/TPCBKKX8ERc4KNPdUkpKD0J7BICkoQsAGlEPZigf97l8G2nAl4L5ALZmkRBRP+VQmayGE2rs3dc91028QoDFGPBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xfv3exRcbAzFBPds/nnw5eFVTs/uunX0CvyZMxM4K80=; b=j6gf3iKy4LfOWw1ytV+kwQApRFMXQqc28rdeu5dhHJK9HOU453F+QbMUSOgPVKU/PI9FsyPkKk5BduFKzBzDKdnsOWxuihnyojEJWpn8wyGcbYnEHAwQjzZHqxCketl1jJ6D/CflWwUw4S6mGzod0sxtDFYI9zvfkkOgbpsci0DqdWgfA/9e3HWmvU5AXb/2RUoOBqbgDHTadnW3xFHedhgtbZ7eHeLfkvR9RMi0fNMNXCVHOvwnr8nGxGOVMBuQdbiVC+wToS0zyO6eZoJzivMi95E6HZ9M+d6aOgpX21Z3BZVLz2t7wMRLr/J8hec97CD2kSNKBzUk6sZWpOOXsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=prevas.dk; dmarc=pass action=none header.from=prevas.dk; dkim=pass header.d=prevas.dk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevas.dk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xfv3exRcbAzFBPds/nnw5eFVTs/uunX0CvyZMxM4K80=; b=Jr5wCXuLoLPVffqdWO4YUi+0qQocaKpuN3kJMdj2YPOrA9B6xPNbjzukPP3wQx8ZXKSv28WmVd4g1uViW/+M8NOMGSh4trG+FuhItQTSXqiZIrlFg7yjVv2s4bZbZDptKt5oRPQrfXvX4kjUvsd5CabiiylAhM+OI+8qwd0j1dw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=prevas.dk; Received: from DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:34a::22) by VI1PR10MB2415.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:803:8a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Mon, 6 Jun 2022 17:43:56 +0000 Received: from DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM ([fe80::edf8:6e1a:8d97:57ee]) by DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM ([fe80::edf8:6e1a:8d97:57ee%6]) with mapi id 15.20.5314.019; Mon, 6 Jun 2022 17:43:56 +0000 Message-ID: <111657a7-ea22-e306-8498-c6d3be218e71@prevas.dk> Date: Mon, 6 Jun 2022 19:43:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] crypto: fsl_hash: Remove unnecessary alignment check in caam_hash() Content-Language: en-US To: Stefan Roese , u-boot@lists.denx.de Cc: Gaurav Jain , dullfire@yahoo.com References: <20220429133444.419224-1-sr@denx.de> From: Rasmus Villemoes In-Reply-To: <20220429133444.419224-1-sr@denx.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0123.eurprd04.prod.outlook.com (2603:10a6:20b:531::20) To DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:34a::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b2fa8e88-6fa0-4b1a-77a5-08da47e41ff4 X-MS-TrafficTypeDiagnostic: VI1PR10MB2415:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eyK8GYHOZJ4XYrI3Kcxq2Sb8M9iqXoFEVciGD/W82Aqk4vTXbniNrAdEHnR2OxQJ0BidChjTopdA1vpHsOtDM34xKLPKe6X6V51/rF4VibN70x76JI0jmrl9IMKjGSBuqz4zoMv2NPOxHZpdxA7mZfrJne1JbHqXkU/eHkdMrIO1qPCHYcU6OGxyBPcBMh9RiZvn+cid9iIv+IszxAa/Sbwc0noC2e6OfSBs942GgriK12UZnH+C+xHXmiVSATHByw/lhcwcbQ3qEtbh+h92ffH5249NrhJh+Aw59lR90U6bZ2Kl+NNGlOMXXCzW+IkO2Brtma8e04sf2aPrfK8m3BS9HkqkwjfCxH/iBYBM1NcLdgffskeRy0LM+NzvYjsDzgvklhJJaI10kEGvqxZ6sm+pDUx5Uh9HDJSeDLzu/m2a73NeD8kyO/A2GudbG3Ema0CyDk7JfXhKob88e/p+7F2vdNBNNptHfJ6B7WT3Ggj5lR9T1VjS+GAvUHWNR6G7/OxYDvkVjOBEcXOeDwmRfLLk490nJkngqGBMYmkRWltifJSElKUQMhUnsMDSm+bB7kTBP3wNEPXN1gYJSXHZDCKJXsNCyQicrRq5ug7LsNo/ao8jqIl6933Kl3pjxLOEVMNHPV0ntaoHQlX6PzaM4hP23mhfZtC4NaoEzUrZ7NH6cj9+CrcIaj2J2VWpFP5XmaqrsnPm1v1VeJH8DogHtsf4EasrTRKgOvZRbQ2iT5GmIcKBvAeWtm+Ce2Wjn0O3F8WCGuOT2HLrmcqGmc0zWA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230001)(366004)(186003)(2616005)(44832011)(4744005)(8976002)(5660300002)(8936002)(6512007)(6506007)(508600001)(26005)(52116002)(31686004)(83380400001)(6666004)(6486002)(36756003)(38100700002)(86362001)(31696002)(38350700002)(66946007)(316002)(66476007)(66556008)(8676002)(4326008)(2906002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OW9YQkhmSkZpc3ZxdU0rUERnR3Urc05zT0RXMDYzOElRREliQjhaVmlLeUJQ?= =?utf-8?B?bjJSUEU5V1c0RlRFR1FSNVNVRDNsTXpuYWErVzYxQ0hDYU5MVDkvcFVIVHRi?= =?utf-8?B?MXBBK2xPZm1PY0hLQ1NWQndPNzJZby9MUjFmQlFhNHdseDREanZraWNjSG1t?= =?utf-8?B?Q21ncFhuSFMwLzFlNmFobm5DYS94R2RtcE9ZbEw5WXNDanQ2cmVaTXN6aGNq?= =?utf-8?B?MGdyVFhXeVhHaS9KWG5udGNnY3NCR2xYVWpKcDJMZ2dnQXZYeFZVT0hQcTdl?= =?utf-8?B?Z1FQRFVUdU9mdk5oNjBPWkQ3MW1NMURHc0w2M3c0WGVHd2c2R0x2QXF3VC9t?= =?utf-8?B?V3p4YlhBbTdoNVV1ZklOZjZxeFlMSzlTL0pzYVJ4RTV6aWhlTXBmenpWbTE1?= =?utf-8?B?WXBOSDVpcjlYVXYrdXhzRlZoWUNFUzJqTVYvWWVPTW4zK25jVEtwdUpWTUdj?= =?utf-8?B?L28vOHd1Z09qRis5LzRYSVBTVG84aDEyVkpoQ2sxcjduWGYrMmRHT0g5S2ZJ?= =?utf-8?B?YWppZWhNM0xJM3h3K216L2NwaVdvNzlpWmd0NTA1Q0xWaGlVVXZGWXhDcG5L?= =?utf-8?B?a1hDcjJhMytodlp0UVo2NkwwK3h5VjFRdGZCV01GTEFFOVcxZkU5VzFHa1c3?= =?utf-8?B?YjQ5Y0V3cmhwVHNpZHdSQ1ZiS2xJSDZYdjBqMklWMDFwVXhhU2Q2QTA1elp3?= =?utf-8?B?V25aa0ozZ3d5RjV4RHZBQVZDQnlBcHRkdW4xSFVyM2Y5VCt0K3JMYUEwQith?= =?utf-8?B?ZE1iTXIyU0NxK0dXR3pWeWVCajR5RzZFdnhFUS9XOVpSL0RTdGpsd2thUWg5?= =?utf-8?B?NGYyZ09ZT3NNcktCbW1NbjdXVTJNV2dNcTZzemJocWVlTHkyaTcxeDBYOG40?= =?utf-8?B?aUpJNDNpTVMyNmI3a0F5L1JRVjgzRkJ2TlFzNzRnV1loZG0yS3hWWFY2ZXAr?= =?utf-8?B?RllxTUhORlNMekdXdlhuNlkyaTZxZ1B3cU9Vd1BTWkxxcm5EeWR4OU94Y0Ny?= =?utf-8?B?WnhxQ0NLQXZCK3FjWjVMRDZFb2xISWF6U2FydDVqU0Nna3l6SThmWDhMRVR4?= =?utf-8?B?c3lBdWZCMi80dVJlVzRTVWNLTWJLaVF6UDdGV3RWazh3NHFLV2h3b3g4cDhB?= =?utf-8?B?aitsRElZUVgrdjlSM3RLaWdjS2I3SXcyYlFadUVVUURXaU9wZm5mdXkxUmNa?= =?utf-8?B?bmJVa21sMm1LUHdHa1RzSzFURTZrNDE0TkdGOE9PWE1uWGNGNXhXTGNoTmpR?= =?utf-8?B?eHlUMm5MVUIyZEhXZE92K2JocCtxNkJyVnJsTmEyWjlsK2FyQW4wMzdvQldw?= =?utf-8?B?RVE0YWhIYW1Cb2tTMmszOTNXYVUzSzZoQmlnRjZXeEZlSWRCblloM3E2cmxS?= =?utf-8?B?S09tM2NKWld1OFRHbU5zVTdlckJ0M09pL3BsTVc5R0duRjY0dlRzenVGZXNT?= =?utf-8?B?aTZqRno5UHlEMk5VT1paSW9uY09Mbk9GZHp5VFAyeE9GdzVqWUQ3TEpmRzFi?= =?utf-8?B?NEFrelQ5WlUveUZmTno0bm93UHZhZ3FhVHIyQlFJVHNXbkphbndMVjZTOExp?= =?utf-8?B?UFRMc2dNN2hwcElQN3J6QVlCckdIR1QrSDRqVDExRU5NSVR5V0dxaFlwbmw5?= =?utf-8?B?TE05T1RmU1psdXVCWTIrUy9KYkJ2MlVjcEVNS1pXVVM3cmZuaTV6NDBPRXFN?= =?utf-8?B?QUlRNGZPVWpTNFY5TDhtMWl6NFYyelZ1MEpndVIzWXp6OHNpMmptY1hUT3dh?= =?utf-8?B?dFB6S1RLTlEweFVkNjJvek45Njl5eUcvTENaaXByZXcyRGV1ekU3YmMxek9r?= =?utf-8?B?Ky9wdVJuVXgyWmJIdUw4K3NSaERXSUVHTFQvcFpOOTFPTUI1S1dUYkh6MVAw?= =?utf-8?B?YUprNzNQZnZ2TGxEUXpTOVB0Z1N3SllmU0luY0NWSUR0TkFyNnIrWE4rNjRs?= =?utf-8?B?cDdXdjBOSUVMSDNIUFJpZmpodGdBZlMvMlMyU08vOTJ0akpZZnR6UzlPYktB?= =?utf-8?B?VWRoVnVtUEJlRWJmWGEzQzRzcURJRzBtaWQ4SnZ1Y251dGhEdjhwbzQ5ZURB?= =?utf-8?B?M2RWUnVMMTFYZjBGWlJZNGduVjhMUlQ2TzYzZE9ZTkZlSkxiLzFSUkh6NHJQ?= =?utf-8?B?U2h3RGlyRDdtK3lVM1lwKzE1Tkw0LzB5azMyZ3czTXJ6S3h2RUdNeVJMVDA5?= =?utf-8?B?SWN0VzVMWEdzcTE5ZG5JRG5DQWlDZkduRHdrVE1qaFExeUdkeU9CTGpkd3dh?= =?utf-8?B?NGtPVkJDNlVYZUdSKzFzRDQraU0zYzN5WktSRGwyY0Uxd0I3clRIeVFtOVlz?= =?utf-8?B?YUVMSXFndkV3d3FJZkdMZlNvbWdtWkllUHkySlJNTElhYWFtemMrbzRuRWM0?= =?utf-8?Q?fZUGGlbLZ7Q2ASUY=3D?= X-OriginatorOrg: prevas.dk X-MS-Exchange-CrossTenant-Network-Message-Id: b2fa8e88-6fa0-4b1a-77a5-08da47e41ff4 X-MS-Exchange-CrossTenant-AuthSource: DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2022 17:43:56.5428 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rDCt9JSbzXdAe1DEEczBHXvJhu+7V0Na0YLSJMf7nq7Y6m0KfEj26yfbrSOOff6QdmtAn9Rby7mF6tva5Xh3fzcU3WuyWTmFdqCDOPj9YgY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR10MB2415 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 29/04/2022 15.34, Stefan Roese wrote: > While working on an LX2160 based board and updating to latest mainline > I noticed problems using the HW accelerated hash functions on this > platform, when trying to boot a FIT Kernel image. Here the resulting > error message: > > Using 'conf-freescale_lx2160a.dtb' configuration > Trying 'kernel-1' kernel subimage > Verifying Hash Integrity ... sha256Error: Address arguments are not aligned > CAAM was not setup properly or it is faulty > error! > Bad hash value for 'hash-1' hash node in 'kernel-1' image node > Bad Data Hash > ERROR: can't get kernel image! > > Testing and checking with Gaurav Jain from NXP has revealed, that this > alignment check is not necessary here at all. So let's remove this > check completely. Any chance this could make it into 2022.07? Rasmus