From: Markus Elfring Date: Sat, 09 Nov 2019 16:37:45 +0000 Subject: [PATCH] ARM: OMAP2+: Add missing put_device() call in omapdss_init_of() Message-Id: <112eb5b9-bca7-41ca-efc9-1104b6063f75@web.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Laurent Pinchart , Russell King , Sebastian Reichel , Tomi Valkeinen , Tony Lindgren Cc: kernel-janitors@vger.kernel.org, LKML From: Markus Elfring Date: Sat, 9 Nov 2019 17:19:35 +0100 A coccicheck run provided information like the following. arch/arm/mach-omap2/display.c:268:2-8: ERROR: missing put_device; call of_find_device_by_node on line 258, but without a corresponding object release within this function. Generated by: scripts/coccinelle/free/put_device.cocci Thus add the missed function call to fix the exception handling for this function implementation. Fixes: e0c827aca0730b51f38081aa4e8ecf0912aab55f ("drm/omap: Populate DSS children in omapdss driver") Signed-off-by: Markus Elfring --- arch/arm/mach-omap2/display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c index 439e143cad7b..46012ca812f4 100644 --- a/arch/arm/mach-omap2/display.c +++ b/arch/arm/mach-omap2/display.c @@ -265,6 +265,7 @@ static int __init omapdss_init_of(void) r = of_platform_populate(node, NULL, NULL, &pdev->dev); if (r) { pr_err("Unable to populate DSS submodule devices\n"); + put_device(&pdev->dev); return r; } -- 2.24.0