From: Rusty Russell Subject: __ia64__ ifdef in xmalloc.c: "Fix ar.unat handling for fast paths" Date: Mon, 21 Nov 2005 15:53:18 +1100 Message-ID: <1132548798.1478.7.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Xen Mailing List Cc: Tony Breeds , djm@kirby.fc.hp.com List-Id: xen-devel@lists.xenproject.org Hi all, While browsing the code, I noticed this in xmalloc.c: #ifndef __ia64__ BUG_ON(align > SMP_CACHE_BYTES); #endif This is clearly wrong: due to header alignment we cannot give you a greater alignment than SMP_CACHE_BYTES. Overriding this will cause the allocation to succeed, but not give the alignment requested. It usually indicates the caller should be fixed. Does someone with an ia64 box know why, or want to rip it out and see what breaks? Thanks! Rusty. -- A bad analogy is like a leaky screwdriver -- Richard Braakman