From: Rusty Russell <rusty@rustcorp.com.au>
Subject: [PATCH] dom0_ops -EPERM not -EACCES?
Date: Thu, 24 Nov 2005 12:35:42 +1100
Message-ID: <1132796142.25612.8.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xense-devel@lists.xensource.com
Cc: Xen Mailing List <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Hi all,

	dom0_ops return -EACCES when the interface version in wrong.  I think
that an acm failure is closer to being non-priv'ed, which returns
-EPERM.  Wouldn't want dom0 tools to report they were the wrong version
just because ACM limited some operation, surely?

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (authored)

diff -r e2d1c88d50f7 xen/common/dom0_ops.c
--- a/xen/common/dom0_ops.c	Thu Nov 24 00:55:37 2005
+++ b/xen/common/dom0_ops.c	Thu Nov 24 12:31:37 2005
@@ -102,7 +102,7 @@
         return -EACCES;
 
     if ( acm_pre_dom0_op(op, &ssid) )
-        return -EACCES;
+        return -EPERM;
 
     spin_lock(&dom0_lock);
 

-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman