From: Gawain Lynch Subject: Re: [PATCH] [RFC] sysfs support for xen linux Date: Wed, 11 Jan 2006 02:23:20 +1300 Message-ID: <1136899400.25819.17.camel@legolas.felicity.net.au> References: <43C2F324.4020407@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <43C2F324.4020407@us.ibm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com, "Mike D. Day" List-Id: xen-devel@lists.xenproject.org > diff -r c08884b412da -r cec2fc0a07c6 linux-2.6-xen-sparse/arch/xen/kernel/xen_sysfs.c > --- /dev/null Mon Jan 9 21:55:13 2006 > +++ b/linux-2.6-xen-sparse/arch/xen/kernel/xen_sysfs.c Mon Jan 9 23:07:04 2006 > +#ifndef BOOL > +#define BOOL int > +#endif > + > +#ifndef FALSE > +#define FALSE 0 > +#endif > + > +#ifndef TRUE > +#define TRUE 1 > +#endif > + > +#ifndef NULL > +#define NULL 0 > +#endif These are already defined in kernel and a favourite nit pick on LKML. > +struct xen_sysfs_attr > +{ struct xen_sysfs_attr { New line for braces are reserved for functions() > +struct xen_sysfs_object > +{ struct xen_sysfs_object { > --- /dev/null Mon Jan 9 21:55:13 2006 > +++ b/linux-2.6-xen-sparse/include/asm-xen/xen_sysfs.h Mon Jan 9 23:07:04 2006 > +#ifndef BOOL > +#define BOOL int > +#endif > + > +#ifndef FALSE > +#define FALSE 0 > +#endif > + > +#ifndef TRUE > +#define TRUE 1 > +#endif > + > +#ifndef NULL > +#define NULL 0 > +#endif > See above...