From: Dave Hansen Subject: Re: [RFC] [PATCH] sysfs support for Xen attributes Date: Wed, 11 Jan 2006 10:45:26 -0800 Message-ID: <1137005126.27584.71.camel@localhost.localdomain> References: <43C53DA0.60704@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <43C53DA0.60704@us.ibm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Mike D. Day" Cc: xen-devel@lists.xensource.com, lkml List-Id: xen-devel@lists.xenproject.org On Wed, 2006-01-11 at 12:17 -0500, Mike D. Day wrote: > +#ifndef BOOL > +#define BOOL int > +#endif > + > +#ifndef FALSE > +#define FALSE 0 > +#endif > + > +#ifndef TRUE > +#define TRUE 1 > +#endif > + > +#ifndef NULL > +#define NULL 0 > +#endif Whatever you do with this driver, these need to go. Your patch is also whitespace-challenged. Why not make these Xen attributes part of the "system" devices? Seems a lot more natural to me. -- Dave