From: "flichtenheld (Code Review)" Date: Wed, 1 Apr 2026 10:34:38 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <1140488e3ea1af942fce40fdd43e13e997eb8c21-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="84+ocA3LKck="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: OpenSSL 4.0: Use X509_check_certificate_times instead of X509_cmp_time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --84+ocA3LKck= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerr= it.openvpn.net/c/openvpn/+/1595?usp=3Demail ) Change subject: OpenSSL 4.0: Use X509_check_certificate_times instead of X5= 09_cmp_time ...................................................................... Patch Set 2: Code-Review-1 (2 comments) File src/openvpn/ssl_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1595/comment/ce3d6801_f2791ace?usp=3D= email : PS2, Line 691: msg(D_TLS_DEBUG_MED, "Failed to initialise certifica= te verification parameters."); Shouldn't we return from the function here? http://gerrit.openvpn.net/c/openvpn/+/1595/comment/ed877e20_2571c8e7?usp=3D= email : PS2, Line 708: if (ret =3D=3D X509_V_ERR_ERROR_IN_CERT_NOT_AFTER_FIELD) error, not ret -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1595?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6c2eda0e5bbb3a70b404f821e25ded81f0f5ddd5 Gerrit-Change-Number: 1595 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Wed, 01 Apr 2026 10:34:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes --84+ocA3LKck= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

Patch set 2:Code-Review -1=

V= iew Change

2 comments:

  • File src/openvpn/ssl_openssl.c= :

    • Patc= h Set #2, Line 691: = msg(D_TLS_DEBUG_MED, "Failed to initialise certificate verificati= on parameters.");

      Shouldn't we return from the function= here?

    • Patch Set #2, Line 708: if (ret =3D=3D X509_V_ERR_ERROR_I= N_CERT_NOT_AFTER_FIELD)

      error, not ret

To view, visit change 1595. To unsubscribe, or for help writing mail filters= , visit settings= .

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6c2eda0e5bbb3a70b404f821e25= ded81f0f5ddd5
Gerrit-Change-Number: 1595
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Comment-Date: Wed, 01 Apr 2026 10:34:38= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
= --84+ocA3LKck=--